[mythtv-commits] [MythTV/mythtv] 5b2a03: tidy: Fix a "use-auto" warning. (libmythtv/recorders)

Fri Apr 30 13:35:29 UTC 2021

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 5b2a032674df9c2cbe71117aa2eb6f8ff33194a7
      https://github.com/MythTV/mythtv/commit/5b2a032674df9c2cbe71117aa2eb6f8ff33194a7
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-28 (Wed, 28 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/satiprtcppacket.cpp

  Log Message:
  -----------
  tidy: Fix a "use-auto" warning. (libmythtv/recorders)

  Commit: 8f1d18f20da6d09f722c9fef8afe3ef6aa5a1b32
      https://github.com/MythTV/mythtv/commit/8f1d18f20da6d09f722c9fef8afe3ef6aa5a1b32
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-28 (Wed, 28 Apr 2021)

  Changed paths:
    M mythplugins/mytharchive/mytharchive/fileselector.cpp
    M mythplugins/mytharchive/mytharchive/logviewer.cpp

  Log Message:
  -----------
  tidy: Fix range base for-loop warnings. (mytharchive).

  Commit: 541c52468dd2e727f0d1361930a29742869c0c83
      https://github.com/MythTV/mythtv/commit/541c52468dd2e727f0d1361930a29742869c0c83
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-28 (Wed, 28 Apr 2021)

  Changed paths:
    M mythplugins/mythgame/mythgame/gamehandler.cpp

  Log Message:
  -----------
  tidy: Replace a couple of for loops with std::copy_if statements. (mythgame)

Also fix a clazy warning about mixing const and non-const iters.

  Commit: 125fb87cf5130ae357d4c82a49ea0bb9bc96effc
      https://github.com/MythTV/mythtv/commit/125fb87cf5130ae357d4c82a49ea0bb9bc96effc
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-28 (Wed, 28 Apr 2021)

  Changed paths:
    M mythplugins/mythmusic/mythmusic/decoder.cpp
    M mythplugins/mythmusic/mythmusic/importmusic.cpp

  Log Message:
  -----------
  tidy: Fix a couple of warnings. (mythmusic)

Quiet warning about using a range-based loop.  Range-based loops over
Qt containers should use the qAsConst macro, but that would then make
the object inside the loop const and then it couldn't be modified.

Also pass a paramater to a lambda function by reference.

  Commit: f8b13394145e8728c011ae77e9f91437a4c8ddc8
      https://github.com/MythTV/mythtv/commit/f8b13394145e8728c011ae77e9f91437a4c8ddc8
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-28 (Wed, 28 Apr 2021)

  Changed paths:
    M mythplugins/mythweather/mythweather/weatherScreen.cpp
    M mythplugins/mythweather/mythweather/weatherSetup.cpp

  Log Message:
  -----------
  tidy: Convert a couple of loops to be range-based. (mythweather)

  Commit: 793018cd3c8ed2d7f78b653a5bef8c91ca6148ee
      https://github.com/MythTV/mythtv/commit/793018cd3c8ed2d7f78b653a5bef8c91ca6148ee
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-28 (Wed, 28 Apr 2021)

  Changed paths:
    M mythplugins/mythmusic/mythmusic/playlisteditorview.cpp
    M mythplugins/mythweather/mythweather/weatherSource.cpp
    M mythtv/libs/libmythbase/mythcorecontext.cpp
    M mythtv/libs/libmythprotoserver/requesthandler/fileserverhandler.cpp
    M mythtv/libs/libmythtv/decoders/mythv4l2m2mcontext.cpp
    M mythtv/libs/libmythtv/recorders/cetonrtsp.cpp
    M mythtv/libs/libmythupnp/upnpcds.cpp
    M mythtv/programs/mythbackend/upnpcdsmusic.cpp
    M mythtv/programs/mythfrontend/statusbox.cpp
    M mythtv/programs/mythfrontend/videodlg.cpp

  Log Message:
  -----------
  clazy: Remove unused variables. (mythplugins)

  Commit: a5322c783b025ed969482da4ba7527b3db682ad1
      https://github.com/MythTV/mythtv/commit/a5322c783b025ed969482da4ba7527b3db682ad1
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-28 (Wed, 28 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythbase/mythsorthelper.cpp
    M mythtv/libs/libmythbase/remotefile.cpp

  Log Message:
  -----------
  tidy: Convert a of loops to be range-based. (libmythbase)

Convert one loop into a call to std::anyof.

Mark one loop as not convertable because range-based loops over Qt
containers should use the qAsConst macro, but that would then make the
object inside the loop const and then it couldn't be modified.

  Commit: 9450f1d8be76d5619b3558e07610c53f5379f251
      https://github.com/MythTV/mythtv/commit/9450f1d8be76d5619b3558e07610c53f5379f251
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-28 (Wed, 28 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythtv/AirPlay/mythraopconnection.cpp

  Log Message:
  -----------
  tidy: Convert a of loops to be range-based. (AirPlay)

  Commit: 0bdd14da281147a25b41bdeb3740ac0d6a133185
      https://github.com/MythTV/mythtv/commit/0bdd14da281147a25b41bdeb3740ac0d6a133185
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-28 (Wed, 28 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/channelscan_sm.cpp
    M mythtv/libs/libmythtv/channelscan/channelscanner_gui.cpp

  Log Message:
  -----------
  tidy: Convert a couple of loops to be range-based. (libmythtv/channelscan)

  Commit: 7a24e4014440c0525d700cfe66f61b67ddb34c94
      https://github.com/MythTV/mythtv/commit/7a24e4014440c0525d700cfe66f61b67ddb34c94
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-28 (Wed, 28 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythtv/channelsettings.cpp
    M mythtv/libs/libmythtv/eitfixup.cpp
    M mythtv/libs/libmythtv/mythvideoprofile.cpp
    M mythtv/libs/libmythtv/recorders/hdhrstreamhandler.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/videosource.cpp

  Log Message:
  -----------
  tidy: Convert a couple of loops to be range-based. (libmythtv)

  Commit: d9ad17f06bcbdf04ed2a1bd0f1c71e603bf6ad73
      https://github.com/MythTV/mythtv/commit/d9ad17f06bcbdf04ed2a1bd0f1c71e603bf6ad73
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-28 (Wed, 28 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythui/mythdialogbox.cpp
    M mythtv/libs/libmythui/mythuibuttonlist.cpp
    M mythtv/libs/libmythui/mythuispinbox.cpp
    M mythtv/libs/libmythui/mythuitype.cpp

  Log Message:
  -----------
  tidy: Convert a couple of loops to be range-based. (libmythui)

  Commit: 9330b42af74f8de83fb0cd73ab242be93a391894
      https://github.com/MythTV/mythtv/commit/9330b42af74f8de83fb0cd73ab242be93a391894
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-28 (Wed, 28 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythupnp/httpserver.cpp
    M mythtv/libs/libmythupnp/serializers/xmlSerializer.cpp
    M mythtv/libs/libmythupnp/xsd.cpp

  Log Message:
  -----------
  tidy: Convert a couple of loops to be range-based. (libmythupnp)

  Commit: f6c58ab2992821c8498a28f0df9323c1546dc25e
      https://github.com/MythTV/mythtv/commit/f6c58ab2992821c8498a28f0df9323c1546dc25e
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-28 (Wed, 28 Apr 2021)

  Changed paths:
    M mythtv/programs/mythbackend/mainserver.cpp
    M mythtv/programs/mythbackend/services/video.cpp

  Log Message:
  -----------
  tidy: Modernize a couple of loops. (mythbackend)

Convert a couple of loops to be range-based. Convert a couple of other
loops to use std::transform.

  Commit: 163db72fd4ec40c86c8f79b1b51f6fdfb82a67b9
      https://github.com/MythTV/mythtv/commit/163db72fd4ec40c86c8f79b1b51f6fdfb82a67b9
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-28 (Wed, 28 Apr 2021)

  Changed paths:
    M mythtv/programs/mythcommflag/main.cpp

  Log Message:
  -----------
  tidy: Convert a loop to be range-based. (mythcommflag)

  Commit: 2be52b7d9cad641efce410ce0f7cb1654835c30c
      https://github.com/MythTV/mythtv/commit/2be52b7d9cad641efce410ce0f7cb1654835c30c
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-28 (Wed, 28 Apr 2021)

  Changed paths:
    M mythtv/programs/mythfilldatabase/filldata.cpp

  Log Message:
  -----------
  tidy: Convert a loop to be range-based. (mythfilldatabase)

  Commit: f6aff6e84afe49a1bd730075fcf22bfe40d1d5fb
      https://github.com/MythTV/mythtv/commit/f6aff6e84afe49a1bd730075fcf22bfe40d1d5fb
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-28 (Wed, 28 Apr 2021)

  Changed paths:
    M mythtv/programs/mythfrontend/proglist_helpers.cpp

  Log Message:
  -----------
  tidy: Convert a couple of loops to be range-based. (mythfrontend)

  Commit: 9ee650390ca9c53b035b811f78185c715e24588a
      https://github.com/MythTV/mythtv/commit/9ee650390ca9c53b035b811f78185c715e24588a
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-28 (Wed, 28 Apr 2021)

  Changed paths:
    M mythtv/programs/mythtv-setup/backendsettings.cpp
    M mythtv/programs/mythtv-setup/channeleditor.cpp
    M mythtv/programs/mythtv-setup/importicons.cpp

  Log Message:
  -----------
  tidy: Convert a couple of loops to be range-based. (mythtv-setup)

  Commit: 0152a69b7dfb0bb6ae2ab0c41491ca9a7adcc9ce
      https://github.com/MythTV/mythtv/commit/0152a69b7dfb0bb6ae2ab0c41491ca9a7adcc9ce
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-28 (Wed, 28 Apr 2021)

  Changed paths:
    M mythtv/programs/mythutil/markuputils.cpp
    M mythtv/programs/mythutil/mpegutils.cpp

  Log Message:
  -----------
  tidy: Convert a couple of loops to be range-based. (mythutil)

  Commit: db641e38443d6aadf3abfea1a2f8e8184e3c32b9
      https://github.com/MythTV/mythtv/commit/db641e38443d6aadf3abfea1a2f8e8184e3c32b9
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-28 (Wed, 28 Apr 2021)

  Changed paths:
    M mythtv/libs/libmyth/programinfo.cpp

  Log Message:
  -----------
  tidy: Convert a loop to be range-based. (libmyth)

  Commit: 7d152a972311d0883e72879094d61e788c2df184
      https://github.com/MythTV/mythtv/commit/7d152a972311d0883e72879094d61e788c2df184
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-28 (Wed, 28 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythtv/captions/cc708window.h
    M mythtv/libs/libmythtv/captions/subtitlescreen.h

  Log Message:
  -----------
  Silence a couple of clang-tidy warnings. (libmythtv)

There are a couple of structures that seem to have changed
significantly between Qt5 and Qt6. When clang-tidy is run against a
Qt5 based build of MythTV it recommends one action, and when run
against a Qt6 build it recommends a contrary action. (Whether to move
or copy an object when it is passed a parameter to a function.)
Silence the warning that occurs in Qt6 until that becomes the
predominant version used in releases.

Compare: https://github.com/MythTV/mythtv/compare/e913b5a08c4c...7d152a972311