[mythtv-commits] [MythTV/mythtv] 48288c: qt6: Rewrite NAMThread::isAvailable because of obs...

David Hampton noreply at github.com
Fri Apr 23 12:04:48 UTC 2021


  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 48288cf177c4138c106cbb8664d12a9054ab5120
      https://github.com/MythTV/mythtv/commit/48288cf177c4138c106cbb8664d12a9054ab5120
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythtv/mheg/netstream.cpp

  Log Message:
  -----------
  qt6: Rewrite NAMThread::isAvailable because of obsoleted functions.

The QNetworkAccessManager::networkAccessible function was deprecated
in Qt5.15 and removed in Qt6. Rewrite this function using the
QNetworkInterface functions to discover if any of the interfaces is
running. (Note that neither version of this function tells you which
interface is up or if you can connect to anything.)


  Commit: 0b6dfb448b44c319439bbbebc146e22b88bac8c9
      https://github.com/MythTV/mythtv/commit/0b6dfb448b44c319439bbbebc146e22b88bac8c9
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythplugins/mytharchive/mytharchive/archiveutil.cpp
    M mythplugins/mytharchive/mytharchive/importnative.cpp
    M mythplugins/mytharchive/mytharchive/main.cpp
    M mythplugins/mytharchive/mytharchive/recordingselector.cpp
    M mythplugins/mytharchive/mytharchive/videoselector.cpp
    M mythplugins/mytharchive/mytharchivehelper/main.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in mytharchive.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: 100c04d3c7efd0131f87ca7a88961247fe42a28b
      https://github.com/MythTV/mythtv/commit/100c04d3c7efd0131f87ca7a88961247fe42a28b
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythplugins/mythgame/mythgame/gamehandler.cpp
    M mythplugins/mythgame/mythgame/main.cpp
    M mythplugins/mythgame/mythgame/rom_metadata.cpp
    M mythplugins/mythgame/mythgame/rominfo.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in mythgame.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: eec60071ee1e9ad31613211239149cd5011484db
      https://github.com/MythTV/mythtv/commit/eec60071ee1e9ad31613211239149cd5011484db
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythplugins/mythmusic/mythmusic/avfdecoder.cpp
    M mythplugins/mythmusic/mythmusic/cdrip.cpp
    M mythplugins/mythmusic/mythmusic/decoderhandler.cpp
    M mythplugins/mythmusic/mythmusic/editmetadata.cpp
    M mythplugins/mythmusic/mythmusic/lyricsview.cpp
    M mythplugins/mythmusic/mythmusic/main.cpp
    M mythplugins/mythmusic/mythmusic/musiccommon.cpp
    M mythplugins/mythmusic/mythmusic/musicdbcheck.cpp
    M mythplugins/mythmusic/mythmusic/musicplayer.cpp
    M mythplugins/mythmusic/mythmusic/playlisteditorview.cpp
    M mythplugins/mythmusic/mythmusic/streamview.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in mythmusic.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: 2939645bb362c7509f7b401f5c3672c82271f562
      https://github.com/MythTV/mythtv/commit/2939645bb362c7509f7b401f5c3672c82271f562
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythplugins/mythnetvision/mythnetvision/netbase.cpp
    M mythplugins/mythnetvision/mythnetvision/netcommon.cpp
    M mythplugins/mythnetvision/mythnetvision/neteditorbase.cpp
    M mythplugins/mythnetvision/mythnetvision/netsearch.cpp
    M mythplugins/mythnetvision/mythnetvision/nettree.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in mythnetvision.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: e26e39de55f2bda51bfadb009b943e8676d45f2b
      https://github.com/MythTV/mythtv/commit/e26e39de55f2bda51bfadb009b943e8676d45f2b
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythplugins/mythnews/mythnews/mythnewsconfig.cpp
    M mythplugins/mythnews/mythnews/newssite.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in mythnews.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: 6af9f531305f83ad715cd5bbe7779dc705c299f0
      https://github.com/MythTV/mythtv/commit/6af9f531305f83ad715cd5bbe7779dc705c299f0
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythplugins/mythweather/mythweather/main.cpp
    M mythplugins/mythweather/mythweather/weatherSetup.cpp
    M mythplugins/mythweather/mythweather/weatherSource.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in mythweather.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: b6f34f0bc16f9da936084aab10a1492f0261469f
      https://github.com/MythTV/mythtv/commit/b6f34f0bc16f9da936084aab10a1492f0261469f
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythplugins/mythzoneminder/mythzoneminder/main.cpp
    M mythplugins/mythzoneminder/mythzoneminder/zmclient.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in mythzoneminder.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: 62f2bb4e7866ab6fc674a217e87a8943ca46b9b5
      https://github.com/MythTV/mythtv/commit/62f2bb4e7866ab6fc674a217e87a8943ca46b9b5
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmyth/audio/audiooutput.cpp
    M mythtv/libs/libmyth/audio/audiooutputalsa.cpp
    M mythtv/libs/libmyth/audio/audiooutputbase.cpp
    M mythtv/libs/libmyth/audio/audiooutputpulse.cpp
    M mythtv/libs/libmyth/audio/audiopulsehandler.cpp
    M mythtv/libs/libmyth/audio/eldutils.cpp
    M mythtv/libs/libmyth/audio/spdifencoder.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in libmyth/audio.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: 9b3c797f0b3c78870c8f14961740389696716c7f
      https://github.com/MythTV/mythtv/commit/9b3c797f0b3c78870c8f14961740389696716c7f
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmyth/backendselect.cpp
    M mythtv/libs/libmyth/langsettings.cpp
    M mythtv/libs/libmyth/mediamonitor-unix.cpp
    M mythtv/libs/libmyth/mythcontext.cpp
    M mythtv/libs/libmyth/mythmediamonitor.cpp
    M mythtv/libs/libmyth/netgrabbermanager.cpp
    M mythtv/libs/libmyth/netutils.cpp
    M mythtv/libs/libmyth/programinfo.cpp
    M mythtv/libs/libmyth/remoteutil.cpp
    M mythtv/libs/libmyth/rssparse.cpp
    M mythtv/libs/libmyth/schemawizard.cpp
    M mythtv/libs/libmyth/standardsettings.cpp
    M mythtv/libs/libmyth/test/test_programinfo/test_programinfo.h

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in libmyth.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: 77ee9e36266040681c81af4158ab0be358075c97
      https://github.com/MythTV/mythtv/commit/77ee9e36266040681c81af4158ab0be358075c97
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythbase/bonjourregister.cpp
    M mythtv/libs/libmythbase/dbcheckcommon.cpp
    M mythtv/libs/libmythbase/dbutil.cpp
    M mythtv/libs/libmythbase/housekeeper.cpp
    M mythtv/libs/libmythbase/mythcdrom-linux.cpp
    M mythtv/libs/libmythbase/mythcdrom.cpp
    M mythtv/libs/libmythbase/mythcommandlineparser.cpp
    M mythtv/libs/libmythbase/mythcorecontext.cpp
    M mythtv/libs/libmythbase/mythdb.cpp
    M mythtv/libs/libmythbase/mythdbcon.cpp
    M mythtv/libs/libmythbase/mythdirs.cpp
    M mythtv/libs/libmythbase/mythdownloadmanager.cpp
    M mythtv/libs/libmythbase/mythlocale.cpp
    M mythtv/libs/libmythbase/mythmedia.cpp
    M mythtv/libs/libmythbase/mythmiscutil.cpp
    M mythtv/libs/libmythbase/mythpower.cpp
    M mythtv/libs/libmythbase/mythsession.cpp
    M mythtv/libs/libmythbase/mythsingledownload.cpp
    M mythtv/libs/libmythbase/mythsocket.cpp
    M mythtv/libs/libmythbase/mythsystemunix.cpp
    M mythtv/libs/libmythbase/mythtranslation.cpp
    M mythtv/libs/libmythbase/mythtypes.cpp
    M mythtv/libs/libmythbase/platforms/mythpowerdbus.cpp
    M mythtv/libs/libmythbase/remotefile.cpp
    M mythtv/libs/libmythbase/serverpool.cpp
    M mythtv/libs/libmythbase/storagegroup.cpp
    M mythtv/libs/libmythbase/unzip.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in libmythbase.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: b6c6789fae93d4de066a80985b84064c9bd76955
      https://github.com/MythTV/mythtv/commit/b6c6789fae93d4de066a80985b84064c9bd76955
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythfreemheg/BaseClasses.cpp
    M mythtv/libs/libmythfreemheg/Engine.cpp
    M mythtv/libs/libmythfreemheg/Programs.cpp
    M mythtv/libs/libmythfreemheg/Root.cpp
    M mythtv/libs/libmythfreemheg/Text.cpp
    M mythtv/libs/libmythfreemheg/Variables.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in libmythfreemheg.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: d49de9d231373db2162ba9e1c6a058b57a46e47f
      https://github.com/MythTV/mythtv/commit/d49de9d231373db2162ba9e1c6a058b57a46e47f
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythmetadata/bluraymetadata.cpp
    M mythtv/libs/libmythmetadata/dbaccess.cpp
    M mythtv/libs/libmythmetadata/dirscan.cpp
    M mythtv/libs/libmythmetadata/imagemanager.cpp
    M mythtv/libs/libmythmetadata/metadatadownload.cpp
    M mythtv/libs/libmythmetadata/metadatagrabber.cpp
    M mythtv/libs/libmythmetadata/metadataimagedownload.cpp
    M mythtv/libs/libmythmetadata/metaioid3.cpp
    M mythtv/libs/libmythmetadata/musicfilescanner.cpp
    M mythtv/libs/libmythmetadata/musicmetadata.cpp
    M mythtv/libs/libmythmetadata/musicutils.cpp
    M mythtv/libs/libmythmetadata/mythuiimageresults.cpp
    M mythtv/libs/libmythmetadata/mythuimetadataresults.cpp
    M mythtv/libs/libmythmetadata/videometadata.cpp
    M mythtv/libs/libmythmetadata/videoscan.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in libmythmetadata.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: 7d7cd424274b1d743da894259eeb8a23a3c5ac11
      https://github.com/MythTV/mythtv/commit/7d7cd424274b1d743da894259eeb8a23a3c5ac11
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythprotoserver/requesthandler/deletethread.cpp
    M mythtv/libs/libmythprotoserver/requesthandler/fileserverhandler.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in libmythprotoserver.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: e12d53d1fe4eda48f62e7e26b5e989a9e67df78d
      https://github.com/MythTV/mythtv/commit/e12d53d1fe4eda48f62e7e26b5e989a9e67df78d
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythtv/AirPlay/mythairplayserver.cpp
    M mythtv/libs/libmythtv/AirPlay/mythraopconnection.cpp
    M mythtv/libs/libmythtv/AirPlay/mythraopdevice.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in libmythtv/AirPlay

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: a4eaeec4caa6229244448bd3c29f2a21dcbb0967
      https://github.com/MythTV/mythtv/commit/a4eaeec4caa6229244448bd3c29f2a21dcbb0967
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythtv/Bluray/mythbdbuffer.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in libmythtv/Bluray.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: 8c54475416c6408db77554caa6461b114a325cba
      https://github.com/MythTV/mythtv/commit/8c54475416c6408db77554caa6461b114a325cba
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythtv/DVD/mythdvddecoder.cpp
    M mythtv/libs/libmythtv/DVD/mythdvdstream.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in libmythtv/DVD.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: f1fb1d87da07e1bba7ac78c0a9c0fca0e3309306
      https://github.com/MythTV/mythtv/commit/f1fb1d87da07e1bba7ac78c0a9c0fca0e3309306
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythtv/HLS/httplivestream.cpp
    M mythtv/libs/libmythtv/HLS/httplivestreambuffer.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in libmythtv/HLS.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: 517f20b55a9a9ea3911fe5e8687e35d8731c8280
      https://github.com/MythTV/mythtv/commit/517f20b55a9a9ea3911fe5e8687e35d8731c8280
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythtv/captions/cc608decoder.cpp
    M mythtv/libs/libmythtv/captions/subtitlescreen.cpp
    M mythtv/libs/libmythtv/captions/textsubtitleparser.cpp
    M mythtv/libs/libmythtv/captions/vbi608extractor.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in libmythtv/captions.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: a20e3f2597e6da5f980bc85b85a91e6afa70d925
      https://github.com/MythTV/mythtv/commit/a20e3f2597e6da5f980bc85b85a91e6afa70d925
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/channelimporter.cpp
    M mythtv/libs/libmythtv/channelscan/channelscan_sm.cpp
    M mythtv/libs/libmythtv/channelscan/channelscanner.cpp
    M mythtv/libs/libmythtv/channelscan/channelscanner_cli.cpp
    M mythtv/libs/libmythtv/channelscan/externrecscanner.cpp
    M mythtv/libs/libmythtv/channelscan/iptvchannelfetcher.cpp
    M mythtv/libs/libmythtv/channelscan/multiplexsetting.cpp
    M mythtv/libs/libmythtv/channelscan/paneatsc.h
    M mythtv/libs/libmythtv/channelscan/paneexistingscanimport.h
    M mythtv/libs/libmythtv/channelscan/scanmonitor.cpp
    M mythtv/libs/libmythtv/channelscan/scanwizardconfig.cpp
    M mythtv/libs/libmythtv/channelscan/vboxchannelfetcher.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in libmythtv/channelscan.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: a1f5ed23fc173859ff1cbb466669ad1ca3b898cb
      https://github.com/MythTV/mythtv/commit/a1f5ed23fc173859ff1cbb466669ad1ca3b898cb
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythtv/io/mythfifowriter.cpp
    M mythtv/libs/libmythtv/io/mythiowrapper.cpp
    M mythtv/libs/libmythtv/io/mythmediabuffer.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in libmythtv/io.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: be917c5a47059aa398bf7c219f260884f8581956
      https://github.com/MythTV/mythtv/commit/be917c5a47059aa398bf7c219f260884f8581956
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythtv/mheg/dsmcccache.cpp
    M mythtv/libs/libmythtv/mheg/netstream.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in libmythtv/mheg.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: dd289591648bf3057a8809c25ea90cf0ab880c0a
      https://github.com/MythTV/mythtv/commit/dd289591648bf3057a8809c25ea90cf0ab880c0a
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythtv/mpeg/atscdescriptors.cpp
    M mythtv/libs/libmythtv/mpeg/atsctables.cpp
    M mythtv/libs/libmythtv/mpeg/dishdescriptors.cpp
    M mythtv/libs/libmythtv/mpeg/dvbdescriptors.cpp
    M mythtv/libs/libmythtv/mpeg/dvbdescriptors.h
    M mythtv/libs/libmythtv/mpeg/dvbtables.cpp
    M mythtv/libs/libmythtv/mpeg/mpegdescriptors.cpp
    M mythtv/libs/libmythtv/mpeg/mpegtables.cpp
    M mythtv/libs/libmythtv/mpeg/sctedescriptors.cpp
    M mythtv/libs/libmythtv/mpeg/sctetables.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in libmythtv/mpeg.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: f15b1e12b16214f8e4d2db488e503e7943982c51
      https://github.com/MythTV/mythtv/commit/f15b1e12b16214f8e4d2db488e503e7943982c51
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp
    M mythtv/libs/libmythtv/decoders/mythcodeccontext.cpp
    M mythtv/libs/libmythtv/decoders/mythdrmprimecontext.cpp
    M mythtv/libs/libmythtv/decoders/mythnvdeccontext.cpp
    M mythtv/libs/libmythtv/decoders/mythv4l2m2mcontext.cpp
    M mythtv/libs/libmythtv/decoders/mythvaapicontext.cpp
    M mythtv/libs/libmythtv/decoders/mythvdpaucontext.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in libmythtv/decoders.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: 0b8db1c38a287fb51824becd6dad8e92548f774f
      https://github.com/MythTV/mythtv/commit/0b8db1c38a287fb51824becd6dad8e92548f774f
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythtv/opengl/mythdrmprimeinterop.cpp
    M mythtv/libs/libmythtv/opengl/mythopenglvideo.cpp
    M mythtv/libs/libmythtv/opengl/mythvaapiinterop.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in libmythtv/opengl.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.

QString multiarg before version 5.14 had a limit of 9 string arguments
to a single call to QString::arg. Later versions have a higher limit,
probably the 99 limit on numbered place markers.


  Commit: e69dc6bab308389bd26c341f1a17c48a7dd13844
      https://github.com/MythTV/mythtv/commit/e69dc6bab308389bd26c341f1a17c48a7dd13844
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/ExternalChannel.cpp
    M mythtv/libs/libmythtv/recorders/ExternalRecChannelFetcher.cpp
    M mythtv/libs/libmythtv/recorders/ExternalStreamHandler.cpp
    M mythtv/libs/libmythtv/recorders/HLS/HLSSegment.cpp
    M mythtv/libs/libmythtv/recorders/analogsignalmonitor.cpp
    M mythtv/libs/libmythtv/recorders/asistreamhandler.cpp
    M mythtv/libs/libmythtv/recorders/audioinputalsa.cpp
    M mythtv/libs/libmythtv/recorders/cetonrtsp.cpp
    M mythtv/libs/libmythtv/recorders/cetonstreamhandler.cpp
    M mythtv/libs/libmythtv/recorders/channelbase.cpp
    M mythtv/libs/libmythtv/recorders/dtvrecorder.cpp
    M mythtv/libs/libmythtv/recorders/dtvsignalmonitor.cpp
    M mythtv/libs/libmythtv/recorders/dvbchannel.cpp
    M mythtv/libs/libmythtv/recorders/dvbstreamhandler.cpp
    M mythtv/libs/libmythtv/recorders/hdhrstreamhandler.cpp
    M mythtv/libs/libmythtv/recorders/hlsstreamhandler.cpp
    M mythtv/libs/libmythtv/recorders/httptsstreamhandler.cpp
    M mythtv/libs/libmythtv/recorders/importrecorder.cpp
    M mythtv/libs/libmythtv/recorders/iptvchannel.cpp
    M mythtv/libs/libmythtv/recorders/iptvstreamhandler.cpp
    M mythtv/libs/libmythtv/recorders/linuxfirewiredevice.cpp
    M mythtv/libs/libmythtv/recorders/mpegrecorder.cpp
    M mythtv/libs/libmythtv/recorders/recorderbase.cpp
    M mythtv/libs/libmythtv/recorders/satiprtsp.cpp
    M mythtv/libs/libmythtv/recorders/satipstreamhandler.cpp
    M mythtv/libs/libmythtv/recorders/satiputils.cpp
    M mythtv/libs/libmythtv/recorders/signalmonitor.cpp
    M mythtv/libs/libmythtv/recorders/streamhandler.cpp
    M mythtv/libs/libmythtv/recorders/v4l2encstreamhandler.cpp
    M mythtv/libs/libmythtv/recorders/v4lchannel.cpp
    M mythtv/libs/libmythtv/recorders/v4lrecorder.cpp
    M mythtv/libs/libmythtv/recorders/vboxutils.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in libmythtv/recorders.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: 0e5687c51c304350999bb080cbaf6fd64fcec271
      https://github.com/MythTV/mythtv/commit/0e5687c51c304350999bb080cbaf6fd64fcec271
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythtv/test/test_eitfixups/test_eitfixups.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in libmythtv/test.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: fcccb6b11dea7823195470d1fe656461cd882465
      https://github.com/MythTV/mythtv/commit/fcccb6b11dea7823195470d1fe656461cd882465
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythtv/vulkan/mythvideovulkan.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in libmythtv/vulkan.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: ee7e6da9651ea68fd69347bf2a1ea7b444df5411
      https://github.com/MythTV/mythtv/commit/ee7e6da9651ea68fd69347bf2a1ea7b444df5411
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythtv/jobqueue.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in libmythtv/jobqueue.cpp.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.

This commit also cleans up a number of log message detail strings that
are originally created as a QString, are converted to a QByteArray,
are converted to a 'const char *', and are then used as the parameter
to QString::arg. Drop all the unnecessary conversions and pass the
original details QString in the call to ::arg.


  Commit: 4775320f8609b537e254636188c7469ab81ffc78
      https://github.com/MythTV/mythtv/commit/4775320f8609b537e254636188c7469ab81ffc78
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythtv/programdata.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in libmythtv/programinfo.cpp.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: 624c341f97748754d6c5fba8c4915de1c141bd13
      https://github.com/MythTV/mythtv/commit/624c341f97748754d6c5fba8c4915de1c141bd13
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tv_rec.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in libmythtv/tv_*.cpp.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.

QString multiarg before version 5.14 had a limit of 9 string arguments
to a single call to QString::arg. Later versions have a higher limit,
probably the 99 limit on numbered place markers.


  Commit: 6dff0318d895e3eeaffc1f31a6b208ae9797d9c2
      https://github.com/MythTV/mythtv/commit/6dff0318d895e3eeaffc1f31a6b208ae9797d9c2
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythtv/cardutil.cpp
    M mythtv/libs/libmythtv/channelgroup.cpp
    M mythtv/libs/libmythtv/channelsettings.h
    M mythtv/libs/libmythtv/channelutil.cpp
    M mythtv/libs/libmythtv/dbcheck.cpp
    M mythtv/libs/libmythtv/deletemap.cpp
    M mythtv/libs/libmythtv/diseqc.cpp
    M mythtv/libs/libmythtv/dtvmultiplex.cpp
    M mythtv/libs/libmythtv/eitfixup.cpp
    M mythtv/libs/libmythtv/eitscanner.cpp
    M mythtv/libs/libmythtv/frequencytables.cpp
    M mythtv/libs/libmythtv/iptvtuningdata.h
    M mythtv/libs/libmythtv/livetvchain.cpp
    M mythtv/libs/libmythtv/mythccextractorplayer.cpp
    M mythtv/libs/libmythtv/mythplayeroverlayui.cpp
    M mythtv/libs/libmythtv/mythsystemevent.cpp
    M mythtv/libs/libmythtv/mythvideocolourspace.cpp
    M mythtv/libs/libmythtv/mythvideoout.cpp
    M mythtv/libs/libmythtv/mythvideooutgpu.cpp
    M mythtv/libs/libmythtv/mythvideoprofile.cpp
    M mythtv/libs/libmythtv/playercontext.cpp
    M mythtv/libs/libmythtv/playgroup.cpp
    M mythtv/libs/libmythtv/previewgenerator.cpp
    M mythtv/libs/libmythtv/previewgeneratorqueue.cpp
    M mythtv/libs/libmythtv/profilegroup.cpp
    M mythtv/libs/libmythtv/recordinginfo.cpp
    M mythtv/libs/libmythtv/recordingquality.cpp
    M mythtv/libs/libmythtv/recordingquality.h
    M mythtv/libs/libmythtv/recordingrule.cpp
    M mythtv/libs/libmythtv/scheduledrecording.cpp
    M mythtv/libs/libmythtv/signalmonitorvalue.cpp
    M mythtv/libs/libmythtv/signalmonitorvalue.h
    M mythtv/libs/libmythtv/transporteditor.cpp
    M mythtv/libs/libmythtv/v4l2util.cpp
    M mythtv/libs/libmythtv/videobuffers.cpp
    M mythtv/libs/libmythtv/videodbcheck.cpp
    M mythtv/libs/libmythtv/videosource.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in libmythtv.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: bbd8871dd4e7ef7aa012fd5d65911b9018a2eeba
      https://github.com/MythTV/mythtv/commit/bbd8871dd4e7ef7aa012fd5d65911b9018a2eeba
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythui/devices/jsmenu.cpp
    M mythtv/libs/libmythui/devices/lirc.cpp
    M mythtv/libs/libmythui/devices/mythcecadapter.cpp
    M mythtv/libs/libmythui/mythdisplay.cpp
    M mythtv/libs/libmythui/mythfontmanager.cpp
    M mythtv/libs/libmythui/mythfontproperties.cpp
    M mythtv/libs/libmythui/mythmainwindow.cpp
    M mythtv/libs/libmythui/mythrect.cpp
    M mythtv/libs/libmythui/myththemedmenu.cpp
    M mythtv/libs/libmythui/mythudplistener.cpp
    M mythtv/libs/libmythui/mythuibuttonlist.cpp
    M mythtv/libs/libmythui/mythuiclock.cpp
    M mythtv/libs/libmythui/mythuifilebrowser.cpp
    M mythtv/libs/libmythui/mythuiimage.cpp
    M mythtv/libs/libmythui/mythuitext.cpp
    M mythtv/libs/libmythui/mythuitextedit.cpp
    M mythtv/libs/libmythui/mythuithemecache.cpp
    M mythtv/libs/libmythui/mythuithemehelper.cpp
    M mythtv/libs/libmythui/mythuiutils.cpp
    M mythtv/libs/libmythui/mythuiwebbrowser.cpp
    M mythtv/libs/libmythui/opengl/mythrenderopengl.cpp
    M mythtv/libs/libmythui/platforms/mythdisplaymutter.cpp
    M mythtv/libs/libmythui/xmlparsebase.cpp
    M mythtv/libs/libmythui/xmlparsebase.h

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in libmythui.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: 2ab1c831290fbf988f8bc4cc926e9a4de368790d
      https://github.com/MythTV/mythtv/commit/2ab1c831290fbf988f8bc4cc926e9a4de368790d
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythupnp/httprequest.cpp
    M mythtv/libs/libmythupnp/httpserver.cpp
    M mythtv/libs/libmythupnp/mythxmlclient.cpp
    M mythtv/libs/libmythupnp/serverSideScripting.cpp
    M mythtv/libs/libmythupnp/servicehost.cpp
    M mythtv/libs/libmythupnp/soapclient.cpp
    M mythtv/libs/libmythupnp/ssdp.cpp
    M mythtv/libs/libmythupnp/ssdpcache.cpp
    M mythtv/libs/libmythupnp/upnpcds.cpp
    M mythtv/libs/libmythupnp/upnpcdsobjects.cpp
    M mythtv/libs/libmythupnp/upnpdevice.cpp
    M mythtv/libs/libmythupnp/upnpdevice.h
    M mythtv/libs/libmythupnp/upnphelpers.cpp
    M mythtv/libs/libmythupnp/upnpmsrr.cpp
    M mythtv/libs/libmythupnp/upnpserviceimpl.cpp
    M mythtv/libs/libmythupnp/upnpsubscription.cpp
    M mythtv/libs/libmythupnp/upnptasknotify.cpp
    M mythtv/libs/libmythupnp/upnptasksearch.cpp
    M mythtv/libs/libmythupnp/upnputil.cpp
    M mythtv/libs/libmythupnp/upnputil.h
    M mythtv/libs/libmythupnp/websocket.cpp
    M mythtv/libs/libmythupnp/wsdl.cpp
    M mythtv/libs/libmythupnp/xsd.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in libmythupnp.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: 0ff3aeb83be01781dffc8a12da7513949297b66b
      https://github.com/MythTV/mythtv/commit/0ff3aeb83be01781dffc8a12da7513949297b66b
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/programs/mythbackend/autoexpire.cpp
    M mythtv/programs/mythbackend/backendhousekeeper.cpp
    M mythtv/programs/mythbackend/httpconfig.cpp
    M mythtv/programs/mythbackend/internetContent.cpp
    M mythtv/programs/mythbackend/mainserver.cpp
    M mythtv/programs/mythbackend/mythsettings.cpp
    M mythtv/programs/mythbackend/scheduler.cpp
    M mythtv/programs/mythbackend/services/content.cpp
    M mythtv/programs/mythbackend/services/dvr.cpp
    M mythtv/programs/mythbackend/services/myth.cpp
    M mythtv/programs/mythbackend/services/serviceUtil.cpp
    M mythtv/programs/mythbackend/services/serviceUtil.h
    M mythtv/programs/mythbackend/upnpcdsmusic.cpp
    M mythtv/programs/mythbackend/upnpcdstv.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in mythbackend.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: 28c51d91985f75be73fca52e1d66edfba17950ce
      https://github.com/MythTV/mythtv/commit/28c51d91985f75be73fca52e1d66edfba17950ce
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/programs/mythbackend/mythsettings.cpp

  Log Message:
  -----------
  Remove redundant arguments from log messages.

QSring::arg will replace all instances of the lowest numbered
placeholder.  There is no need to pass a value multiple times.


  Commit: f7254228df3bd1f441a01f85ad7b4a25db84d934
      https://github.com/MythTV/mythtv/commit/f7254228df3bd1f441a01f85ad7b4a25db84d934
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/programs/mythcommflag/ClassicCommDetector.cpp
    M mythtv/programs/mythcommflag/CommDetector2.cpp
    M mythtv/programs/mythcommflag/FrameAnalyzer.cpp
    M mythtv/programs/mythcommflag/HistogramAnalyzer.cpp
    M mythtv/programs/mythcommflag/SceneChangeDetector.cpp
    M mythtv/programs/mythcommflag/TemplateFinder.cpp
    M mythtv/programs/mythcommflag/TemplateMatcher.cpp
    M mythtv/programs/mythcommflag/main.cpp
    M mythtv/programs/mythcommflag/pgm.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in mythcommflag.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: 6eaf44e00b6fb47bdbbf3fab5edf9a64bee03071
      https://github.com/MythTV/mythtv/commit/6eaf44e00b6fb47bdbbf3fab5edf9a64bee03071
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/programs/mythexternrecorder/MythExternControl.cpp
    M mythtv/programs/mythexternrecorder/MythExternRecApp.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in mythexternalrecorder.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: b9d978f0f5f6cc8e055bb185155b48496c188f6b
      https://github.com/MythTV/mythtv/commit/b9d978f0f5f6cc8e055bb185155b48496c188f6b
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/programs/mythfilldatabase/channeldata.cpp
    M mythtv/programs/mythfilldatabase/filldata.cpp
    M mythtv/programs/mythfilldatabase/main.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in mythfilldatabase.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: 7843881eb6e4aac989bb3eb6b0f6e5915e6cc09c
      https://github.com/MythTV/mythtv/commit/7843881eb6e4aac989bb3eb6b0f6e5915e6cc09c
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/programs/mythlcdserver/lcdprocclient.cpp
    M mythtv/programs/mythlcdserver/lcdserver.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in mythlcdserver.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: 1817072eb2043cc48974cb2489e322322f0a134c
      https://github.com/MythTV/mythtv/commit/1817072eb2043cc48974cb2489e322322f0a134c
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/programs/mythmetadatalookup/lookup.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in mythmetadatalookup.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: 94f61679d476bd0b415c393a704d855def1b8a07
      https://github.com/MythTV/mythtv/commit/94f61679d476bd0b415c393a704d855def1b8a07
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/programs/mythtranscode/main.cpp
    M mythtv/programs/mythtranscode/mpeg2fix.cpp
    M mythtv/programs/mythtranscode/transcode.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in mythtranscode.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: 42b49019488552d76214a8acbda365650d5e1e6f
      https://github.com/MythTV/mythtv/commit/42b49019488552d76214a8acbda365650d5e1e6f
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/programs/mythtv-setup/checksetup.cpp
    M mythtv/programs/mythtv-setup/importicons.cpp
    M mythtv/programs/mythtv-setup/main.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in mythtv-setup.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: 02c3e7ec6d25b17eed2968bc6a8bb96fe5dfdf30
      https://github.com/MythTV/mythtv/commit/02c3e7ec6d25b17eed2968bc6a8bb96fe5dfdf30
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/programs/mythutil/backendutils.cpp
    M mythtv/programs/mythutil/fileutils.cpp
    M mythtv/programs/mythutil/recordingutils.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in mythutil.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: ae4870a0fdd3e05842769be0ec3969d9c1b401c0
      https://github.com/MythTV/mythtv/commit/ae4870a0fdd3e05842769be0ec3969d9c1b401c0
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/programs/mythwelcome/welcomedialog.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in mythwelcome.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: 04e03de3829df5b421945a596d21ef06735e3cdb
      https://github.com/MythTV/mythtv/commit/04e03de3829df5b421945a596d21ef06735e3cdb
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/programs/mythfrontend/actionset.cpp
    M mythtv/programs/mythfrontend/audiogeneralsettings.cpp
    M mythtv/programs/mythfrontend/customedit.cpp
    M mythtv/programs/mythfrontend/custompriority.cpp
    M mythtv/programs/mythfrontend/editvideometadata.cpp
    M mythtv/programs/mythfrontend/galleryslide.cpp
    M mythtv/programs/mythfrontend/globalsettings.cpp
    M mythtv/programs/mythfrontend/guidegrid.cpp
    M mythtv/programs/mythfrontend/keygrabber.cpp
    M mythtv/programs/mythfrontend/main.cpp
    M mythtv/programs/mythfrontend/mythcontrols.cpp
    M mythtv/programs/mythfrontend/mythfexml.cpp
    M mythtv/programs/mythfrontend/networkcontrol.cpp
    M mythtv/programs/mythfrontend/playbackbox.cpp
    M mythtv/programs/mythfrontend/proglist.cpp
    M mythtv/programs/mythfrontend/programrecpriority.cpp
    M mythtv/programs/mythfrontend/schedulecommon.cpp
    M mythtv/programs/mythfrontend/services/frontend.cpp
    M mythtv/programs/mythfrontend/setupwizard_video.cpp
    M mythtv/programs/mythfrontend/statusbox.cpp
    M mythtv/programs/mythfrontend/themechooser.cpp
    M mythtv/programs/mythfrontend/upnpscanner.cpp
    M mythtv/programs/mythfrontend/videodlg.cpp
    M mythtv/programs/mythfrontend/videoglobalsettings.cpp
    M mythtv/programs/mythfrontend/videolist.cpp
    M mythtv/programs/mythfrontend/videoplayercommand.cpp
    M mythtv/programs/mythfrontend/viewscheduled.cpp
    M mythtv/programs/mythfrontend/viewschedulediff.cpp

  Log Message:
  -----------
  clazy: Combine multiple calls to QString::arg in mythfrontend.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.


  Commit: 3511853b1b9f84e66a6224ffa733ca2d2fb9f556
      https://github.com/MythTV/mythtv/commit/3511853b1b9f84e66a6224ffa733ca2d2fb9f556
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M .clazy

  Log Message:
  -----------
  clazy: Enable qstring argument check.

This check looks for consecutive calls to QString::arg with string
arguments can be combined into a single call. This reduces the number
of required string scans and (more importantly) reduces the number of
memory allocations.


  Commit: e1b7ef77eb253f56584446278c623a7be93b785a
      https://github.com/MythTV/mythtv/commit/e1b7ef77eb253f56584446278c623a7be93b785a
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythtv/dbcheck.cpp

  Log Message:
  -----------
  Fix "suspicious missing comma" warning.


  Commit: bf6cdfddcaf63c603c7daf4b7cee30adbc9a140a
      https://github.com/MythTV/mythtv/commit/bf6cdfddcaf63c603c7daf4b7cee30adbc9a140a
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M .clazy

  Log Message:
  -----------
  Update clazy checks.


  Commit: 91fd90b1c344b176d9785170931a8b5dd4c857ad
      https://github.com/MythTV/mythtv/commit/91fd90b1c344b176d9785170931a8b5dd4c857ad
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythupnp/httprequest.cpp
    M mythtv/libs/libmythupnp/serializers/jsonSerializer.cpp
    M mythtv/programs/mythfrontend/guidegrid.h
    M mythtv/programs/mythfrontend/main.cpp
    M mythtv/programs/mythscreenwizard/main.cpp

  Log Message:
  -----------
  Remove unnecessary include files.


  Commit: 6f4c4962f326d7058010c80cb0e79a4ebba89e9b
      https://github.com/MythTV/mythtv/commit/6f4c4962f326d7058010c80cb0e79a4ebba89e9b
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythbase/lcddevice.cpp
    M mythtv/libs/libmythupnp/eventing.cpp
    M mythtv/libs/libmythupnp/upnpcdsobjects.cpp
    M mythtv/libs/libmythupnp/upnpsubscription.cpp
    M mythtv/programs/mythfrontend/upnpscanner.cpp

  Log Message:
  -----------
  Only include QTextCodec for qt5 based builds.


  Commit: 52646bc127c36415001c8019a208b604d7e98c56
      https://github.com/MythTV/mythtv/commit/52646bc127c36415001c8019a208b604d7e98c56
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythtv/recordinginfo.cpp

  Log Message:
  -----------
  tidy: Add braces around clause.


  Commit: b1929913c0926233c11b6a3b0a222aa911ccd6ee
      https://github.com/MythTV/mythtv/commit/b1929913c0926233c11b6a3b0a222aa911ccd6ee
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/programs/mythbackend/services/serviceUtil.h

  Log Message:
  -----------
  tidy: Parameter name in definition should match declaration.


  Commit: 114b3d7468469f7562810489733b002cadb41c94
      https://github.com/MythTV/mythtv/commit/114b3d7468469f7562810489733b002cadb41c94
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/programs/mythbackend/services/dvr.cpp
    M mythtv/programs/mythbackend/services/serviceUtil.cpp

  Log Message:
  -----------
  tidy: Prevent implicit conversions in a loop.

The full text of the warning is:

    the type of the loop variable 'm' is different from the one returned
    by the iterator and generates an implicit conversion; you can either
    change the type to the matching one ('const QJsonValueRef &' but
    'const auto&' is always a valid option) or remove the reference to
    make it explicit that you are creating a new value


  Commit: 48ece4a1c3ae2acd9f7b920871a5123f0b92c92e
      https://github.com/MythTV/mythtv/commit/48ece4a1c3ae2acd9f7b920871a5123f0b92c92e
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/programs/mythbackend/services/dvr.cpp
    M mythtv/programs/mythbackend/services/serviceUtil.cpp

  Log Message:
  -----------
  tidy: Use "auto" to prevent duplicating type names.


  Commit: 931ebb19a603ba7ddf9fd1a7522587dd9887126f
      https://github.com/MythTV/mythtv/commit/931ebb19a603ba7ddf9fd1a7522587dd9887126f
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/programs/mythbackend/services/dvr.cpp

  Log Message:
  -----------
  tidy: Fix variable not initialized warning.

Use range based for loops.


  Commit: 8108c2ca8ece5ca1f1be8af561a5f21f7d2ec11e
      https://github.com/MythTV/mythtv/commit/8108c2ca8ece5ca1f1be8af561a5f21f7d2ec11e
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythtv/mythtvmenu.cpp
    M mythtv/libs/libmythtv/mythtvmenu.h
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tv_play.h

  Log Message:
  -----------
  qt6: Overhaul the MythTVMenuNodeTuple structure (part 1)

Some of the code using this data structure won't compile in qt6
because of an error that the default definition for the operator=
function would be ill-formed. This is a problem when serializing and
deserializing this data structure.

Part 1 converts the structure to use an enum to specify which menu in
the TV data structure is being referenced, instead of including the
complete xml menu definition as part of the data structure.

Work over Pass around a menu id instead of a serialized MythTVMenu structure.


  Commit: 92979556c51c0829ccd6168f873a964da2196e4c
      https://github.com/MythTV/mythtv/commit/92979556c51c0829ccd6168f873a964da2196e4c
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythtv/mythtvmenu.cpp
    M mythtv/libs/libmythtv/mythtvmenu.h
    M mythtv/libs/libmythtv/tv_play.cpp

  Log Message:
  -----------
  qt6: Overhaul the MythTVMenuNodeTuple structure (part 2)

Some of the code using this data structure won't compile in qt6
because of an error that the default definition for the operator=
function would be ill-formed. This is a problem when serializing and
deserializing this data structure.

Part 2 converts the structure to use an node path name in the
specified TV data structure member, instead of including the complete
xml text for the node.


  Commit: 40c6bac0349f41d7a4541c7c5a745f829bdaaee6
      https://github.com/MythTV/mythtv/commit/40c6bac0349f41d7a4541c7c5a745f829bdaaee6
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/configure

  Log Message:
  -----------
  qt6: Adjust qmake search path based on branch name.


  Commit: cc16d3b6d81a90292fdb0f9ebf5eb3f2a9302cde
      https://github.com/MythTV/mythtv/commit/cc16d3b6d81a90292fdb0f9ebf5eb3f2a9302cde
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythbase/mythcommandlineparser.cpp
    M mythtv/programs/mythfrontend/upnpscanner.cpp

  Log Message:
  -----------
  Switch to template version of QVariant::canConvert.


  Commit: e3a1bd6dbf1b64580a4b420f9832b0b535617133
      https://github.com/MythTV/mythtv/commit/e3a1bd6dbf1b64580a4b420f9832b0b535617133
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythbase/test/test_template/test_template.cpp
    M mythtv/libs/libmythbase/test/test_template/test_template.h

  Log Message:
  -----------
  Update the test template directory.

Move the functions to the test.cpp file. Add an example function that
uses a table of test data.


  Commit: 66a9d942e0640909b720b40886e2e1ded3f8cb8b
      https://github.com/MythTV/mythtv/commit/66a9d942e0640909b720b40886e2e1ded3f8cb8b
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    A mythtv/libs/libmythbase/test/test_mythbinaryplist/.gitignore
    A mythtv/libs/libmythbase/test/test_mythbinaryplist/Readme
    A mythtv/libs/libmythbase/test/test_mythbinaryplist/info_mac.bplist
    A mythtv/libs/libmythbase/test/test_mythbinaryplist/info_mac.plist
    A mythtv/libs/libmythbase/test/test_mythbinaryplist/info_mac_addl.bplist
    A mythtv/libs/libmythbase/test/test_mythbinaryplist/info_mac_addl.plist
    A mythtv/libs/libmythbase/test/test_mythbinaryplist/test_mythbinaryplist.cpp
    A mythtv/libs/libmythbase/test/test_mythbinaryplist/test_mythbinaryplist.h
    A mythtv/libs/libmythbase/test/test_mythbinaryplist/test_mythbinaryplist.pro

  Log Message:
  -----------
  Add a test case for mythbinaryplist.


  Commit: 69d12b67b625ed8baedd47feeff0174da6dedc46
      https://github.com/MythTV/mythtv/commit/69d12b67b625ed8baedd47feeff0174da6dedc46
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-23 (Fri, 23 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythbase/mythbinaryplist.cpp

  Log Message:
  -----------
  Fix mythbinaryplist.cpp to work everywhere.

The new test is crashing on several platforms. These are caused by the
convert_int function, which performs byte order swapping in place
before reading the value from memory. This works if a value is only
ever used once, but fails when values are read multiple times.

Rewrite the convert_int function to use the "be16toh" family of
functions fixes the crashes.

Rewrite the convert_float function.

Add the Core Data epoch offset to date conversion. Unix uses 1/1/1970
where Apple Core Data uses 1/1/2001.


Compare: https://github.com/MythTV/mythtv/compare/ebeea33ad284...69d12b67b625


More information about the mythtv-commits mailing list