[mythtv-commits] [MythTV/mythtv] 87a915: tidy: Fix "definition with different parameter nam...

[David Hampton]

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 87a915b963e176219d1c762a4286c9dd27e0f093
      https://github.com/MythTV/mythtv/commit/87a915b963e176219d1c762a4286c9dd27e0f093
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-01 (Thu, 01 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythtv/sourceutil.h

  Log Message:
  -----------
  tidy: Fix "definition with different parameter name" warning.


  Commit: d022a21b9a20896098f9f9a23bcc8096f270fe40
      https://github.com/MythTV/mythtv/commit/d022a21b9a20896098f9f9a23bcc8096f270fe40
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-01 (Thu, 01 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythtv/channelsettings.cpp

  Log Message:
  -----------
  tidy: Fix "equivalent expression on both sides of logical operator" warning.

I'm unclear why the compiler issued this warning. Looking at the
assembly the compiler was definitely using different values for DVBS
and DVBS2. I added parentheses which clarifies the statement a little
bit and makes the warning go away.


  Commit: 627defa3971b333dc5ab775d1c39a5dba3713f98
      https://github.com/MythTV/mythtv/commit/627defa3971b333dc5ab775d1c39a5dba3713f98
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-01 (Thu, 01 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp

  Log Message:
  -----------
  tidy: Fix a "redundant condition" warning.

The compiler is pointing out that the 'numStreams' variable has been
tested to see if it is non-zero, and later without any possibility of
the variable being changed it is again tested to see if it is
non-zero. The second test is unnecessary.


  Commit: f4c41850d0293ab99ba415e01cc7a68e38f0d433
      https://github.com/MythTV/mythtv/commit/f4c41850d0293ab99ba415e01cc7a68e38f0d433
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-01 (Thu, 01 Apr 2021)

  Changed paths:
    M mythtv/external/libexiv2/src/params.cpp

  Log Message:
  -----------
  Fix "unannotated fall-through" warnings.


  Commit: a7d1e9652dd6574a1530f74156fd9e1c8e656244
      https://github.com/MythTV/mythtv/commit/a7d1e9652dd6574a1530f74156fd9e1c8e656244
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-01 (Thu, 01 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythbase/mythcdrom-linux.cpp

  Log Message:
  -----------
  Fix "array subscript is partly outside array bounds" when compiling a hardened image.

Instead of declaring an array of characters and overlaying a structure
on top with a pointer, just declare the structure directly.


  Commit: 2d1bfd91570bd3730d92be2c92f6a2f1cc40351a
      https://github.com/MythTV/mythtv/commit/2d1bfd91570bd3730d92be2c92f6a2f1cc40351a
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-02 (Fri, 02 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythui/mythmainwindow.cpp

  Log Message:
  -----------
  Fix a couple of "potential null pointer dereference" warnings in mythmainwindow.cpp.

These warnings occur when building a harded image, so the optimization
is different from a normal build.

There are a number of places that call a function from the KeyContext
class using the form m_keyContexts.value(Context)->fn(). This looks
fine, except that the default constructor for this hash returns
nullptr. If "Context" doesn't already exist in the hash, this code
will crash.


  Commit: 9ec7e7d3b481a733fd1d0ead9e72724fc3709c29
      https://github.com/MythTV/mythtv/commit/9ec7e7d3b481a733fd1d0ead9e72724fc3709c29
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-02 (Fri, 02 Apr 2021)

  Changed paths:
    M mythtv/libs/libmythbase/mythdb.cpp
    M mythtv/libs/libmythbase/mythdbcon.cpp
    M mythtv/libs/libmythbase/mythdbcon.h

  Log Message:
  -----------
  qt6: Handle changes to the QSqlQuery class.

Qt6 removed the QSqlQuery::bindValues function to bind all query
values in one call. Working around this is easy since there is still a
function to bind a single value by name. Simply add a loop over the
binding values map to bind each value individually.

Qt6 also changed how the bindings are returned from a call to the
QSqlQuery::boundValues function. The return value is no longer a QMap
of named bindings and their values, but it is a QVariantList of the
binding values in numerical binding order.

There are two places where the binding values must be re-substituted
back into the query string. 1) If there is an error, rebinding the
values in order to resend the query is simple. They're already in the
proper order for numerical binding, so use a loop and rebind them
numerically. 2) For logging its a little more complicated. The
original query string has to be scanned multiple times to find/replace
each of the binding names with the correct value before the entire
query can be printed to the log.


  Commit: 21efa6e706310c2da674fc5d9c7489cdb1fe68d7
      https://github.com/MythTV/mythtv/commit/21efa6e706310c2da674fc5d9c7489cdb1fe68d7
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-02 (Fri, 02 Apr 2021)

  Changed paths:
    M mythplugins/mythgame/mythgame/gameui.cpp
    M mythtv/programs/mythfrontend/editvideometadata.cpp
    M mythtv/programs/mythfrontend/scheduleeditor.cpp
    M mythtv/programs/mythmetadatalookup/lookup.cpp

  Log Message:
  -----------
  qt6: Finish the DownloadMap/ArtworkMap QMap/QMultimap split.

In Qt6, the QMultiMap class is no longer based on the QMap class, so
you can no longer use the two almost interchangeably. Finish changing
variable declarations to the correct type, and in one case it is
necessary to copy the data from a QMap into a new QMultiMap.

Add to e912648ee8 LOCAL: Hack the DownloadMap/ArtworkMap problem so compiles finish.


  Commit: f07b903676a18be9ff906861add3ae354c02fa3f
      https://github.com/MythTV/mythtv/commit/f07b903676a18be9ff906861add3ae354c02fa3f
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-04-02 (Fri, 02 Apr 2021)

  Changed paths:
    M mythtv/programs/mythfrontend/videodlg.cpp

  Log Message:
  -----------
  qt6: In the video dialog, validate a QVariant before converting.

When MythTV is build on Qt6, it crashes any time the code references
an "up" node in the videos tree. Qt5 based MythTV handles this without
crashing. The QVariant code appears to have been significantly
rewritten in Qt6 which may explain the difference.


Compare: https://github.com/MythTV/mythtv/compare/cdcbb4c7f920...f07b903676a1