[mythtv-commits] [MythTV/mythtv] 916349: MythGesture: Rework button handling

Mark Kendall noreply at github.com
Wed Sep 23 14:32:22 UTC 2020

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 9163491016897d1912f5601f0e8a842e3afb509c
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-09-23 (Wed, 23 Sep 2020)

  Changed paths:
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythui/mythdialogbox.cpp
    M mythtv/libs/libmythui/mythgesture.cpp
    M mythtv/libs/libmythui/mythgesture.h
    M mythtv/libs/libmythui/mythmainwindow.cpp
    M mythtv/libs/libmythui/mythscreentype.cpp
    M mythtv/libs/libmythui/mythuitextedit.cpp

  Log Message:
  MythGesture: Rework button handling

- use the Qt::MouseButton enum instead of our own - which gives us
default access to all Qt defined button types
- pass the button into MythGesture. This allows us to have knowledge of
the button type without the need for a mouse release event - which we do
not get for gestures that time out

  Commit: 2a4575707363e3fe1587d22421b1a0833f71e342
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-09-23 (Wed, 23 Sep 2020)

  Changed paths:
    M mythtv/programs/mythfrontend/keybindings.cpp
    M mythtv/programs/mythfrontend/keybindings.h
    M mythtv/programs/mythfrontend/mythcontrols.cpp
    M mythtv/programs/mythfrontend/mythcontrols.h

  Log Message:
  KeyBindings/MythControls: Add ability to filter out 'modifier' contexts

- this does not yet change any behaviour (as I haven't figured out to
change the UI without compatibility issues).
- the underlying issue here is that 'Long press' key overrides are not a
key binding as such - but a modification to key behaviour - which can
then be bound to.
- as such they do not really belong the in the keybindings UI - not
least because if a long press is setup, the user must exit the
keybindings page to save it before it can be used as a binding; which is
not user friendly

Refs #221

Compare: https://github.com/MythTV/mythtv/compare/8d0aa1a1e1e4...2a4575707363

More information about the mythtv-commits mailing list