[mythtv-commits] [MythTV/mythtv] 6f1c2f: coverity: Fix several "big parameter pass by value...

David Hampton noreply at github.com
Thu Sep 3 05:10:44 UTC 2020


  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 6f1c2fc61b3c9f8c8579c6c2756c0b420b3aa0ac
      https://github.com/MythTV/mythtv/commit/6f1c2fc61b3c9f8c8579c6c2756c0b420b3aa0ac
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-03 (Thu, 03 Sep 2020)

  Changed paths:
    M mythtv/libs/libmythtv/captions/cc708decoder.cpp
    M mythtv/libs/libmythtv/visualisations/goom/goom_core.cpp
    M mythtv/libs/libmythtv/visualisations/goom/goom_core.h
    M mythtv/libs/libmythtv/visualisations/goom/lines.cpp
    M mythtv/libs/libmythtv/visualisations/goom/lines.h
    M mythtv/libs/libmythtv/visualisations/goom/tentacle3d.cpp
    M mythtv/libs/libmythtv/visualisations/goom/tentacle3d.h
    M mythtv/libs/libmythtv/visualisations/goom/zoom_filter_xmmx.cpp
    M mythtv/libs/libmythtv/visualisations/goom/zoom_filters.h

  Log Message:
  -----------
  coverity: Fix several "big parameter pass by value" warnings.


  Commit: c44aa1809ac8d7d1e5a70fa3c9202fefe9d02509
      https://github.com/MythTV/mythtv/commit/c44aa1809ac8d7d1e5a70fa3c9202fefe9d02509
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-03 (Thu, 03 Sep 2020)

  Changed paths:
    M mythtv/libs/libmythtv/visualisations/goom/goom_core.cpp
    M mythtv/libs/libmythtv/visualisations/goom/goom_core.h
    M mythtv/libs/libmythtv/visualisations/goom/ifs.cpp
    M mythtv/libs/libmythtv/visualisations/goom/tentacle3d.cpp

  Log Message:
  -----------
  coverity: Use a better random number generator for goom.


  Commit: eae6bdfbb6e071bb3bfc1188f7556c710368ce50
      https://github.com/MythTV/mythtv/commit/eae6bdfbb6e071bb3bfc1188f7556c710368ce50
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-03 (Thu, 03 Sep 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythvideoout.h
    M mythtv/libs/libmythtv/mythvideooutgpu.h
    M mythtv/libs/libmythtv/vulkan/mythvideovulkan.h

  Log Message:
  -----------
  Fix some clang-tidy warnings.


  Commit: 156f364a68771fbe8a37f15faba94fc207d8901e
      https://github.com/MythTV/mythtv/commit/156f364a68771fbe8a37f15faba94fc207d8901e
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-03 (Thu, 03 Sep 2020)

  Changed paths:
    M mythtv/libs/libmythui/mythimage.cpp
    M mythtv/libs/libmythui/mythimage.h

  Log Message:
  -----------
  clazy: Use faster QColor constructor.


  Commit: 0eaee4a6993cac68ce6c8db7654f0e20534afa6e
      https://github.com/MythTV/mythtv/commit/0eaee4a6993cac68ce6c8db7654f0e20534afa6e
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-03 (Thu, 03 Sep 2020)

  Changed paths:
    M mythplugins/mytharchive/mytharchive/main.cpp
    M mythplugins/mytharchive/mytharchive/mythburn.cpp
    M mythplugins/mytharchive/mytharchive/thumbfinder.cpp
    M mythplugins/mytharchive/mytharchive/videoselector.cpp
    M mythplugins/mythgame/mythgame/gamehandler.cpp
    M mythplugins/mythgame/mythgame/gamescan.cpp
    M mythplugins/mythgame/mythgame/gameui.cpp
    M mythplugins/mythmusic/mythmusic/playlist.cpp
    M mythplugins/mythnetvision/mythnetvision/rsseditor.cpp
    M mythplugins/mythnews/mythnews/mythnews.cpp
    M mythplugins/mythweather/mythweather/weatherSetup.cpp
    M mythtv/libs/libmyth/audio/audiooutputalsa.cpp
    M mythtv/libs/libmyth/audio/audiooutputpulse.cpp
    M mythtv/libs/libmyth/backendselect.cpp
    M mythtv/libs/libmyth/mediamonitor-unix.cpp
    M mythtv/libs/libmyth/mythcontext.cpp
    M mythtv/libs/libmyth/netutils.cpp
    M mythtv/libs/libmyth/programinfo.cpp
    M mythtv/libs/libmythbase/hardwareprofile.cpp
    M mythtv/libs/libmythbase/mythcommandlineparser.cpp
    M mythtv/libs/libmythfreemheg/Bitmap.cpp
    M mythtv/libs/libmythmetadata/metadatacommon.cpp
    M mythtv/libs/libmythmetadata/metadatadownload.cpp
    M mythtv/libs/libmythmetadata/musicmetadata.cpp
    M mythtv/libs/libmythmetadata/videoscan.cpp
    M mythtv/libs/libmythprotoserver/requesthandler/fileserverhandler.cpp
    M mythtv/libs/libmythtv/captions/subtitlescreen.cpp
    M mythtv/libs/libmythtv/cardutil.cpp
    M mythtv/libs/libmythtv/channelscan/channelscan_sm.cpp
    M mythtv/libs/libmythtv/channelutil.cpp
    M mythtv/libs/libmythtv/mpeg/atsctables.cpp
    M mythtv/libs/libmythtv/mythccextractorplayer.cpp
    M mythtv/libs/libmythtv/mythplayer.cpp
    M mythtv/libs/libmythtv/playercontext.cpp
    M mythtv/libs/libmythtv/programdata.cpp
    M mythtv/libs/libmythtv/recorders/ExternalRecorder.cpp
    M mythtv/libs/libmythtv/recorders/ExternalSignalMonitor.cpp
    M mythtv/libs/libmythtv/recorders/ExternalStreamHandler.cpp
    M mythtv/libs/libmythtv/recorders/v4l2encstreamhandler.cpp
    M mythtv/libs/libmythtv/recordingprofile.cpp
    M mythtv/libs/libmythtv/recordingrule.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tv_rec.cpp
    M mythtv/libs/libmythtv/tvremoteutil.cpp
    M mythtv/libs/libmythtv/v4l2util.cpp
    M mythtv/libs/libmythtv/videosource.cpp
    M mythtv/libs/libmythui/mythuiwebbrowser.cpp
    M mythtv/libs/libmythui/xmlparsebase.cpp
    M mythtv/libs/libmythupnp/httprequest.cpp
    M mythtv/libs/libmythupnp/mbroadcastsocketdevice.h
    M mythtv/libs/libmythupnp/msocketdevice_unix.cpp
    M mythtv/libs/libmythupnp/servicehost.cpp
    M mythtv/programs/mythbackend/autoexpire.cpp
    M mythtv/programs/mythbackend/backendhousekeeper.cpp
    M mythtv/programs/mythbackend/httpstatus.cpp
    M mythtv/programs/mythbackend/mainserver.cpp
    M mythtv/programs/mythbackend/scheduler.cpp
    M mythtv/programs/mythbackend/upnpcdstv.cpp
    M mythtv/programs/mythcommflag/main.cpp
    M mythtv/programs/mythfilldatabase/filldata.cpp
    M mythtv/programs/mythfrontend/channelrecpriority.cpp
    M mythtv/programs/mythfrontend/guidegrid.cpp
    M mythtv/programs/mythfrontend/playbackbox.cpp
    M mythtv/programs/mythfrontend/prevreclist.cpp
    M mythtv/programs/mythfrontend/progfind.cpp
    M mythtv/programs/mythfrontend/proglist.cpp
    M mythtv/programs/mythfrontend/programrecpriority.cpp
    M mythtv/programs/mythfrontend/setupwizard_video.cpp
    M mythtv/programs/mythfrontend/statusbox.cpp
    M mythtv/programs/mythfrontend/themechooser.cpp
    M mythtv/programs/mythfrontend/viewscheduled.cpp
    M mythtv/programs/mythfrontend/viewschedulediff.cpp
    M mythtv/programs/mythlcdserver/lcdprocclient.cpp
    M mythtv/programs/mythtranscode/main.cpp

  Log Message:
  -----------
  clazy: Remove unused variables.


  Commit: ee291d3868ba0a7752a394de529e5e4bb78539a6
      https://github.com/MythTV/mythtv/commit/ee291d3868ba0a7752a394de529e5e4bb78539a6
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-03 (Thu, 03 Sep 2020)

  Changed paths:
    M mythplugins/mythweather/mythweather/weatherSetup.cpp
    M mythtv/libs/libmythbase/loggingserver.cpp
    M mythtv/libs/libmythtv/HLS/httplivestreambuffer.cpp
    M mythtv/libs/libmythtv/captions/textsubtitleparser.cpp
    M mythtv/libs/libmythtv/mythcommflagplayer.cpp
    M mythtv/libs/libmythtv/mythplayer.cpp
    M mythtv/libs/libmythtv/mythvideoout.h
    M mythtv/libs/libmythtv/recorders/firewiresignalmonitor.cpp
    M mythtv/libs/libmythtv/recorders/firewiresignalmonitor.h
    M mythtv/libs/libmythtv/recorders/linuxfirewiredevice.cpp
    M mythtv/libs/libmythtv/recorders/streamhandler.h
    M mythtv/programs/mythfrontend/guidegrid.cpp

  Log Message:
  -----------
  clazy: Convert QMap->QHash when key is a pointer.

QMap has the particularity of sorting it's keys, but sorting by memory
address makes no sense.  Use QHash instead, which provides faster
lookups.


  Commit: 0432f08e4c91fd3570d1ca4dae09e7e2f379a845
      https://github.com/MythTV/mythtv/commit/0432f08e4c91fd3570d1ca4dae09e7e2f379a845
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-03 (Thu, 03 Sep 2020)

  Changed paths:
    M mythtv/libs/libmythtv/decoders/mythv4l2m2mcontext.cpp
    M mythtv/libs/libmythui/mythdisplay.cpp
    M mythtv/libs/libmythui/opengl/mythrenderopengl.cpp

  Log Message:
  -----------
  clazy: Use faster qEnvironmentVariableIsEmpty function.


  Commit: 3b9653a84bacdb74830c8677c367366f1a0281c3
      https://github.com/MythTV/mythtv/commit/3b9653a84bacdb74830c8677c367366f1a0281c3
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-03 (Thu, 03 Sep 2020)

  Changed paths:
    M mythplugins/mythnews/mythnews/newssite.cpp

  Log Message:
  -----------
  clazy: Fix string compare to remove unneeded memory allocation.


  Commit: a740fb8693557d4792648d2463cd64bb80021a45
      https://github.com/MythTV/mythtv/commit/a740fb8693557d4792648d2463cd64bb80021a45
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-03 (Thu, 03 Sep 2020)

  Changed paths:
    M mythplugins/mythmusic/mythmusic/cddb.cpp
    M mythplugins/mythmusic/mythmusic/smartplaylist.cpp
    M mythtv/libs/libmythmetadata/lyricsdata.cpp
    M mythtv/libs/libmythtv/AirPlay/mythraopconnection.cpp
    M mythtv/libs/libmythtv/HLS/httplivestreambuffer.cpp
    M mythtv/libs/libmythtv/HLS/m3u.cpp
    M mythtv/libs/libmythtv/captions/cc608decoder.cpp
    M mythtv/libs/libmythtv/channelscan/inputselectorsetting.cpp
    M mythtv/libs/libmythtv/channelutil.cpp
    M mythtv/libs/libmythtv/diseqcsettings.cpp
    M mythtv/libs/libmythtv/dtvconfparser.cpp
    M mythtv/libs/libmythtv/eitfixup.cpp
    M mythtv/libs/libmythtv/mheg/mhi.cpp
    M mythtv/libs/libmythtv/mythsystemevent.cpp
    M mythtv/libs/libmythtv/playercontext.cpp
    M mythtv/libs/libmythtv/recorders/ExternalRecChannelFetcher.cpp
    M mythtv/libs/libmythtv/recorders/ExternalSignalMonitor.cpp
    M mythtv/libs/libmythtv/recorders/vboxutils.cpp
    M mythtv/libs/libmythtv/sourceutil.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tv_rec.cpp
    M mythtv/libs/libmythui/mythvirtualkeyboard.cpp
    M mythtv/libs/libmythupnp/ssdp.cpp
    M mythtv/programs/mythfilerecorder/mythfilerecorder.cpp
    M mythtv/programs/mythfilldatabase/channeldata.cpp
    M mythtv/programs/mythfilldatabase/xmltvparser.cpp
    M mythtv/programs/mythfrontend/networkcontrol.cpp
    M mythtv/programs/mythlcdserver/lcdprocclient.cpp

  Log Message:
  -----------
  clazy: Avoid temporary allocations by using QString references.

    Finds places where "QString::fooRef()" should be used instead of
    "QString::foo()", to avoid temporary heap allocations.

    #### Example

        str.mid(5).toInt(ok) // BAD

        str.midRef(5).toInt(ok) // GOOD

    Where "mid" can be any of: "mid", "left", "right".

    And "toInt()" can be any of: "compare", "contains", "count",
    "startsWith", "endsWith", "indexOf", "isEmpty", "isNull",
    "lastIndexOf", "length", "size", "to*", "trimmed"

All changes made by the clazy program.


  Commit: 3abfcee3714b252a62543595a443375e22cf9226
      https://github.com/MythTV/mythtv/commit/3abfcee3714b252a62543595a443375e22cf9226
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-03 (Thu, 03 Sep 2020)

  Changed paths:
    M mythtv/libs/libmythui/mythuihelper.cpp

  Log Message:
  -----------
  clazy: Use faster QFileInfo::exists(foo) instead of QFileInfo(foo).exists().


  Commit: fb6b44abe13819cd42f6b7a0ac38e9277b139ee3
      https://github.com/MythTV/mythtv/commit/fb6b44abe13819cd42f6b7a0ac38e9277b139ee3
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-03 (Thu, 03 Sep 2020)

  Changed paths:
    M mythplugins/mytharchive/mytharchive/mythburn.cpp
    M mythplugins/mythgame/mythgame/gamesettings.cpp
    M mythtv/libs/libmythtv/mpeg/mpegstreamdata.cpp
    M mythtv/libs/libmythtv/transporteditor.cpp
    M mythtv/libs/libmythui/platforms/mythdisplaymutter.cpp

  Log Message:
  -----------
  clazy: Use qAsConst() when using C++11 range-for loops.

This prevents any potential detaching of the container.


  Commit: 2c12acd2481abe0b0e41449742bcc88a3419a884
      https://github.com/MythTV/mythtv/commit/2c12acd2481abe0b0e41449742bcc88a3419a884
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-03 (Thu, 03 Sep 2020)

  Changed paths:
    M mythtv/programs/mythfrontend/playbackbox.cpp

  Log Message:
  -----------
  clazy: Avoid creating temporary container when searching for a list value.

Use std::find instead to search a list for a value.


  Commit: 603d6eabd13b033d3a0ed6b0745b5c6d942086fd
      https://github.com/MythTV/mythtv/commit/603d6eabd13b033d3a0ed6b0745b5c6d942086fd
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-03 (Thu, 03 Sep 2020)

  Changed paths:
    M mythtv/programs/mythbackend/backendhousekeeper.cpp

  Log Message:
  -----------
  clazy: Add const qualification to range-for loop of std::array.


  Commit: d12b18907df7f1ce17199c8063664b8b73c30af9
      https://github.com/MythTV/mythtv/commit/d12b18907df7f1ce17199c8063664b8b73c30af9
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-03 (Thu, 03 Sep 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythvideobounds.h

  Log Message:
  -----------
  clazy: Fix "getter mismarked as a slot" warning.


Compare: https://github.com/MythTV/mythtv/compare/b523c1bca2a7...d12b18907df7


More information about the mythtv-commits mailing list