[mythtv-commits] [MythTV/mythtv] 2c1505: cppcheck: Fix SceneChangeDetector warnings related...

[David Hampton]

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 2c150509da4427c3a9f69cdeb6f605b5322a4347
      https://github.com/MythTV/mythtv/commit/2c150509da4427c3a9f69cdeb6f605b5322a4347
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-28 (Wed, 28 Oct 2020)

  Changed paths:
    M mythtv/programs/mythcommflag/SceneChangeDetector.cpp
    M mythtv/programs/mythcommflag/SceneChangeDetector.h

  Log Message:
  -----------
  cppcheck: Fix SceneChangeDetector warnings related to member variables.

Convert a couple of variables to standard arrays. Also add a couple of
"short" -> "int16_t" conversions.


  Commit: 9abeb1a96693a6ff59f5801b8098c05a107945f5
      https://github.com/MythTV/mythtv/commit/9abeb1a96693a6ff59f5801b8098c05a107945f5
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-28 (Wed, 28 Oct 2020)

  Changed paths:
    M .clang-tidy

  Log Message:
  -----------
  tidy: Ignore new function complexity test.


  Commit: bd06a83b97eb20131db20b94ac6d975b38a1ddc4
      https://github.com/MythTV/mythtv/commit/bd06a83b97eb20131db20b94ac6d975b38a1ddc4
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-28 (Wed, 28 Oct 2020)

  Changed paths:
    M mythplugins/mythmusic/mythmusic/playlistcontainer.h

  Log Message:
  -----------
  cppcheck: Eliminate PlaylistContainer warnings by making object uncopyable.


  Commit: f3551df80ad5cbd0250d98237532b624498c7663
      https://github.com/MythTV/mythtv/commit/f3551df80ad5cbd0250d98237532b624498c7663
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-28 (Wed, 28 Oct 2020)

  Changed paths:
    M mythtv/libs/libmyth/audio/audiooutputsettings.cpp
    M mythtv/libs/libmyth/audio/audiooutputsettings.h
    M mythtv/libs/libmyth/audio/eldutils.cpp
    M mythtv/libs/libmyth/audio/eldutils.h

  Log Message:
  -----------
  cppcheck: Fix "class MPUBLIC ELD is not handled" warnings.

Renaming the class from "ELD" to "eld" eliminates this warning.


  Commit: 23b16e97058ab4d84d7619234debbe7eb8aadcda
      https://github.com/MythTV/mythtv/commit/23b16e97058ab4d84d7619234debbe7eb8aadcda
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-28 (Wed, 28 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/videoout_d3d.cpp

  Log Message:
  -----------
  cppcheck: Remove unused variable.


  Commit: 4f06e11db1d537398ec7e6a32ef0d7022d9a5b6b
      https://github.com/MythTV/mythtv/commit/4f06e11db1d537398ec7e6a32ef0d7022d9a5b6b
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-28 (Wed, 28 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythpreviewplayer.cpp

  Log Message:
  -----------
  cppcheck: Fix "condition always false" warning in mythpreviewplayer.cpp.


  Commit: d2c17568a997d38451cbc5af0e745a208987dd57
      https://github.com/MythTV/mythtv/commit/d2c17568a997d38451cbc5af0e745a208987dd57
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-28 (Wed, 28 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/visualisations/goom/drawmethods.h

  Log Message:
  -----------
  cppcheck: ifdef out unused code in goom.


  Commit: 0880e73c8ad7a283d43cf253255c85a134adf5e4
      https://github.com/MythTV/mythtv/commit/0880e73c8ad7a283d43cf253255c85a134adf5e4
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-28 (Wed, 28 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/visualisations/goom/filters.cpp

  Log Message:
  -----------
  cppcheck: Fix duplicate case warning in goom filters.

The two "if" clauses do different things.  Remove the first closing
brace and the second if test.


  Commit: 9aed57a3d1684d15c489265b49a75e6b4218160f
      https://github.com/MythTV/mythtv/commit/9aed57a3d1684d15c489265b49a75e6b4218160f
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-28 (Wed, 28 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/visualisations/goom/goom_core.cpp

  Log Message:
  -----------
  cppcheck: Fix duplicate case warning in goom core.

The second "if" clauses overrides the values set in the first clause.
Remove the first clause.


  Commit: cec28bfbd2148a33514c42794320008d8c27b02f
      https://github.com/MythTV/mythtv/commit/cec28bfbd2148a33514c42794320008d8c27b02f
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-28 (Wed, 28 Oct 2020)

  Changed paths:
    M mythplugins/mythmusic/mythmusic/smartplaylist.h

  Log Message:
  -----------
  Fix crash in smart playlist editor.

This was caused when converting to C++11 initialization, and an empty
list got converted to a list containing a single nullptr.


  Commit: 675c4627cfc7c7de325964cbf3a8a54e6efd2969
      https://github.com/MythTV/mythtv/commit/675c4627cfc7c7de325964cbf3a8a54e6efd2969
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-28 (Wed, 28 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythplayercaptionsui.cpp

  Log Message:
  -----------
  Fix compile errors on android.


Compare: https://github.com/MythTV/mythtv/compare/c68c3c8760c2...675c4627cfc7