[mythtv-commits] [MythTV/mythtv] a7d516: Fix incorrect artwork urls returned from ttvdb gra...

rcrdnalor noreply at github.com
Sun Oct 11 10:34:57 UTC 2020


  Branch: refs/heads/fixes/31
  Home:   https://github.com/MythTV/mythtv
  Commit: a7d51639918e7fd1fc0b896248817ac7db732bcf
      https://github.com/MythTV/mythtv/commit/a7d51639918e7fd1fc0b896248817ac7db732bcf
  Author: Paul Gardiner <mythtv at glidos.net>
  Date:   2020-10-11 (Sun, 11 Oct 2020)

  Changed paths:
    M mythtv/bindings/python/MythTV/ttvdb/XSLT/tvdbQuery.xsl

  Log Message:
  -----------
  Fix incorrect artwork urls returned from ttvdb grabber

When performing a manual search for metadata for a video, the artwork
fetch was failing: no thumbnail was shown and no artwork was being
associated with the video. Ticket 13518 mentioned strange urls containing
"banners/_cache//banners". This commit fixes the bad urls and seems to
restore the downloading of the artwork. I don't know what led to the need
for this.

(cherry picked from commit 08c7045c2f123a60b6d5d913daef7753cd53649d)


  Commit: 76edb08de77d76d2e7baf1ea1fa7072032b6dc4c
      https://github.com/MythTV/mythtv/commit/76edb08de77d76d2e7baf1ea1fa7072032b6dc4c
  Author: Bas Hulsken <bhulsken at hotmail.com>
  Date:   2020-10-11 (Sun, 11 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythmetadata/metadatagrabber.cpp
    M mythtv/programs/scripts/metadata/Movie/tmdb3.py

  Log Message:
  -----------
  extend metadatagrabber timeout to 3 minutes

(cherry picked from commit e17de9cd618838e14081322051b199e278100c2b)


  Commit: 47a45b1e2e972ba2a5f0a464fef9a968e98138c4
      https://github.com/MythTV/mythtv/commit/47a45b1e2e972ba2a5f0a464fef9a968e98138c4
  Author: Roland Ernst <rcrernst at gmail.com>
  Date:   2020-10-11 (Sun, 11 Oct 2020)

  Changed paths:
    M mythtv/programs/mythfrontend/videodlg.cpp
    M mythtv/programs/mythfrontend/videodlg.h

  Log Message:
  -----------
  Revert commit 2738b98, but add robustness

Commit 2738b98 removed the functionality to download fanart and coverart
upon a manual search for metadata.
The reason was that it produces an endless loop inside the `Videodialog`
selection of the correct item.

I re-add this feature with more logging and - hopefully - adding
robustness.
We can now distinguish between a failure of the returned lookup data
and a hiccup in the implementation of the 'ReferenceCounter' classes.

(cherry picked from commit bbd25ebc0cbee76ad6f45604b8b023aa19b316ed)


  Commit: 6ad0b90949c956048aa8daccfb3da49b45f62e7e
      https://github.com/MythTV/mythtv/commit/6ad0b90949c956048aa8daccfb3da49b45f62e7e
  Author: Roland Ernst <rcrernst at gmail.com>
  Date:   2020-10-11 (Sun, 11 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythmetadata/metadatadownload.cpp

  Log Message:
  -----------
  Fix running a metadata grabber twice in manual mode

Commit e81c7fd added accuracy of retrieving metadata in automatic mode,
but leads to some inefficiency in the use of manual mode:

If the search for an exact match was not successful, the other grabber
is called twice and appends its result twice.

This commit combines the intention of commit 2f9424c for non-automatic
mode and the commit for automatic mode (2738b98).

(cherry picked from commit 6f85a40f370bf8e9b88b6ab0b98f6f8bebee4d8f)


  Commit: 4ab0425bd5e774978f170d3c76f9855072b09307
      https://github.com/MythTV/mythtv/commit/4ab0425bd5e774978f170d3c76f9855072b09307
  Author: Roland Ernst <rcrernst at gmail.com>
  Date:   2020-10-11 (Sun, 11 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythmetadata/metadatadownload.cpp

  Log Message:
  -----------
  Automated metadata lookup: Return if no match found

When performing a lookup in automatic mode, do not present a list
of all similar matches. Instead, terminate that lookup with a
failure notification only.

If a metadata lookup is done on a fresh and large video library,
the amount of popped up selection lists might get very big, and one
loses the context to what filename the selection list is meant for.

(cherry picked from commit c9ada72c7384fe1651b37d41d337c1af0459c780)


  Commit: f450e74550936e719134cf817d1fb7dc4e3e259e
      https://github.com/MythTV/mythtv/commit/f450e74550936e719134cf817d1fb7dc4e3e259e
  Author: Roland Ernst <rcrernst at gmail.com>
  Date:   2020-10-11 (Sun, 11 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythmetadata/metadatadownload.cpp

  Log Message:
  -----------
  Automated metadata lookup: Pass through automatic flag

If a new metadata lookup is spun off during lookup, pass through
the 'automatic' flag if we are in automatic mode.

(cherry picked from commit 87aac2f356444a80bb8d8f17e5b27e2f16ff1566)


  Commit: 30017d33d692a8aa5823d317ce741dbf092fd8cd
      https://github.com/MythTV/mythtv/commit/30017d33d692a8aa5823d317ce741dbf092fd8cd
  Author: Roland Ernst <rcrernst at gmail.com>
  Date:   2020-10-11 (Sun, 11 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythmetadata/metadatadownload.cpp

  Log Message:
  -----------
  Metadata Lookup: Handle 'mxml' and 'nfo' files only once

Videos in the video storage group may have an associated file
describing the metadata (ending with '.mxml' or '.nfo').
See https://www.mythtv.org/wiki/MythTV_Universal_Metadata_Format

We should read that file only once, otherwise a lookup reports
a single match twice.

(cherry picked from commit 3f73316eb86fb018659f5607b6ad3604f0d03d1d)


  Commit: 5a366872567c6c29390f8847cfaec6f7e027ae5b
      https://github.com/MythTV/mythtv/commit/5a366872567c6c29390f8847cfaec6f7e027ae5b
  Author: Roland Ernst <rcrernst at gmail.com>
  Date:   2020-10-11 (Sun, 11 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythmetadata/metadatadownload.cpp

  Log Message:
  -----------
  Metadata Lookup: Add an experimental feature in automatic mode

In case that no exact matches have been found during automatic lookup,
return the head of the list proposed by the grabber.

This helps a lot, if a tv-series name is given by the file names
in English, but the lookup was done in a different language.

Anyway, it unconditionally sets the first presented item, even the
match was not exactly found by MythTV.

One needs to set the environment variable "EXPERIMENTAL_METADATA_GRAB"
prior to the execution of mythfrontend or mythmetadatalookup.

(cherry picked from commit 75cf2569817437f5282776193d4ef11f8261fa2a)


  Commit: d285bdd9948655f98914ea47f61efa290bb86e85
      https://github.com/MythTV/mythtv/commit/d285bdd9948655f98914ea47f61efa290bb86e85
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-11 (Sun, 11 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythmetadata/metadatadownload.cpp

  Log Message:
  -----------
  MetadataDownload: Fix clang-tidy warning - else after continue

(cherry picked from commit d78f56e083f44224509bae53ffcdfbd21cca446a)


  Commit: 577dd50df1cf6c6629eb708ee3a88a724bdbedff
      https://github.com/MythTV/mythtv/commit/577dd50df1cf6c6629eb708ee3a88a724bdbedff
  Author: Roland Ernst <rcrernst at gmail.com>
  Date:   2020-10-11 (Sun, 11 Oct 2020)

  Changed paths:
    M mythtv/bindings/python/MythTV/system.py

  Log Message:
  -----------
  Python Bindings: Allow searching for collections

The ttvdb.py script does not return a valid xml when searching
for an ID without season or episode, like
'ttvdb.py -D 282022'.
Provide means to search for a collection, which is proven to work:
'ttvdb.py -C 282022'.

(cherry picked from commit 708b35de5410b03c147c7af0822ae5a05897a9d7)


Compare: https://github.com/MythTV/mythtv/compare/070623c6c65f...577dd50df1cf


More information about the mythtv-commits mailing list