[mythtv-commits] [MythTV/mythtv] d766fc: TV: Simplify signalling embedding

Mark Kendall noreply at github.com
Sat Oct 10 13:19:52 UTC 2020


  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: d766fca938e591541d8b59e82e9868b3fab64033
      https://github.com/MythTV/mythtv/commit/d766fca938e591541d8b59e82e9868b3fab64033
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-09 (Fri, 09 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythplayerinterface.cpp
    M mythtv/libs/libmythtv/mythplayerinterface.h
    M mythtv/libs/libmythtv/mythplayervisualiser.cpp
    M mythtv/libs/libmythtv/mythplayervisualiser.h
    M mythtv/libs/libmythtv/mythvideobounds.cpp
    M mythtv/libs/libmythtv/mythvideobounds.h
    M mythtv/libs/libmythtv/mythvideoout.cpp
    M mythtv/libs/libmythtv/mythvideooutgpu.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tv_play.h
    M mythtv/programs/mythfrontend/guidegrid.cpp
    M mythtv/programs/mythfrontend/playbackbox.cpp
    M mythtv/programs/mythfrontend/progfind.cpp
    M mythtv/programs/mythfrontend/scheduleeditor.cpp
    M mythtv/programs/mythfrontend/viewscheduled.cpp

  Log Message:
  -----------
  TV: Simplify signalling embedding

- part 1 - further changes to come


  Commit: 3d23310bfffb5ecc6a8d036e8b001094eb6e46f3
      https://github.com/MythTV/mythtv/commit/3d23310bfffb5ecc6a8d036e8b001094eb6e46f3
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-09 (Fri, 09 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/DetectLetterbox.cpp
    M mythtv/libs/libmythtv/DetectLetterbox.h

  Log Message:
  -----------
  DetectLetterbox: Fix includes


  Commit: 8026a2d3b2bd4d15b9d8605a53067a15bb420d94
      https://github.com/MythTV/mythtv/commit/8026a2d3b2bd4d15b9d8605a53067a15bb420d94
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-09 (Fri, 09 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/DetectLetterbox.cpp
    M mythtv/libs/libmythtv/DetectLetterbox.h

  Log Message:
  -----------
  DetectLetterbox: Cleanup constructor


  Commit: 3829659cbf04f74e955ed22a62e1f3ac8c42e33b
      https://github.com/MythTV/mythtv/commit/3829659cbf04f74e955ed22a62e1f3ac8c42e33b
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-09 (Fri, 09 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/audioplayer.cpp
    M mythtv/libs/libmythtv/audioplayer.h
    M mythtv/libs/libmythtv/mythplayer.h
    M mythtv/libs/libmythtv/mythplayerinterface.h

  Log Message:
  -----------
  MythPlayer: Move interface headers into MythPlayerInterface

- where they are actually needed
- exposed a small header issue in AudioPlayer


  Commit: ff9da5ae754dcd91468929bfb63400aa1b38c420
      https://github.com/MythTV/mythtv/commit/ff9da5ae754dcd91468929bfb63400aa1b38c420
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-10 (Sat, 10 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythvideooutnull.cpp

  Log Message:
  -----------
  MythVideoOutputNull: Use auto


  Commit: 3510e85be91e569b962c3fd971b9f1cd9d8103f5
      https://github.com/MythTV/mythtv/commit/3510e85be91e569b962c3fd971b9f1cd9d8103f5
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-10 (Sat, 10 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/previewgenerator.cpp

  Log Message:
  -----------
  PreviewGenerator: Use auto


  Commit: 454649526dd73944d4d1e15adee1addd2cb92eb0
      https://github.com/MythTV/mythtv/commit/454649526dd73944d4d1e15adee1addd2cb92eb0
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-10 (Sat, 10 Oct 2020)

  Changed paths:
    M mythtv/programs/mythfrontend/proglist.cpp

  Log Message:
  -----------
  ProgLister: Check for nullptr


  Commit: 9a282810ff719511a38d799a64a7488984ce567e
      https://github.com/MythTV/mythtv/commit/9a282810ff719511a38d799a64a7488984ce567e
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-10 (Sat, 10 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/libmythtv.pro
    M mythtv/libs/libmythtv/mythplayer.h
    M mythtv/libs/libmythtv/mythplayeraudiointerface.cpp
    M mythtv/libs/libmythtv/mythplayeraudiointerface.h
    M mythtv/libs/libmythtv/mythplayerinterface.cpp
    M mythtv/libs/libmythtv/mythplayerinterface.h
    A mythtv/libs/libmythtv/mythplayeruibase.cpp
    A mythtv/libs/libmythtv/mythplayeruibase.h
    M mythtv/libs/libmythtv/mythplayervisualiser.cpp
    M mythtv/libs/libmythtv/mythplayervisualiser.h

  Log Message:
  -----------
  MythPlayerInterface: Restructure inheritance

- this is how I should have implemented it in the first place...

- add a MythPlayerUIBase class that inherits from MythPlayer and adds
the main UI related objects that we need elsewhere
- use a simple A->B->C inheritance structure for incorporating all of
the interface subclasses into MythPlayerInterface

This ensures:-

- the full interface is still visible to the parent TV object
- all base class members are visible in the derived classes
- hence avoids duplication of member variables
- critically - each class in the inheritance line can be a QObject


  Commit: 6fcd24e3d8fd6677188f92383d60ea087f4e33d9
      https://github.com/MythTV/mythtv/commit/6fcd24e3d8fd6677188f92383d60ea087f4e33d9
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-10 (Sat, 10 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/Bluray/mythbdplayer.cpp
    M mythtv/libs/libmythtv/Bluray/mythbdplayer.h
    M mythtv/libs/libmythtv/DVD/mythdvdplayer.cpp
    M mythtv/libs/libmythtv/DVD/mythdvdplayer.h
    M mythtv/libs/libmythtv/libmythtv.pro
    R mythtv/libs/libmythtv/mythplayeraudiointerface.cpp
    R mythtv/libs/libmythtv/mythplayeraudiointerface.h
    A mythtv/libs/libmythtv/mythplayeraudioui.cpp
    A mythtv/libs/libmythtv/mythplayeraudioui.h
    R mythtv/libs/libmythtv/mythplayerinterface.cpp
    R mythtv/libs/libmythtv/mythplayerinterface.h
    A mythtv/libs/libmythtv/mythplayerui.cpp
    A mythtv/libs/libmythtv/mythplayerui.h
    R mythtv/libs/libmythtv/mythplayervisualiser.cpp
    R mythtv/libs/libmythtv/mythplayervisualiser.h
    A mythtv/libs/libmythtv/mythplayervisualiserui.cpp
    A mythtv/libs/libmythtv/mythplayervisualiserui.h
    M mythtv/libs/libmythtv/mythvideoscantracker.cpp
    M mythtv/libs/libmythtv/mythvideoscantracker.h
    M mythtv/libs/libmythtv/osd.cpp
    M mythtv/libs/libmythtv/osd.h
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tv_play.h

  Log Message:
  -----------
  MythPlayerInterface: Renamve to MythPlayerUI

- interface was becoming too much of a mouthfull with subclasses:)


  Commit: 68e85b95df275c99c2f1c816d9477de2c8d333f0
      https://github.com/MythTV/mythtv/commit/68e85b95df275c99c2f1c816d9477de2c8d333f0
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-10 (Sat, 10 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythui/mythmainwindow.cpp
    M mythtv/libs/libmythui/mythmainwindow.h
    M mythtv/libs/libmythui/mythuiscreenbounds.h

  Log Message:
  -----------
  MythMainWindow: Move QWidget inheritance into MythUIScreenBounds

- which allows MythUIScreenBounds to use QObject functionality


Compare: https://github.com/MythTV/mythtv/compare/eec7572c2ecf...68e85b95df27


More information about the mythtv-commits mailing list