[mythtv-commits] [MythTV/mythtv] bbd25e: Revert commit 2738b98, but add robustness

[rcrdnalor]

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: bbd25ebc0cbee76ad6f45604b8b023aa19b316ed
      https://github.com/MythTV/mythtv/commit/bbd25ebc0cbee76ad6f45604b8b023aa19b316ed
  Author: Roland Ernst <rcrernst at gmail.com>
  Date:   2020-10-01 (Thu, 01 Oct 2020)

  Changed paths:
    M mythtv/programs/mythfrontend/videodlg.cpp
    M mythtv/programs/mythfrontend/videodlg.h

  Log Message:
  -----------
  Revert commit 2738b98, but add robustness

Commit 2738b98 removed the functionality to download fanart and coverart
upon a manual search for metadata.
The reason was that it produces an endless loop inside the `Videodialog`
selection of the correct item.

I re-add this feature with more logging and - hopefully - adding
robustness.
We can now distinguish between a failure of the returned lookup data
and a hiccup in the implementation of the 'ReferenceCounter' classes.


  Commit: 6f85a40f370bf8e9b88b6ab0b98f6f8bebee4d8f
      https://github.com/MythTV/mythtv/commit/6f85a40f370bf8e9b88b6ab0b98f6f8bebee4d8f
  Author: Roland Ernst <rcrernst at gmail.com>
  Date:   2020-10-01 (Thu, 01 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythmetadata/metadatadownload.cpp

  Log Message:
  -----------
  Fix running a metadata grabber twice in manual mode

Commit e81c7fd added accuracy of retrieving metadata in automatic mode,
but leads to some inefficiency in the use of manual mode:

If the search for an exact match was not successful, the other grabber
is called twice and appends its result twice.

This commit combines the intention of commit 2f9424c for non-automatic
mode and the commit for automatic mode (2738b98).


  Commit: c9ada72c7384fe1651b37d41d337c1af0459c780
      https://github.com/MythTV/mythtv/commit/c9ada72c7384fe1651b37d41d337c1af0459c780
  Author: Roland Ernst <rcrernst at gmail.com>
  Date:   2020-10-06 (Tue, 06 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythmetadata/metadatadownload.cpp

  Log Message:
  -----------
  Automated metadata lookup: Return if no match found

When performing a lookup in automatic mode, do not present a list
of all similar matches. Instead, terminate that lookup with a
failure notification only.

If a metadata lookup is done on a fresh and large video library,
the amount of popped up selection lists might get very big, and one
loses the context to what filename the selection list is meant for.


  Commit: 87aac2f356444a80bb8d8f17e5b27e2f16ff1566
      https://github.com/MythTV/mythtv/commit/87aac2f356444a80bb8d8f17e5b27e2f16ff1566
  Author: Roland Ernst <rcrernst at gmail.com>
  Date:   2020-10-06 (Tue, 06 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythmetadata/metadatadownload.cpp

  Log Message:
  -----------
  Automated metadata lookup: Pass through automatic flag

If a new metadata lookup is spun off during lookup, pass through
the 'automatic' flag if we are in automatic mode.


  Commit: 3f73316eb86fb018659f5607b6ad3604f0d03d1d
      https://github.com/MythTV/mythtv/commit/3f73316eb86fb018659f5607b6ad3604f0d03d1d
  Author: Roland Ernst <rcrernst at gmail.com>
  Date:   2020-10-06 (Tue, 06 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythmetadata/metadatadownload.cpp

  Log Message:
  -----------
  Metadata Lookup: Handle 'mxml' and 'nfo' files only once

Videos in the video storage group may have an associated file
describing the metadata (ending with '.mxml' or '.nfo').
See https://www.mythtv.org/wiki/MythTV_Universal_Metadata_Format

We should read that file only once, otherwise a lookup reports
a single match twice.


  Commit: 75cf2569817437f5282776193d4ef11f8261fa2a
      https://github.com/MythTV/mythtv/commit/75cf2569817437f5282776193d4ef11f8261fa2a
  Author: Roland Ernst <rcrernst at gmail.com>
  Date:   2020-10-06 (Tue, 06 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythmetadata/metadatadownload.cpp

  Log Message:
  -----------
  Metadata Lookup: Add an experimental feature in automatic mode

In case that no exact matches have been found during automatic lookup,
return the head of the list proposed by the grabber.

This helps a lot, if a tv-series name is given by the file names
in English, but the lookup was done in a different language.

Anyway, it unconditionally sets the first presented item, even the
match was not exactly found by MythTV.

One needs to set the environment variable "EXPERIMENTAL_METADATA_GRAB"
prior to the execution of mythfrontend or mythmetadatalookup.


  Commit: d3c5e984e55f8056c7e38dd308bb49bbe6835dd8
      https://github.com/MythTV/mythtv/commit/d3c5e984e55f8056c7e38dd308bb49bbe6835dd8
  Author: rcrdnalor <40721016+rcrdnalor at users.noreply.github.com>
  Date:   2020-10-06 (Tue, 06 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythmetadata/metadatadownload.cpp
    M mythtv/programs/mythfrontend/videodlg.cpp
    M mythtv/programs/mythfrontend/videodlg.h

  Log Message:
  -----------
  Merge pull request #249 from rcrdnalor/issue#248

Issue#248


Compare: https://github.com/MythTV/mythtv/compare/7cfaf8facd86...d3c5e984e55f