[mythtv-commits] [MythTV/mythtv] 336086: MythDisplay: Simplify ownership and access

[Mark Kendall]

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 336086778011770239e6e749916752e06f733b74
      https://github.com/MythTV/mythtv/commit/336086778011770239e6e749916752e06f733b74
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-03 (Sat, 03 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythplayer.cpp
    M mythtv/libs/libmythtv/mythvideobounds.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythui/devices/mythcecadapter.cpp
    M mythtv/libs/libmythui/devices/mythcecadapter.h
    M mythtv/libs/libmythui/devices/mythinputdevicehandler.cpp
    M mythtv/libs/libmythui/mythdisplay.cpp
    M mythtv/libs/libmythui/mythdisplay.h
    M mythtv/libs/libmythui/mythmainwindow.cpp
    M mythtv/libs/libmythui/mythmainwindow.h
    M mythtv/libs/libmythui/mythscreensaver.cpp
    M mythtv/libs/libmythui/mythscreensaver.h
    M mythtv/libs/libmythui/mythuihelper.cpp
    M mythtv/libs/libmythui/mythuihelper.h
    M mythtv/libs/libmythui/mythuiscreenbounds.cpp
    M mythtv/libs/libmythui/mythuiscreenbounds.h
    M mythtv/libs/libmythui/platforms/mythscreensaverdrm.cpp
    M mythtv/libs/libmythui/platforms/mythscreensaverdrm.h
    M mythtv/programs/mythfrontend/globalsettings.cpp
    M mythtv/programs/mythfrontend/globalsettings.h
    M mythtv/programs/mythfrontend/statusbox.cpp

  Log Message:
  -----------
  MythDisplay: Simplify ownership and access

- move explicit ownership into MythMainWindow
- only MythMainWindow can create the display object
- don't reference count as it sits in the main thread, should only be
used from the main thread and no user should outlive the main window
- pass into other relevant constructors/methods, otherwise use
GetDisplay where not currently possible


  Commit: bd215bf40116f552c5a085cebfded80ad163b516
      https://github.com/MythTV/mythtv/commit/bd215bf40116f552c5a085cebfded80ad163b516
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-04 (Sun, 04 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythui/mythdisplay.cpp
    M mythtv/libs/libmythui/mythdisplay.h

  Log Message:
  -----------
  MythDisplay: Whitespace


  Commit: 43b20ab8ae37d58ebdec6a78b8c3d4d7b7d16ac1
      https://github.com/MythTV/mythtv/commit/43b20ab8ae37d58ebdec6a78b8c3d4d7b7d16ac1
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-04 (Sun, 04 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythui/libmythui.pro
    M mythtv/libs/libmythui/mythuihelper.cpp
    M mythtv/libs/libmythui/mythuihelper.h
    M mythtv/libs/libmythui/mythuithemecache.cpp
    M mythtv/libs/libmythui/mythuithemecache.h
    A mythtv/libs/libmythui/mythuithemehelper.cpp
    A mythtv/libs/libmythui/mythuithemehelper.h

  Log Message:
  -----------
  MythUIHelper: Move theme handling into MythUIThemeHelper class

- this just seperates out more standalone state from MythUIHelper
- new class is currently directly inherited by MythUIHelper - so again
the API should be unchanged


  Commit: 63b61ccc932e9698dbd895bb4217f87e202cd34c
      https://github.com/MythTV/mythtv/commit/63b61ccc932e9698dbd895bb4217f87e202cd34c
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-04 (Sun, 04 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythui/mythmainwindow.cpp
    M mythtv/libs/libmythui/mythmainwindow.h
    M mythtv/libs/libmythui/mythmainwindowprivate.h
    M mythtv/libs/libmythui/myththemebase.cpp
    M mythtv/libs/libmythui/myththemebase.h

  Log Message:
  -----------
  MythMainWindow: Move MythThemeBase object into MythMainWindow proper

- take the opportunity to pass MythMainWindow directly into
MythThemeBase constructor and avoid a somewhat circular reference


  Commit: 129647430f212a0d751000a3c248371eade826a4
      https://github.com/MythTV/mythtv/commit/129647430f212a0d751000a3c248371eade826a4
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-04 (Sun, 04 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythui/mythmainwindow.cpp

  Log Message:
  -----------
  MythMainWindow: Fix unused return value in IsTopScreenInitialized

- picked up by coverity scan


  Commit: b1ace0458aa5effc9399c6ea5871cbcd88ab3dc6
      https://github.com/MythTV/mythtv/commit/b1ace0458aa5effc9399c6ea5871cbcd88ab3dc6
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-04 (Sun, 04 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythui/mythuithemecache.cpp

  Log Message:
  -----------
  MythUIThemeCache: Minor refactor


  Commit: dca9a60a7c6d640b7804f231eb8fb4d53ab97242
      https://github.com/MythTV/mythtv/commit/dca9a60a7c6d640b7804f231eb8fb4d53ab97242
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-04 (Sun, 04 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/opengl/mythopenglvideo.cpp

  Log Message:
  -----------
  MythOpenGLVideo: Use std::transform

- and take the opportunity for a minor simplification/refactor


  Commit: b0a81dc2406ac1f3071afb94ade8855b5b10923b
      https://github.com/MythTV/mythtv/commit/b0a81dc2406ac1f3071afb94ade8855b5b10923b
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-04 (Sun, 04 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/opengl/mythnvdecinterop.cpp

  Log Message:
  -----------
  MythNVDECInterop: Use std::copy


  Commit: 258a82d0672403811fb6edf6a8ff965ff3c8526b
      https://github.com/MythTV/mythtv/commit/258a82d0672403811fb6edf6a8ff965ff3c8526b
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-04 (Sun, 04 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/decoders/mythnvdeccontext.cpp

  Log Message:
  -----------
  MythNVDECContext: Use std::any_of


  Commit: a6c9a77a3bb52de4bf2cfb48efe68bc542d1969c
      https://github.com/MythTV/mythtv/commit/a6c9a77a3bb52de4bf2cfb48efe68bc542d1969c
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-04 (Sun, 04 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythui/vulkan/mythpaintervulkan.cpp

  Log Message:
  -----------
  MythPainterVulkan: Use std::transform


  Commit: cd034a0ef621b7f5fe0bcf9fd5ab1917be4e395f
      https://github.com/MythTV/mythtv/commit/cd034a0ef621b7f5fe0bcf9fd5ab1917be4e395f
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-04 (Sun, 04 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythui/opengl/mythpainteropengl.cpp

  Log Message:
  -----------
  MythOpenGLPainter: Use std::generate


Compare: https://github.com/MythTV/mythtv/compare/d5ba9b477010...cd034a0ef621