[mythtv-commits] [MythTV/mythtv] 5d8081: MythUIHelper: Remove unused variable

Mark Kendall noreply at github.com
Fri Oct 2 11:57:42 UTC 2020 

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 5d80817b9a7ba8e57bce473c9983f3fa6dec0f0c
      https://github.com/MythTV/mythtv/commit/5d80817b9a7ba8e57bce473c9983f3fa6dec0f0c
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-01 (Thu, 01 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythui/mythuihelper.cpp

  Log Message:
  -----------
  MythUIHelper: Remove unused variable


  Commit: 2b0147c908a7554ec9216c4341dc42d2a1317408
      https://github.com/MythTV/mythtv/commit/2b0147c908a7554ec9216c4341dc42d2a1317408
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-01 (Thu, 01 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythui/libmythui.pro
    M mythtv/libs/libmythui/mythuihelper.cpp
    M mythtv/libs/libmythui/mythuihelper.h
    A mythtv/libs/libmythui/mythuithemecache.cpp
    A mythtv/libs/libmythui/mythuithemecache.h

  Log Message:
  -----------
  MythUIHelper: Move theme cache into separate class

- this is largely driven by the need to clarify the state within
MythUIHelper; which is somewhat confused by MythUIHelper's general role
and is hindering improvements to UI rendering
- new MythUIThemeCache class is inherited directly from MythUIHelper, so
there are no changes to the external interface and there should be no
changes to behaviour


  Commit: a3b906c904aa169fc02280e7ff72fd0fff29acc9
      https://github.com/MythTV/mythtv/commit/a3b906c904aa169fc02280e7ff72fd0fff29acc9
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-01 (Thu, 01 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythui/mythuihelper.cpp
    M mythtv/libs/libmythui/mythuithemecache.cpp
    M mythtv/libs/libmythui/mythuithemecache.h

  Log Message:
  -----------
  MythUIThemeCache: Use a QSize for screen size and rename


  Commit: 3349dd6ebe436e75e0005a40cb343b20502989bf
      https://github.com/MythTV/mythtv/commit/3349dd6ebe436e75e0005a40cb343b20502989bf
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-01 (Thu, 01 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythui/mythuihelper.cpp
    M mythtv/libs/libmythui/mythuihelper.h

  Log Message:
  -----------
  MythUIHelper: Remove private class


  Commit: 3a06e4d61faefc2ecfaa321a37372be19c24e200
      https://github.com/MythTV/mythtv/commit/3a06e4d61faefc2ecfaa321a37372be19c24e200
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-01 (Thu, 01 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythui/mythuihelper.cpp

  Log Message:
  -----------
  MythUIHelper: Simplify an unlikely log message


  Commit: c26259ac58914ba1d76e1a70e02782b2850890b7
      https://github.com/MythTV/mythtv/commit/c26259ac58914ba1d76e1a70e02782b2850890b7
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-01 (Thu, 01 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/osd.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythui/mythmainwindow.cpp
    M mythtv/libs/libmythui/mythuihelper.cpp
    M mythtv/libs/libmythui/mythuihelper.h
    M mythtv/libs/libmythui/mythuiimage.cpp
    M mythtv/libs/libmythui/mythvirtualkeyboard.cpp

  Log Message:
  -----------
  MythUIHelper: Simplify screen setting retrieval


  Commit: 0036b9fc0ce214bd00ad214b790cf6fa2d9ff017
      https://github.com/MythTV/mythtv/commit/0036b9fc0ce214bd00ad214b790cf6fa2d9ff017
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-01 (Thu, 01 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythui/mythmainwindow.cpp
    M mythtv/libs/libmythui/mythmainwindow.h

  Log Message:
  -----------
  MythMainWindow: Remove unused code


  Commit: ee24b7ffecc8e875c61ff0f2d5e886d92efccd91
      https://github.com/MythTV/mythtv/commit/ee24b7ffecc8e875c61ff0f2d5e886d92efccd91
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/Bluray/mythbddecoder.cpp
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp
    M mythtv/libs/libmythtv/decoders/avformatdecoder.h

  Log Message:
  -----------
  AvFormatDecoder: Fix shadowing of DecoderBase var


  Commit: 8a2b45b7233648f221fdaaf1ea472931031a91b5
      https://github.com/MythTV/mythtv/commit/8a2b45b7233648f221fdaaf1ea472931031a91b5
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythplayer.cpp
    M mythtv/libs/libmythtv/osd.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythui/libmythui.pro
    M mythtv/libs/libmythui/mythdisplay.cpp
    M mythtv/libs/libmythui/mythmainwindow.cpp
    M mythtv/libs/libmythui/mythmainwindow.h
    M mythtv/libs/libmythui/mythmainwindowprivate.h
    M mythtv/libs/libmythui/mythuiguidegrid.cpp
    M mythtv/libs/libmythui/mythuihelper.cpp
    M mythtv/libs/libmythui/mythuihelper.h
    M mythtv/libs/libmythui/mythuiimage.cpp
    A mythtv/libs/libmythui/mythuiscreenbounds.cpp
    A mythtv/libs/libmythui/mythuiscreenbounds.h
    M mythtv/libs/libmythui/mythuitext.cpp
    M mythtv/libs/libmythui/mythvirtualkeyboard.cpp
    M mythtv/programs/mythavtest/main.cpp
    M mythtv/programs/mythfrontend/main.cpp
    M mythtv/programs/mythtv-setup/main.cpp

  Log Message:
  -----------
  libmythui: Consolidate window sizing and settings

- new class MythUIScreenBounds contains state and functionality
previously held in MythMainWindow anbd MythUIHelper or, most
importantly, both.
- this avoids confusion over current state and exposes opportunities for
simplification
- MythUIScreenBounds is inherited directly by MythMainWindow - so for
many use cases the interface is unchanged
- there should not be (and I cannot see) and changes in behaviour -
though may expose inconsistencies managed with the previous code.


  Commit: c39df7bd487526eb2c848c599bc1528f9e561869
      https://github.com/MythTV/mythtv/commit/c39df7bd487526eb2c848c599bc1528f9e561869
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythui/mythmainwindow.cpp
    M mythtv/libs/libmythui/mythmainwindow.h
    M mythtv/libs/libmythui/mythmainwindowprivate.h

  Log Message:
  -----------
  MythMainWindow: Cleanup idle timer/timeout handling

- allocate timer on the stack
- modernise connect (for compile time checks)
- don't use QMetaObject::invokedMethod. This is just a workaround for
lazy threading. All functions setting/resetting idle timeouts run in the
main thread - so just call directly.
- minor simplification of logic following "CLEAR_SETTINGS_CACHE" action


  Commit: 4496883b8b66ead7ba2f24a34d1e9efde6df762c
      https://github.com/MythTV/mythtv/commit/4496883b8b66ead7ba2f24a34d1e9efde6df762c
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/opengl/mythmediacodecinterop.cpp

  Log Message:
  -----------
  MythMediaCodecInterop: Squash a cppcheck warning


  Commit: bfaf5692d39d2de250034ee6d92ff683131acba5
      https://github.com/MythTV/mythtv/commit/bfaf5692d39d2de250034ee6d92ff683131acba5
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/decoders/decoderbase.h

  Log Message:
  -----------
  DecoderBase: Prevent and copy and assignment


  Commit: 7ea165959b59ced4bf5c2b60a01999c3a9ac6732
      https://github.com/MythTV/mythtv/commit/7ea165959b59ced4bf5c2b60a01999c3a9ac6732
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythvideooutgpu.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythui/mythmainwindow.cpp
    M mythtv/libs/libmythui/mythmainwindow.h
    M mythtv/programs/mythfrontend/main.cpp

  Log Message:
  -----------
  MythMainWindow: Rename GetCurrentPainter method

- with a view to removing the static/convenience version as well - once
I've trawled through its use in the MythUIType's


  Commit: 0bbd8d14d67f2f71b8ae2aa67189fccf9e22031e
      https://github.com/MythTV/mythtv/commit/0bbd8d14d67f2f71b8ae2aa67189fccf9e22031e
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythui/mythuiscreenbounds.cpp

  Log Message:
  -----------
  MythUIScreenBounds: Remove circular/unneeded include


Compare: https://github.com/MythTV/mythtv/compare/2a40eb38d6dc...0bbd8d14d67f

More information about the mythtv-commits mailing list