[mythtv-commits] [MythTV/mythtv] db57d7: clazy: Use isEmpty() instead of !count() etc.

Mon Nov 16 05:01:13 UTC 2020

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: db57d7341274ed11a7fe16a31b2e4cd504336517
      https://github.com/MythTV/mythtv/commit/db57d7341274ed11a7fe16a31b2e4cd504336517
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-11-15 (Sun, 15 Nov 2020)

  Changed paths:
    M mythplugins/mythmusic/mythmusic/streamview.cpp
    M mythtv/libs/libmyth/backendselect.cpp
    M mythtv/libs/libmyth/mediamonitor-unix.cpp

  Log Message:
  -----------
  clazy: Use isEmpty() instead of !count() etc.

  Commit: d9a34567e1a3f07e0f841faa16052892c8dab488
      https://github.com/MythTV/mythtv/commit/d9a34567e1a3f07e0f841faa16052892c8dab488
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-11-15 (Sun, 15 Nov 2020)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/cetonrtsp.cpp
    M mythtv/libs/libmythui/mythuitype.cpp
    M mythtv/programs/mythbackend/mainserver.cpp

  Log Message:
  -----------
  clazy: Fix "container inside loop" warnings.

Finds places defining containers inside loops. Defining them outside
the loop and using resize(0) or clear() will save memory allocations.

  Commit: 6b66cc7041b83d1c73299edaa0e059980d8e1681
      https://github.com/MythTV/mythtv/commit/6b66cc7041b83d1c73299edaa0e059980d8e1681
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-11-15 (Sun, 15 Nov 2020)

  Changed paths:
    M mythplugins/mytharchive/mytharchive/fileselector.cpp
    M mythtv/libs/libmyth/mythcontext.cpp
    M mythtv/libs/libmythbase/logging.cpp
    M mythtv/libs/libmythbase/mythcorecontext.cpp
    M mythtv/libs/libmythbase/mythmiscutil.cpp
    M mythtv/libs/libmythbase/mythsystemunix.cpp
    M mythtv/libs/libmythbase/mythtimezone.cpp
    M mythtv/libs/libmythbase/storagegroup.cpp
    M mythtv/libs/libmythtv/decoders/mythnvdeccontext.cpp
    M mythtv/libs/libmythtv/decoders/mythvaapicontext.cpp
    M mythtv/libs/libmythtv/decoders/mythvdpaucontext.cpp
    M mythtv/libs/libmythtv/jobqueue.cpp
    M mythtv/libs/libmythtv/mheg/mhegic.cpp
    M mythtv/libs/libmythtv/mheg/netstream.cpp
    M mythtv/libs/libmythtv/mythplayer.cpp
    M mythtv/libs/libmythtv/opengl/mythvaapiinterop.cpp
    M mythtv/libs/libmythtv/recorders/mpegrecorder.cpp
    M mythtv/libs/libmythui/devices/lirc_client.cpp
    M mythtv/libs/libmythui/mythuifilebrowser.cpp
    M mythtv/libs/libmythui/mythuiimage.cpp
    M mythtv/libs/libmythupnp/httprequest.cpp
    M mythtv/programs/mythbackend/scheduler.cpp
    M mythtv/programs/mythbackend/services/myth.cpp
    M mythtv/programs/mythcommflag/ClassicCommDetector.cpp
    M mythtv/programs/mythfrontend/themechooser.cpp

  Log Message:
  -----------
  clazy: Fix "raw environment function" warnings.

Replace instances of getenv() with one of the qEnvironmentVariable()
family of functions.

  Commit: c61ee90cf721a894cf72aec0f1d5db41cd6f098d
      https://github.com/MythTV/mythtv/commit/c61ee90cf721a894cf72aec0f1d5db41cd6f098d
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-11-15 (Sun, 15 Nov 2020)

  Changed paths:
    M mythtv/libs/libmythtv/AirPlay/mythraopconnection.cpp
    M mythtv/libs/libmythui/mythmainwindow.cpp
    M mythtv/programs/mythfrontend/idlescreen.cpp
    M mythtv/programs/mythlcdserver/lcdprocclient.cpp
    M mythtv/programs/mythwelcome/welcomedialog.cpp

  Log Message:
  -----------
  clazy: Fix some "use chrono in qtimer" warnings.

>From the docs: Find places where a number is used with QTimer's start,
setElapsed or singleShot methods, and suggests to use chrono literals
instead.

This batch of changes are for constant values that are converted to
chrono. These changes made by hand.

  Commit: 4f39b916409fe77766a37a801776a857ed160753
      https://github.com/MythTV/mythtv/commit/4f39b916409fe77766a37a801776a857ed160753
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-11-15 (Sun, 15 Nov 2020)

  Changed paths:
    M mythplugins/mytharchive/mytharchive/logviewer.cpp
    M mythplugins/mytharchive/mytharchive/videoselector.cpp
    M mythplugins/mythmusic/mythmusic/avfdecoder.cpp
    M mythplugins/mythmusic/mythmusic/cdrip.cpp
    M mythplugins/mythmusic/mythmusic/miniplayer.cpp
    M mythplugins/mythmusic/mythmusic/streamview.cpp
    M mythplugins/mythzoneminder/mythzoneminder/zmconsole.cpp
    M mythplugins/mythzoneminder/mythzoneminder/zmminiplayer.cpp
    M mythplugins/mythzoneminder/mythzoneminder/zmplayer.cpp
    M mythtv/libs/libmyth/guistartup.cpp
    M mythtv/libs/libmythbase/housekeeper.cpp
    M mythtv/libs/libmythbase/lcddevice.cpp
    M mythtv/libs/libmythprotoserver/requesthandler/outboundhandler.cpp
    M mythtv/libs/libmythtv/AirPlay/mythairplayserver.cpp
    M mythtv/libs/libmythtv/AirPlay/mythraopconnection.cpp
    M mythtv/libs/libmythtv/mythplayeroverlayui.cpp
    M mythtv/libs/libmythtv/mythplayerui.cpp
    M mythtv/libs/libmythtv/recorders/httptsstreamhandler.cpp
    M mythtv/libs/libmythui/mythdisplay.cpp
    M mythtv/libs/libmythui/mythmainwindow.cpp
    M mythtv/libs/libmythui/mythscreenstack.cpp
    M mythtv/libs/libmythui/mythuibutton.cpp
    M mythtv/libs/libmythui/mythuifilebrowser.cpp
    M mythtv/libs/libmythupnp/websocket.cpp
    M mythtv/programs/mythbackend/mainserver.cpp
    M mythtv/programs/mythfrontend/galleryinfo.cpp
    M mythtv/programs/mythfrontend/idlescreen.cpp
    M mythtv/programs/mythfrontend/themechooser.cpp
    M mythtv/programs/mythfrontend/upnpscanner.cpp
    M mythtv/programs/mythfrontend/videodlg.cpp
    M mythtv/programs/mythlcdserver/lcdprocclient.cpp
    M mythtv/programs/mythwelcome/welcomedialog.cpp

  Log Message:
  -----------
  clazy: Fix some "use chrono in qtimer" warnings.

>From the docs: Find places where a number is used with QTimer's start,
setElapsed or singleShot methods, and suggests to use chrono literals
instead.

  Commit: e2acfa2dca47d868e6949e0040ba369f68cf81b4
      https://github.com/MythTV/mythtv/commit/e2acfa2dca47d868e6949e0040ba369f68cf81b4
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-11-15 (Sun, 15 Nov 2020)

  Changed paths:
    M mythtv/libs/libmythtv/previewgenerator.cpp
    M mythtv/libs/libmythtv/previewgeneratorqueue.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythui/mythmainwindow.cpp
    M mythtv/libs/libmythui/mythmainwindow.h
    M mythtv/programs/mythfrontend/audiogeneralsettings.cpp
    M mythtv/programs/mythfrontend/playbackboxhelper.cpp

  Log Message:
  -----------
  clazy: Fix "base class event" warnings.

>From the docs: Warns when you return false inside your
QObject::event() or QObject::eventFilter() reimplementation. Instead
you should probably call the base class method, so the event is
correctly handled.

  Commit: c3a7f64b36479607943ae46ffb2e489dc5ae008a
      https://github.com/MythTV/mythtv/commit/c3a7f64b36479607943ae46ffb2e489dc5ae008a
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-11-15 (Sun, 15 Nov 2020)

  Changed paths:
    M mythplugins/mythmusic/mythmusic/decoder.h
    M mythplugins/mythmusic/mythmusic/decoderhandler.cpp
    M mythtv/libs/libmythbase/platforms/mythpowerdbus.cpp
    M mythtv/libs/libmythmetadata/dbaccess.cpp
    M mythtv/libs/libmythmetadata/videometadata.cpp
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp
    M mythtv/libs/libmythtv/decoders/mythv4l2m2mcontext.cpp
    M mythtv/libs/libmythtv/mythplayer.cpp
    M mythtv/programs/mythbackend/mainserver.cpp
    M mythtv/programs/mythfrontend/schedulecommon.cpp
    M mythtv/programs/mythfrontend/videolist.cpp

  Log Message:
  -----------
  clazy: Fix "returning void expression" warnings.

This check looks for void functions that contain the expression:

   return doStuff();

across one or more lines, where doStuff is a function that returns
void. This compiles cleanly because the function returns void, but
appears to be a mistake in the code. Clean these up to be a call to
the function followed by a bare "return" (when necessary).

  Commit: df168cb44ff90354b882c5b8324e27e8dfd7feb6
      https://github.com/MythTV/mythtv/commit/df168cb44ff90354b882c5b8324e27e8dfd7feb6
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-11-15 (Sun, 15 Nov 2020)

  Changed paths:
    M mythplugins/mythbrowser/mythbrowser/browserdbutil.cpp
    M mythplugins/mythbrowser/mythbrowser/browserdbutil.h
    M mythplugins/mythgame/mythgame/rominfo.h
    M mythplugins/mythmusic/mythmusic/mainvisual.cpp
    M mythplugins/mythmusic/mythmusic/mainvisual.h
    M mythplugins/mythmusic/mythmusic/visualize.cpp
    M mythplugins/mythmusic/mythmusic/visualize.h

  Log Message:
  -----------
  clazy: Fix "function args by value" warnings. (plugins)