[mythtv-commits] [MythTV/mythtv] 7377ea: clazy: Fix container anti-pattern warnings.

[David Hampton]

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 7377eaa3bce59ea4e41b18ce0ab439cf39eab004
      https://github.com/MythTV/mythtv/commit/7377eaa3bce59ea4e41b18ce0ab439cf39eab004
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-11-01 (Sun, 01 Nov 2020)

  Changed paths:
    M mythtv/libs/libmythmetadata/imagemanager.cpp
    M mythtv/programs/mythfrontend/gallerythumbview.cpp

  Log Message:
  -----------
  clazy: Fix container anti-pattern warnings.

>From the clazy docs: Finds when temporary containers are being created
needlessly.  These cases are usually easy to fix by using iterators,
avoiding memory allocations.


  Commit: 59a321718b1e35c9ea7c8cb637ac45a27ae247f8
      https://github.com/MythTV/mythtv/commit/59a321718b1e35c9ea7c8cb637ac45a27ae247f8
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-11-01 (Sun, 01 Nov 2020)

  Changed paths:
    M mythtv/libs/libmythbase/compat.h
    M mythtv/libs/libmythtv/recorders/ExternalStreamHandler.cpp

  Log Message:
  -----------
  clazy: Fix a couple of "qt macro" warnings.

These appear to be attempts to use a Q_OS_XXX macro without first
including the qglobal.h file that defines them.


  Commit: b4aea727e769771320e8a93418acef11c0b1f74c
      https://github.com/MythTV/mythtv/commit/b4aea727e769771320e8a93418acef11c0b1f74c
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-11-01 (Sun, 01 Nov 2020)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/channelimporter.cpp

  Log Message:
  -----------
  clazy: Quiet "lambda in connect" warnings.

>From the clazy docs: Warns when a lambda inside a connect captures
local variables by reference.  This usually results in a crash since
the lambda might get called after the captured variable went out of
scope.

These functions all appear safe as they make the connection as part of
creating a dialog, and the function doesn't exit until after the
dialog has been closed (meaning the connections to the lambda
functions have been disconnected).


  Commit: e71ca1204cb50100a95169b22a6cc608c398e9e4
      https://github.com/MythTV/mythtv/commit/e71ca1204cb50100a95169b22a6cc608c398e9e4
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-11-01 (Sun, 01 Nov 2020)

  Changed paths:
    M mythtv/libs/libmythmetadata/imagemanager.cpp
    M mythtv/libs/libmythtv/overlays/mythnavigationoverlay.cpp
    M mythtv/libs/libmythui/platforms/mythscreensaverdbus.cpp
    M mythtv/programs/mythfrontend/gallerythumbview.cpp

  Log Message:
  -----------
  clazy: Fix a couple of range-loop warnings.

>From the clazy docs: Finds places where you're using C++11 range-loops
with non-const Qt containers (potential detach).


  Commit: b4f20041c6330b7d086b5743559ba3c0b296e6e4
      https://github.com/MythTV/mythtv/commit/b4f20041c6330b7d086b5743559ba3c0b296e6e4
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-11-01 (Sun, 01 Nov 2020)

  Changed paths:
    M mythtv/libs/libmythtv/Bluray/mythbdbuffer.cpp
    M mythtv/libs/libmythui/mythuithemecache.cpp

  Log Message:
  -----------
  clazy: Fix a couple of "returning data from temporary" warnings.

>From the clazy docs: Warns when returning the data from a QByteArray
that will soon be destroyed.


  Commit: 17801638e1ebf3e26892be21320ccc320f79e922
      https://github.com/MythTV/mythtv/commit/17801638e1ebf3e26892be21320ccc320f79e922
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-11-01 (Sun, 01 Nov 2020)

  Changed paths:
    M mythtv/programs/mythexternrecorder/MythExternControl.h

  Log Message:
  -----------
  clazy: Fix a couple of "const signal" warnings.

>From the clazy docs: Warns when a signal or non-void slot is const.
For signals it's more of a minor issue. Prevents you from emitting
signals from const methods, as these methods shouldn't change state,
and a signal implies state was changed.


  Commit: 72e81dd87d8bd39a16cd14c0d07343ff26fc6a03
      https://github.com/MythTV/mythtv/commit/72e81dd87d8bd39a16cd14c0d07343ff26fc6a03
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-11-01 (Sun, 01 Nov 2020)

  Changed paths:
    M mythtv/libs/libmyth/mythterminal.h
    M mythtv/libs/libmythtv/opengl/mythvdpauinterop.h

  Log Message:
  -----------
  clazy: Fix a couple of "const slot" warnings.

>From the clazy docs: Warns when a signal or non-void slot is const.
This aims to prevent unintentionally marking a getter as slot, or
connecting to the wrong method.

These functions are never called as a slot and appears to be a simple
getters.


Compare: https://github.com/MythTV/mythtv/compare/95089c93d129...72e81dd87d8b