[mythtv-commits] [MythTV/mythtv] b9e40a: Replace custom bswap_dbl() function with bswap_64().

Tue May 26 21:56:51 UTC 2020

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: b9e40a87a8f42d8145b32f5e2c4f6ea0734ca3ae
      https://github.com/MythTV/mythtv/commit/b9e40a87a8f42d8145b32f5e2c4f6ea0734ca3ae
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M mythtv/libs/libmythbase/bswap.h

  Log Message:
  -----------
  Replace custom bswap_dbl() function with bswap_64().

  Commit: c77b8796c6b6fcbb13026d52d381af3af96ff316
      https://github.com/MythTV/mythtv/commit/c77b8796c6b6fcbb13026d52d381af3af96ff316
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mpeg/freesat_huffman.cpp
    M mythtv/libs/libmythtv/mpeg/freesat_huffman.h
    M mythtv/libs/libmythtv/mpeg/freesat_tables.cpp
    M mythtv/libs/libmythtv/test/test_eitfixups/test_eitfixups.pro
    M mythtv/libs/libmythtv/test/test_mpegtables/test_mpegtables.pro

  Log Message:
  -----------
  Convert freesat_tables to use C++ arrays.

The diffs are easier to read using the 'b' argument.

Also fixes a bugprone-suspicious-include warning.

https://clang.llvm.org/extra/clang-tidy/checks/bugprone-suspicious-include.html

  Commit: d8a33c1ac5ffe3ed850b454c5fb7d4955397579c
      https://github.com/MythTV/mythtv/commit/d8a33c1ac5ffe3ed850b454c5fb7d4955397579c
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/avcinfo.cpp
    M mythtv/libs/libmythtv/recorders/avcinfo.h
    M mythtv/libs/libmythtv/test/test_avcinfo/test_avcinfo.cpp

  Log Message:
  -----------
  tidy: Fix a suspicious include warning in test_avcinfo.cpp.

https://clang.llvm.org/extra/clang-tidy/checks/bugprone-suspicious-include.html

  Commit: 78a5dc5eab99d3c213f53273dcd4237ac47d451f
      https://github.com/MythTV/mythtv/commit/78a5dc5eab99d3c213f53273dcd4237ac47d451f
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M mythtv/libs/libmythtv/dtvconfparserhelpers.h

  Log Message:
  -----------
  tidy: Fix a redundant expression warning in dtvconfparserhelpers.h.

https://clang.llvm.org/extra/clang-tidy/checks/misc-redundant-expression.html

  Commit: 4bd18950829a9d57ab2efefebb6cfd50dffd0b9a
      https://github.com/MythTV/mythtv/commit/4bd18950829a9d57ab2efefebb6cfd50dffd0b9a
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M mythplugins/mythzoneminder/mythzmserver/zmserver.h

  Log Message:
  -----------
  tidy: Fix "redundant string initialization" warnings.

Having no initializer for a string, specifying a default initializer
for as string (aka {}), and specifying that a string be explicitly
initialized to a null string (aka {""}), all have the same result of
creating an empty string.  The clang-tidy program complains about the
last of these three initialization forms, so change the code to use
the default initializer so that it matches the style of the rest of
the initializations in that file.

https://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-string-init.html

  Commit: 242a710980de6f39bd2a62e187a6db853688e988
      https://github.com/MythTV/mythtv/commit/242a710980de6f39bd2a62e187a6db853688e988
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M mythtv/programs/mythfrontend/videodlg.cpp
    M mythtv/programs/mythfrontend/videofileassoc.cpp

  Log Message:
  -----------
  tidy: Updates to two files missed in the first pass.

These changes were missed in the first tidy cleanup pass as the files
contain a construct that crashes the clang-tidy
readability-static-accessed-through-instance checker.

https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html
https://clang.llvm.org/extra/clang-tidy/checks/readability-static-accessed-through-instance.html

  Commit: e8dde96a3445f48a37882bb186d26d362d2fcadf
      https://github.com/MythTV/mythtv/commit/e8dde96a3445f48a37882bb186d26d362d2fcadf
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/channelimporter.cpp
    M mythtv/libs/libmythtv/channelscan/channelimporter.h

  Log Message:
  -----------
  tidy: Convert ChannelImporter::FilterRelocatedServices to be a static function.

This function doesn't use any of the class member variables, and can
therefore be converted to a static function.

https://clang.llvm.org/extra/clang-tidy/checks/readability-convert-member-functions-to-static.html

  Commit: f55f7ebe75a9235c087dd8ea14cc6f195963ceb0
      https://github.com/MythTV/mythtv/commit/f55f7ebe75a9235c087dd8ea14cc6f195963ceb0
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M mythplugins/mythmusic/mythmusic/playlist.cpp
    M mythtv/libs/libmythtv/AirPlay/mythairplayserver.cpp
    M mythtv/libs/libmythtv/HLS/httplivestreambuffer.cpp
    M mythtv/libs/libmythtv/mythccextractorplayer.cpp
    M mythtv/libs/libmythtv/mythplayer.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/videodisplayprofile.cpp
    M mythtv/libs/libmythui/mythdialogbox.cpp
    M mythtv/libs/libmythui/mythdisplay.cpp
    M mythtv/libs/libmythui/platforms/mythdrmdevice.cpp
    M mythtv/programs/mythfrontend/globalsettings.cpp
    M mythtv/programs/mythfrontend/playbackbox.cpp
    M mythtv/programs/mythfrontend/playbackboxhelper.cpp
    M mythtv/programs/mythfrontend/upnpscanner.cpp

  Log Message:
  -----------
  Convert from Qt foreach() macro to C++ standard range-for.  (missed)

The use of foreach has caused some unexpected problems in the
scheduler, which were chased down to containers detaching in the call
to get the last item of the range.  This detach guarantees that the
current iterator is now invalid and the operation will eventually run
off the end of the range.

The Qt company is also planning to remove the foreach/Q_FOREACH macro
in an (as yet unspecified) upcoming release.

Replace all instances of the foreach macro with a standard C++
range-for iteration, and (in almost all cases) use the qAsConst macro
mark to the ranges as constant to prevent detaching of the data.
There are a couple of places where adding the qAsConst macro throws a
compiler error, so omit qAsConst in those instances.  These cases all
appear to occur with temporary lists, and this behavior is intentional
on Qt's part (see the Qt documentation).

Refs #13621

  Commit: 63094445bd041f049f217bbcd7e1e56b7204ec57
      https://github.com/MythTV/mythtv/commit/63094445bd041f049f217bbcd7e1e56b7204ec57
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M .clang-tidy

  Log Message:
  -----------
  Disable another newer clang-tidy check.

  Commit: f6cf85e9d974812e2f6631a6c178f3d719e33215
      https://github.com/MythTV/mythtv/commit/f6cf85e9d974812e2f6631a6c178f3d719e33215
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M mythtv/libs/libmythtv/eitfixup.h
    M mythtv/libs/libmythtv/mpeg/dvbdescriptors.h
    M mythtv/libs/libmythtv/test/test_eitfixups/test_eitfixups.pro
    M mythtv/libs/libmythtv/test/test_mpegtables/test_mpegtables.pro

  Log Message:
  -----------
  Don't double include object files in test code.

Mark a couple of functions as public (so their symbols are exported)
so that object files don't have to be explicitly include in the link
stage.  This prevents double including the objects, once explicitly
and once in the libmythtv library, which causes a weird double free on
only one platform.

Compare: https://github.com/MythTV/mythtv/compare/aa84064a62fa...f6cf85e9d974