[mythtv-commits] [MythTV/mythtv] 5d9b74: Convert from Qt foreach() macro to C++ standard ra...

[linuxdude42]

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 5d9b74e7e6e33b07e2525d6f47776b637e9e7303
      https://github.com/MythTV/mythtv/commit/5d9b74e7e6e33b07e2525d6f47776b637e9e7303
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-05-22 (Fri, 22 May 2020)

  Changed paths:
    M mythplugins/mytharchive/mytharchive/exportnative.cpp
    M mythplugins/mytharchive/mytharchive/fileselector.cpp
    M mythplugins/mytharchive/mytharchive/mythburn.cpp
    M mythplugins/mytharchive/mytharchive/recordingselector.cpp
    M mythplugins/mytharchive/mytharchive/themeselector.cpp
    M mythplugins/mytharchive/mytharchive/thumbfinder.cpp
    M mythplugins/mytharchive/mytharchive/videoselector.cpp
    M mythplugins/mythbrowser/mythbrowser/bookmarkmanager.cpp
    M mythplugins/mythgame/mythgame/gamehandler.cpp
    M mythplugins/mythgame/mythgame/gamescan.cpp
    M mythplugins/mythgame/mythgame/gameui.cpp
    M mythplugins/mythgame/mythgame/romedit.cpp
    M mythplugins/mythgame/mythgame/rominfo.cpp
    M mythplugins/mythmusic/mythmusic/cdrip.cpp
    M mythplugins/mythmusic/mythmusic/decoder.cpp
    M mythplugins/mythmusic/mythmusic/editmetadata.cpp
    M mythplugins/mythmusic/mythmusic/playlist.cpp
    M mythplugins/mythmusic/mythmusic/playlistcontainer.cpp
    M mythplugins/mythmusic/mythmusic/smartplaylist.cpp
    M mythplugins/mythnetvision/mythnetvision/neteditorbase.cpp
    M mythplugins/mythnetvision/mythnetvision/netsearch.cpp
    M mythplugins/mythnetvision/mythnetvision/nettree.cpp
    M mythplugins/mythnetvision/mythnetvision/rsseditor.cpp
    M mythplugins/mythweather/mythweather/sourceManager.cpp
    M mythplugins/mythweather/mythweather/weatherSetup.cpp
    M mythplugins/mythzoneminder/mythzoneminder/zmevents.cpp

  Log Message:
  -----------
  Convert from Qt foreach() macro to C++ standard range-for.  (plugins)

The use of foreach has caused some unexpected problems in the
scheduler, which were chased down to containers detaching in the call
to get the last item of the range.  This detach guarantees that the
current iterator is now invalid and the operation will eventually run
off the end of the range.

The Qt company is also planning to remove the foreach/Q_FOREACH macro
in an (as yet unspecified) upcoming release.

Replace all instances of the foreach macro with a standard C++
range-for iteration, and (in almost all cases) use the qAsConst macro
mark to the ranges as constant to prevent detaching of the data.
There are a couple of places where adding the qAsConst macro throws a
compiler error, so omit qAsConst in those instances.  These cases all
appear to occur with temporary lists, and this behavior is intentional
on Qt's part (see the Qt documentation).

Refs #13621


  Commit: f6e3a9598bf8bb5e9b308cdb7f13bd05a317480d
      https://github.com/MythTV/mythtv/commit/f6e3a9598bf8bb5e9b308cdb7f13bd05a317480d
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-05-22 (Fri, 22 May 2020)

  Changed paths:
    M mythtv/programs/mythbackend/autoexpire.cpp
    M mythtv/programs/mythbackend/httpconfig.cpp
    M mythtv/programs/mythbackend/httpstatus.cpp
    M mythtv/programs/mythbackend/mainserver.cpp
    M mythtv/programs/mythbackend/mythsettings.cpp
    M mythtv/programs/mythbackend/services/dvr.cpp
    M mythtv/programs/mythbackend/services/image.cpp
    M mythtv/programs/mythcommflag/FrameAnalyzer.cpp
    M mythtv/programs/mythcommflag/main.cpp
    M mythtv/programs/mythfilldatabase/main.cpp
    M mythtv/programs/mythfrontend/actionset.cpp
    M mythtv/programs/mythfrontend/audiogeneralsettings.cpp
    M mythtv/programs/mythfrontend/editvideometadata.cpp
    M mythtv/programs/mythfrontend/galleryinfo.cpp
    M mythtv/programs/mythfrontend/galleryslide.cpp
    M mythtv/programs/mythfrontend/gallerythumbview.cpp
    M mythtv/programs/mythfrontend/galleryviews.cpp
    M mythtv/programs/mythfrontend/globalsettings.cpp
    M mythtv/programs/mythfrontend/guidegrid.cpp
    M mythtv/programs/mythfrontend/keybindings.cpp
    M mythtv/programs/mythfrontend/main.cpp
    M mythtv/programs/mythfrontend/mythcontrols.cpp
    M mythtv/programs/mythfrontend/mythfexml.cpp
    M mythtv/programs/mythfrontend/proginfolist.cpp
    M mythtv/programs/mythfrontend/programinfocache.cpp
    M mythtv/programs/mythfrontend/scheduleeditor.cpp
    M mythtv/programs/mythfrontend/services/frontend.cpp
    M mythtv/programs/mythfrontend/setupwizard_audio.cpp
    M mythtv/programs/mythfrontend/statusbox.cpp
    M mythtv/programs/mythfrontend/themechooser.cpp
    M mythtv/programs/mythfrontend/videodlg.cpp
    M mythtv/programs/mythlcdserver/lcdprocclient.cpp
    M mythtv/programs/mythlcdserver/lcdserver.cpp
    M mythtv/programs/mythtranscode/audioreencodebuffer.cpp
    M mythtv/programs/mythtranscode/main.cpp
    M mythtv/programs/mythtranscode/mpeg2fix.cpp
    M mythtv/programs/mythtv-setup/importicons.cpp
    M mythtv/programs/mythutil/markuputils.cpp
    M mythtv/programs/mythutil/mpegutils.cpp

  Log Message:
  -----------
  Convert from Qt foreach() macro to C++ standard range-for.  (programs)

The use of foreach has caused some unexpected problems in the
scheduler, which were chased down to containers detaching in the call
to get the last item of the range.  This detach guarantees that the
current iterator is now invalid and the operation will eventually run
off the end of the range.

The Qt company is also planning to remove the foreach/Q_FOREACH macro
in an (as yet unspecified) upcoming release.

Replace all instances of the foreach macro with a standard C++
range-for iteration, and (in almost all cases) use the qAsConst macro
mark to the ranges as constant to prevent detaching of the data.
There are a couple of places where adding the qAsConst macro throws a
compiler error, so omit qAsConst in those instances.  These cases all
appear to occur with temporary lists, and this behavior is intentional
on Qt's part (see the Qt documentation).

Refs #13621


  Commit: b357f7d78dd4551e08a001d258ac1ca7b070e731
      https://github.com/MythTV/mythtv/commit/b357f7d78dd4551e08a001d258ac1ca7b070e731
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-05-22 (Fri, 22 May 2020)

  Changed paths:
    M mythtv/libs/libmythtv/AirPlay/mythraopconnection.cpp
    M mythtv/libs/libmythtv/HLS/m3u.cpp
    M mythtv/libs/libmythtv/captions/cc608decoder.cpp
    M mythtv/libs/libmythtv/captions/srtwriter.cpp
    M mythtv/libs/libmythtv/captions/subtitlescreen.cpp
    M mythtv/libs/libmythtv/captions/teletextscreen.cpp
    M mythtv/libs/libmythtv/captions/vbi608extractor.cpp
    M mythtv/libs/libmythtv/cardutil.cpp
    M mythtv/libs/libmythtv/channelscan/channelscan_sm.cpp
    M mythtv/libs/libmythtv/dbcheck.cpp
    M mythtv/libs/libmythtv/decoders/mythmediacodeccontext.cpp
    M mythtv/libs/libmythtv/decoders/mythmmalcontext.cpp
    M mythtv/libs/libmythtv/decoders/mythv4l2m2mcontext.cpp
    M mythtv/libs/libmythtv/decoders/mythvaapicontext.cpp
    M mythtv/libs/libmythtv/decoders/mythvdpauhelper.cpp
    M mythtv/libs/libmythtv/deletemap.cpp
    M mythtv/libs/libmythtv/diseqc.cpp
    M mythtv/libs/libmythtv/diseqcsettings.cpp
    M mythtv/libs/libmythtv/eitfixup.cpp
    M mythtv/libs/libmythtv/jobqueue.cpp
    M mythtv/libs/libmythtv/livetvchain.cpp
    M mythtv/libs/libmythtv/mheg/dsmcc.cpp
    M mythtv/libs/libmythtv/mheg/dsmccobjcarousel.cpp
    M mythtv/libs/libmythtv/mheg/mhegic.cpp
    M mythtv/libs/libmythtv/mheg/netstream.cpp
    M mythtv/libs/libmythtv/mpeg/atscdescriptors.cpp
    M mythtv/libs/libmythtv/mpeg/atscstreamdata.cpp
    M mythtv/libs/libmythtv/mpeg/dvbstreamdata.cpp
    M mythtv/libs/libmythtv/mpeg/mpegstreamdata.cpp
    M mythtv/libs/libmythtv/opengl/mythnvdecinterop.cpp
    M mythtv/libs/libmythtv/opengl/mythopenglvideo.cpp
    M mythtv/libs/libmythtv/opengl/mythvaapidrminterop.cpp
    M mythtv/libs/libmythtv/opengl/mythvideooutopengl.cpp
    M mythtv/libs/libmythtv/opengl/mythvtbinterop.cpp
    M mythtv/libs/libmythtv/osd.cpp
    M mythtv/libs/libmythtv/previewgeneratorqueue.cpp
    M mythtv/libs/libmythtv/profilegroup.cpp
    M mythtv/libs/libmythtv/programdata.cpp
    M mythtv/libs/libmythtv/recorders/cetonrtsp.cpp
    M mythtv/libs/libmythtv/recorders/darwinfirewiredevice.cpp
    M mythtv/libs/libmythtv/recorders/iptvstreamhandler.cpp
    M mythtv/libs/libmythtv/recorders/linuxfirewiredevice.cpp
    M mythtv/libs/libmythtv/recorders/vboxutils.cpp
    M mythtv/libs/libmythtv/recordingprofile.cpp
    M mythtv/libs/libmythtv/recordingquality.cpp
    M mythtv/libs/libmythtv/sourceutil.cpp
    M mythtv/libs/libmythtv/tv_rec.cpp
    M mythtv/libs/libmythtv/tvremoteutil.cpp
    M mythtv/libs/libmythtv/videosource.cpp

  Log Message:
  -----------
  Convert from Qt foreach() macro to C++ standard range-for.  (libs/libmythtv)

The use of foreach has caused some unexpected problems in the
scheduler, which were chased down to containers detaching in the call
to get the last item of the range.  This detach guarantees that the
current iterator is now invalid and the operation will eventually run
off the end of the range.

The Qt company is also planning to remove the foreach/Q_FOREACH macro
in an (as yet unspecified) upcoming release.

Replace all instances of the foreach macro with a standard C++
range-for iteration, and (in almost all cases) use the qAsConst macro
mark to the ranges as constant to prevent detaching of the data.
There are a couple of places where adding the qAsConst macro throws a
compiler error, so omit qAsConst in those instances.  These cases all
appear to occur with temporary lists, and this behavior is intentional
on Qt's part (see the Qt documentation).

Refs #13621


  Commit: 174e8f7149c627a4fef294fa572b77387fe9db09
      https://github.com/MythTV/mythtv/commit/174e8f7149c627a4fef294fa572b77387fe9db09
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-05-22 (Fri, 22 May 2020)

  Changed paths:
    M mythtv/libs/libmythui/devices/lirc.cpp
    M mythtv/libs/libmythui/mythedid.cpp
    M mythtv/libs/libmythui/mythfontmanager.cpp
    M mythtv/libs/libmythui/mythfontproperties.cpp
    M mythtv/libs/libmythui/mythgenerictree.cpp
    M mythtv/libs/libmythui/mythmainwindow.cpp
    M mythtv/libs/libmythui/mythnotificationcenter.cpp
    M mythtv/libs/libmythui/mythnotificationcenter_private.h
    M mythtv/libs/libmythui/mythpainter.cpp
    M mythtv/libs/libmythui/mythscreenstack.cpp
    M mythtv/libs/libmythui/myththemedmenu.cpp
    M mythtv/libs/libmythui/mythuibuttonlist.cpp
    M mythtv/libs/libmythui/mythuiguidegrid.cpp
    M mythtv/libs/libmythui/mythuihelper.cpp
    M mythtv/libs/libmythui/mythuiimage.cpp
    M mythtv/libs/libmythui/mythuistatetype.cpp
    M mythtv/libs/libmythui/mythuitext.cpp
    M mythtv/libs/libmythui/mythuitextedit.cpp
    M mythtv/libs/libmythui/mythuitype.cpp
    M mythtv/libs/libmythui/mythvirtualkeyboard.cpp
    M mythtv/libs/libmythui/opengl/mythrenderopengl.cpp
    M mythtv/libs/libmythui/xmlparsebase.cpp

  Log Message:
  -----------
  Convert from Qt foreach() macro to C++ standard range-for.  (libs/libmythui)

The use of foreach has caused some unexpected problems in the
scheduler, which were chased down to containers detaching in the call
to get the last item of the range.  This detach guarantees that the
current iterator is now invalid and the operation will eventually run
off the end of the range.

The Qt company is also planning to remove the foreach/Q_FOREACH macro
in an (as yet unspecified) upcoming release.

Replace all instances of the foreach macro with a standard C++
range-for iteration, and (in almost all cases) use the qAsConst macro
mark to the ranges as constant to prevent detaching of the data.
There are a couple of places where adding the qAsConst macro throws a
compiler error, so omit qAsConst in those instances.  These cases all
appear to occur with temporary lists, and this behavior is intentional
on Qt's part (see the Qt documentation).

Refs #13621


  Commit: 11df0636c5af03c9496a0c9942e34921377a2255
      https://github.com/MythTV/mythtv/commit/11df0636c5af03c9496a0c9942e34921377a2255
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-05-22 (Fri, 22 May 2020)

  Changed paths:
    M mythtv/libs/libmythbase/housekeeper.cpp
    M mythtv/libs/libmythbase/iso639.cpp
    M mythtv/libs/libmythbase/logging.cpp
    M mythtv/libs/libmythbase/loggingserver.cpp
    M mythtv/libs/libmythbase/mthreadpool.cpp
    M mythtv/libs/libmythbase/mythcommandlineparser.cpp
    M mythtv/libs/libmythbase/mythcorecontext.cpp
    M mythtv/libs/libmythbase/mythdbcon.cpp
    M mythtv/libs/libmythbase/mythdownloadmanager.cpp
    M mythtv/libs/libmythbase/mythmedia.cpp
    M mythtv/libs/libmythbase/mythmiscutil.cpp
    M mythtv/libs/libmythbase/mythplugin.cpp
    M mythtv/libs/libmythbase/mythsorthelper.cpp
    M mythtv/libs/libmythbase/mythsystemunix.cpp
    M mythtv/libs/libmythbase/mythtranslation.cpp
    M mythtv/libs/libmythbase/platforms/mythpowerdbus.cpp
    M mythtv/libs/libmythbase/plist.cpp
    M mythtv/libs/libmythbase/portchecker.cpp
    M mythtv/libs/libmythbase/remotefile.cpp
    M mythtv/libs/libmythbase/signalhandling.cpp
    M mythtv/libs/libmythbase/storagegroup.cpp

  Log Message:
  -----------
  Convert from Qt foreach() macro to C++ standard range-for.  (libs/libmythbase)

The use of foreach has caused some unexpected problems in the
scheduler, which were chased down to containers detaching in the call
to get the last item of the range.  This detach guarantees that the
current iterator is now invalid and the operation will eventually run
off the end of the range.

The Qt company is also planning to remove the foreach/Q_FOREACH macro
in an (as yet unspecified) upcoming release.

Replace all instances of the foreach macro with a standard C++
range-for iteration, and (in almost all cases) use the qAsConst macro
mark to the ranges as constant to prevent detaching of the data.
There are a couple of places where adding the qAsConst macro throws a
compiler error, so omit qAsConst in those instances.  These cases all
appear to occur with temporary lists, and this behavior is intentional
on Qt's part (see the Qt documentation).

Refs #13621


  Commit: c3cc79da1137ea9bf96945ac4287813197b360eb
      https://github.com/MythTV/mythtv/commit/c3cc79da1137ea9bf96945ac4287813197b360eb
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-05-22 (Fri, 22 May 2020)

  Changed paths:
    M mythtv/libs/libmyth/audio/audiooutput.cpp
    M mythtv/libs/libmyth/langsettings.cpp
    M mythtv/libs/libmyth/mediamonitor-unix.cpp
    M mythtv/libs/libmyth/mediamonitor-windows.cpp
    M mythtv/libs/libmyth/mythmediamonitor.cpp
    M mythtv/libs/libmyth/mythrssmanager.cpp
    M mythtv/libs/libmyth/programinfo.cpp
    M mythtv/libs/libmyth/rssparse.cpp
    M mythtv/libs/libmyth/standardsettings.cpp
    M mythtv/libs/libmythfreemheg/Engine.cpp
    M mythtv/libs/libmythfreemheg/TokenGroup.cpp
    M mythtv/libs/libmythmetadata/dirscan.cpp
    M mythtv/libs/libmythmetadata/imagemanager.cpp
    M mythtv/libs/libmythmetadata/imagemetadata.cpp
    M mythtv/libs/libmythmetadata/imagescanner.cpp
    M mythtv/libs/libmythmetadata/imagethumbs.cpp
    M mythtv/libs/libmythmetadata/imagetypes.h
    M mythtv/libs/libmythmetadata/metadatadownload.cpp
    M mythtv/libs/libmythmetadata/metadatagrabber.cpp
    M mythtv/libs/libmythmetadata/musicmetadata.cpp
    M mythtv/libs/libmythmetadata/parentalcontrols.cpp
    M mythtv/libs/libmythmetadata/videometadata.cpp
    M mythtv/libs/libmythmetadata/videoscan.cpp
    M mythtv/libs/libmythmetadata/videoutils.cpp
    M mythtv/libs/libmythservicecontracts/datacontracthelper.h
    M mythtv/libs/libmythui/mythmainwindow.cpp
    M mythtv/libs/libmythupnp/eventing.cpp
    M mythtv/libs/libmythupnp/eventing.h
    M mythtv/libs/libmythupnp/httprequest.cpp
    M mythtv/libs/libmythupnp/mmulticastsocketdevice.cpp
    M mythtv/libs/libmythupnp/serverSideScripting.cpp
    M mythtv/libs/libmythupnp/ssdp.cpp
    M mythtv/libs/libmythupnp/ssdpcache.cpp
    M mythtv/libs/libmythupnp/upnpcds.cpp
    M mythtv/libs/libmythupnp/upnpcdsobjects.cpp
    M mythtv/libs/libmythupnp/upnpdevice.cpp
    M mythtv/libs/libmythupnp/upnptasknotify.cpp
    M mythtv/libs/libmythupnp/upnptasksearch.cpp
    M mythtv/libs/libmythupnp/websocket.cpp

  Log Message:
  -----------
  Convert from Qt foreach() macro to C++ standard range-for.  (libs)

The use of foreach has caused some unexpected problems in the
scheduler, which were chased down to containers detaching in the call
to get the last item of the range.  This detach guarantees that the
current iterator is now invalid and the operation will eventually run
off the end of the range.

The Qt company is also planning to remove the foreach/Q_FOREACH macro
in an (as yet unspecified) upcoming release.

Replace all instances of the foreach macro with a standard C++
range-for iteration, and (in almost all cases) use the qAsConst macro
mark to the ranges as constant to prevent detaching of the data.
There are a couple of places where adding the qAsConst macro throws a
compiler error, so omit qAsConst in those instances.  These cases all
appear to occur with temporary lists, and this behavior is intentional
on Qt's part (see the Qt documentation).

Fixes #13621


  Commit: 8b4abcd4dec93dc72ed362f8db1e255230ab9685
      https://github.com/MythTV/mythtv/commit/8b4abcd4dec93dc72ed362f8db1e255230ab9685
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-05-22 (Fri, 22 May 2020)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/channelscan_sm.cpp

  Log Message:
  -----------
  Fix current clang-tidy failure in master.


Compare: https://github.com/MythTV/mythtv/compare/1a1b69836515...8b4abcd4dec9