[mythtv-commits] [MythTV/mythtv] fb5ab2: tidy: Simplify creating new unique pointers.

[linuxdude42]

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: fb5ab2fd2f6e7ca7378b62191c332cf58061c351
      https://github.com/MythTV/mythtv/commit/fb5ab2fd2f6e7ca7378b62191c332cf58061c351
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-07-17 (Fri, 17 Jul 2020)

  Changed paths:
    M mythplugins/mythmusic/mythmusic/cdrip.cpp
    M mythtv/programs/mythfrontend/videodlg.cpp

  Log Message:
  -----------
  tidy: Simplify creating new unique pointers.

The clang-tidy "modernize make unique" checker pointed out a couple of
places where a unique_ptr was updated by calling:

    ptr.reset(new PtrType(args))

and replaces this with:

    ptr = make_unique<PtrType>(args)

All changes made by the clang-tidy program.

https://clang.llvm.org/extra/clang-tidy/checks/modernize-make-unique.html


  Commit: eb811fe9c1cceff54ef06bc76adba031e7892270
      https://github.com/MythTV/mythtv/commit/eb811fe9c1cceff54ef06bc76adba031e7892270
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-07-17 (Fri, 17 Jul 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mpeg/AVCParser.h
    M mythtv/libs/libmythtv/opengl/mythopengltonemap.h
    M mythtv/libs/libmythtv/recorders/satipchannel.h
    M mythtv/libs/libmythtv/recorders/satiprtsp.h
    M mythtv/libs/libmythtv/recorders/satipsignalmonitor.h
    M mythtv/libs/libmythui/mythpainter.h

  Log Message:
  -----------
  tidy: Use the 'override' keyword on destructors.

The new override keyword should be used on functions in a derived
classes that overload a function in their base class.  It implicitly
declares the function as virtual, so it replaces that keyword.  It
additionally requires that a function exist in the base class with the
exact same type signature.  I.E. it validates that the overridden
function exists.  This prevents functions that look like they override
a base class function but don't.

All changes made by the clang-tidy program.

https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html


  Commit: 7046852c6753ada0deb3d5c7f8ea78b1fd8feab7
      https://github.com/MythTV/mythtv/commit/7046852c6753ada0deb3d5c7f8ea78b1fd8feab7
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-07-17 (Fri, 17 Jul 2020)

  Changed paths:
    M mythtv/libs/libmythtv/io/mythopticalbuffer.h

  Log Message:
  -----------
  Don't use final keyword

- gcc complains if it is not used in conjunction with 'override' and
clang-tidy clearly thinks 'override' is superfluous


  Commit: 062ef343bbdfda199b02a0de4586af499eb35a36
      https://github.com/MythTV/mythtv/commit/062ef343bbdfda199b02a0de4586af499eb35a36
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-07-17 (Fri, 17 Jul 2020)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/satiprtsp.h

  Log Message:
  -----------
  tidy: Replace "typedef" with "using" in satip.

The clang-tidy modernize "use using" checker pointed out one place
where the older style of "typedef a b;" should be replaced with the
modern construct of "using b = a;".  All changes made by the
clang-tidy program.

https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-using.html


  Commit: b1cebe08ba32fc3c19e5aed0e5f0a023978cfefd
      https://github.com/MythTV/mythtv/commit/b1cebe08ba32fc3c19e5aed0e5f0a023978cfefd
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-07-17 (Fri, 17 Jul 2020)

  Changed paths:
    M mythtv/libs/libmyth/backendselect.cpp
    M mythtv/libs/libmyth/backendselect.h
    M mythtv/libs/libmythbase/dbcheckcommon.cpp
    M mythtv/libs/libmythbase/logging.cpp
    M mythtv/libs/libmythbase/mythdbcheck.h
    M mythtv/libs/libmythbase/mythmiscutil.cpp
    M mythtv/libs/libmythbase/mythmiscutil.h
    M mythtv/libs/libmythtv/mythavutil.cpp
    M mythtv/libs/libmythtv/mythavutil.h
    M mythtv/libs/libmythtv/recorders/satiprtsp.cpp
    M mythtv/libs/libmythtv/recorders/satiprtsp.h
    M mythtv/libs/libmythtv/recorders/satiputils.cpp
    M mythtv/libs/libmythtv/recorders/satiputils.h
    M mythtv/libs/libmythtv/videodisplayprofile.cpp
    M mythtv/libs/libmythtv/videodisplayprofile.h
    M mythtv/libs/libmythui/mythdisplay.cpp
    M mythtv/libs/libmythui/mythdisplay.h
    M mythtv/programs/mythfrontend/statusbox.h

  Log Message:
  -----------
  tidy: Eliminate unnecessary copying of objects.

The clang-tidy "unnecessary value param" check pointed out several
places where objects were passed by copying when it could be passed by
const reference.  Changes made by the clang-tidy program.

https://clang.llvm.org/extra/clang-tidy/checks/performance-unnecessary-value-param.html


  Commit: a6ebda8557c8e6e8880e96fa46129b8a49de47fe
      https://github.com/MythTV/mythtv/commit/a6ebda8557c8e6e8880e96fa46129b8a49de47fe
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-07-17 (Fri, 17 Jul 2020)

  Changed paths:
    M .clang-tidy

  Log Message:
  -----------
  Update .clang-tidy file.


  Commit: 12812f44b3e3acb85be78e2ed5c427140b1fe5d3
      https://github.com/MythTV/mythtv/commit/12812f44b3e3acb85be78e2ed5c427140b1fe5d3
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-07-17 (Fri, 17 Jul 2020)

  Changed paths:
    M mythtv/configure

  Log Message:
  -----------
  Bump the minimum Qt version to 5.9.

The code changes were made on 2020-06-01, commit 33f6c3b6b9.


Compare: https://github.com/MythTV/mythtv/compare/55432fdd4286...12812f44b3e3