[mythtv-commits] [MythTV/mythtv] 67a6d7: QString::asprintf is a static member function.

Sat Jan 11 01:55:22 UTC 2020

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 67a6d7703ea3e7a050f0f5615ff440cc89f36fae
      https://github.com/MythTV/mythtv/commit/67a6d7703ea3e7a050f0f5615ff440cc89f36fae
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-01-10 (Fri, 10 Jan 2020)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/dvbdev/dvbci.cpp

  Log Message:
  -----------
  QString::asprintf is a static member function.

It doesn't update the string object on which its called.  This is in
contrast to QString::sprintf which isn't static and does update the
current string.

Note: This function may be removed in Qt6 which will require
redesigning the debugging in the dvbdev directory.

  Commit: 6dab8be746c0039b64845e6bec6f88b45ab0a0e4
      https://github.com/MythTV/mythtv/commit/6dab8be746c0039b64845e6bec6f88b45ab0a0e4
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-01-10 (Fri, 10 Jan 2020)

  Changed paths:
    M .clang-tidy
    M mythtv/libs/libmyth/audio/audiooutputbase.h
    M mythtv/libs/libmyth/programinfo.h
    M mythtv/libs/libmyth/standardsettings.h
    M mythtv/libs/libmythtv/AirPlay/mythairplayserver.cpp
    M mythtv/libs/libmythtv/AirPlay/mythraopconnection.cpp
    M mythtv/libs/libmythtv/Bluray/bdiowrapper.cpp
    M mythtv/libs/libmythtv/DVD/avformatdecoderdvd.cpp
    M mythtv/libs/libmythtv/DVD/dvdringbuffer.cpp
    M mythtv/libs/libmythtv/HLS/httplivestreambuffer.cpp
    M mythtv/libs/libmythtv/HLS/m3u.cpp
    M mythtv/libs/libmythtv/avformatwriter.cpp
    M mythtv/libs/libmythtv/cardutil.cpp
    M mythtv/libs/libmythtv/cardutil.h
    M mythtv/libs/libmythtv/cc608decoder.cpp
    M mythtv/libs/libmythtv/cc608reader.cpp
    M mythtv/libs/libmythtv/cc708decoder.cpp
    M mythtv/libs/libmythtv/cc708window.cpp
    M mythtv/libs/libmythtv/channelscan/channelimporter.cpp
    M mythtv/libs/libmythtv/channelscan/channelscan_sm.cpp
    M mythtv/libs/libmythtv/channelscan/iptvchannelfetcher.cpp
    M mythtv/libs/libmythtv/channelsettings.cpp
    M mythtv/libs/libmythtv/channelutil.cpp
    M mythtv/libs/libmythtv/channelutil.h
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp
    M mythtv/libs/libmythtv/decoders/decoderbase.cpp
    M mythtv/libs/libmythtv/decoders/mythnvdeccontext.cpp
    M mythtv/libs/libmythtv/decoders/mythvaapicontext.cpp
    M mythtv/libs/libmythtv/decoders/mythvdpauhelper.cpp
    M mythtv/libs/libmythtv/decoders/nuppeldecoder.cpp
    M mythtv/libs/libmythtv/deletemap.cpp
    M mythtv/libs/libmythtv/diseqcsettings.cpp
    M mythtv/libs/libmythtv/dvdstream.cpp
    M mythtv/libs/libmythtv/eitfixup.cpp
    M mythtv/libs/libmythtv/eithelper.cpp
    M mythtv/libs/libmythtv/fifowriter.cpp
    M mythtv/libs/libmythtv/icringbuffer.cpp
    M mythtv/libs/libmythtv/jobqueue.cpp
    M mythtv/libs/libmythtv/mheg/dsmcc.cpp
    M mythtv/libs/libmythtv/mheg/dsmccbiop.cpp
    M mythtv/libs/libmythtv/mheg/dsmcccache.cpp
    M mythtv/libs/libmythtv/mheg/mhi.cpp
    M mythtv/libs/libmythtv/mpeg/H264Parser.cpp
    M mythtv/libs/libmythtv/mpeg/atsc_huffman.cpp
    M mythtv/libs/libmythtv/mpeg/freesat_huffman.cpp
    M mythtv/libs/libmythtv/mpeg/mpegdescriptors.cpp
    M mythtv/libs/libmythtv/mythccextractorplayer.cpp
    M mythtv/libs/libmythtv/mythframe.cpp
    M mythtv/libs/libmythtv/mythframe.h
    M mythtv/libs/libmythtv/mythplayer.cpp
    M mythtv/libs/libmythtv/mythsystemevent.cpp
    M mythtv/libs/libmythtv/mythvideoout.cpp
    M mythtv/libs/libmythtv/netstream.cpp
    M mythtv/libs/libmythtv/opengl/mythnvdecinterop.cpp
    M mythtv/libs/libmythtv/opengl/mythvaapidrminterop.cpp
    M mythtv/libs/libmythtv/opengl/mythvaapiglxinterop.cpp
    M mythtv/libs/libmythtv/opengl/mythvaapiinterop.cpp
    M mythtv/libs/libmythtv/opengl/mythvideooutopengl.cpp
    M mythtv/libs/libmythtv/opengl/mythvideotexture.cpp
    M mythtv/libs/libmythtv/osd.cpp
    M mythtv/libs/libmythtv/previewgeneratorqueue.cpp
    M mythtv/libs/libmythtv/programdata.cpp
    M mythtv/libs/libmythtv/recorders/DeviceReadBuffer.cpp
    M mythtv/libs/libmythtv/recorders/ExternalSignalMonitor.cpp
    M mythtv/libs/libmythtv/recorders/ExternalStreamHandler.cpp
    M mythtv/libs/libmythtv/recorders/HLS/HLSReader.cpp
    M mythtv/libs/libmythtv/recorders/HLS/HLSStreamWorker.cpp
    M mythtv/libs/libmythtv/recorders/NuppelVideoRecorder.cpp
    M mythtv/libs/libmythtv/recorders/RTjpegN.cpp
    M mythtv/libs/libmythtv/recorders/analogsignalmonitor.cpp
    M mythtv/libs/libmythtv/recorders/asistreamhandler.cpp
    M mythtv/libs/libmythtv/recorders/audioinputalsa.cpp
    M mythtv/libs/libmythtv/recorders/audioinputoss.cpp
    M mythtv/libs/libmythtv/recorders/cetonrtsp.cpp
    M mythtv/libs/libmythtv/recorders/cetonstreamhandler.cpp
    M mythtv/libs/libmythtv/recorders/channelbase.cpp
    M mythtv/libs/libmythtv/recorders/dtvchannel.cpp
    M mythtv/libs/libmythtv/recorders/dtvrecorder.cpp
    M mythtv/libs/libmythtv/recorders/dvbchannel.cpp
    M mythtv/libs/libmythtv/recorders/dvbdev/dvbci.cpp
    M mythtv/libs/libmythtv/recorders/dvbstreamhandler.cpp
    M mythtv/libs/libmythtv/recorders/firewirechannel.cpp
    M mythtv/libs/libmythtv/recorders/hdhrstreamhandler.cpp
    M mythtv/libs/libmythtv/recorders/iptvstreamhandler.cpp
    M mythtv/libs/libmythtv/recorders/linuxfirewiredevice.cpp
    M mythtv/libs/libmythtv/recorders/mpegrecorder.cpp
    M mythtv/libs/libmythtv/recorders/v4l2encrecorder.cpp
    M mythtv/libs/libmythtv/recorders/v4l2encsignalmonitor.cpp
    M mythtv/libs/libmythtv/recorders/v4l2encstreamhandler.cpp
    M mythtv/libs/libmythtv/recorders/v4lchannel.cpp
    M mythtv/libs/libmythtv/recorders/vbitext/cc.cpp
    M mythtv/libs/libmythtv/recorders/vbitext/hamm.c
    M mythtv/libs/libmythtv/recorders/vbitext/lang.c
    M mythtv/libs/libmythtv/recorders/vbitext/vbi.c
    M mythtv/libs/libmythtv/remoteencoder.cpp
    M mythtv/libs/libmythtv/ringbuffer.cpp
    M mythtv/libs/libmythtv/scanwizard.cpp
    M mythtv/libs/libmythtv/streamingringbuffer.cpp
    M mythtv/libs/libmythtv/subtitlescreen.cpp
    M mythtv/libs/libmythtv/teletextdecoder.cpp
    M mythtv/libs/libmythtv/teletextreader.cpp
    M mythtv/libs/libmythtv/teletextscreen.cpp
    M mythtv/libs/libmythtv/test/test_eitfixups/test_eitfixups.cpp
    M mythtv/libs/libmythtv/test/test_mythiowrapper/test_mythiowrapper.cpp
    M mythtv/libs/libmythtv/tv.h
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tv_rec.cpp
    M mythtv/libs/libmythtv/tvremoteutil.cpp
    M mythtv/libs/libmythtv/v4l2util.cpp
    M mythtv/libs/libmythtv/videodisplayprofile.cpp
    M mythtv/libs/libmythtv/videosource.cpp
    M mythtv/libs/libmythtv/visualisations/goom/drawmethods.h
    M mythtv/libs/libmythtv/visualisations/goom/filters.c
    M mythtv/libs/libmythtv/visualisations/goom/goom_core.c
    M mythtv/libs/libmythtv/visualisations/goom/ifs.c
    M mythtv/libs/libmythtv/visualisations/goom/ifs_display.c
    M mythtv/libs/libmythtv/visualisations/goom/lines.c
    M mythtv/libs/libmythtv/visualisations/goom/surf3d.c
    M mythtv/libs/libmythtv/visualisations/goom/tentacle3d.c
    M mythtv/libs/libmythtv/visualisations/goom/zoom_filter_mmx.c
    M mythtv/libs/libmythtv/visualisations/videovisual.cpp
    M mythtv/libs/libmythtv/visualisations/videovisualdefs.h
    M mythtv/libs/libmythtv/vsync.cpp
    M mythtv/libs/libmythtv/xine_demux_sputext.cpp
    M mythtv/libs/libmythui/mythdialogbox.h
    M mythtv/libs/libmythui/mythmainwindow.cpp
    M mythtv/libs/libmythui/mythnotificationcenter_private.h
    M mythtv/libs/libmythui/opengl/mythrenderopengl.cpp
    M mythtv/libs/libmythui/platforms/mythdrmdevice.cpp
    M mythtv/programs/mythtranscode/external/replex/ringbuffer.h

  Log Message:
  -----------
  tidy: Make sure all local variables are initialized.

The clang-tidy "local variable initial value" checker pointed out a
large number of uninitialized local variables in functions.  Where
possible these were fixed by reducing the scope of the variable and
combining the declaration and initialization of the variable into a
single statement.  When that wasn't possible, suitable initial values
were provided for the variable.  In one or two instances there are
minor code tweaks to not assign an initial value and then immediately
reassign the same value in the 'else' clause of an 'if' statement.

https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines-init-variables.html

  Commit: 861c2625b0907133451ebdfdc68831061058a613
      https://github.com/MythTV/mythtv/commit/861c2625b0907133451ebdfdc68831061058a613
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-01-10 (Fri, 10 Jan 2020)

  Changed paths:
    M mythplugins/mytharchive/mytharchive/archiveutil.h
    M mythplugins/mytharchive/mytharchive/fileselector.h
    M mythplugins/mytharchive/mytharchive/videoselector.h
    M mythplugins/mythgame/mythgame/gamescan.h
    M mythplugins/mythmusic/mythmusic/bumpscope.h
    M mythplugins/mythmusic/mythmusic/cddb.h
    M mythplugins/mythmusic/mythmusic/flacencoder.h
    M mythplugins/mythmusic/mythmusic/synaesthesia.h
    M mythplugins/mythmusic/mythmusic/vorbisencoder.h
    M mythplugins/mythnews/mythnews/newssite.h
    M mythplugins/mythweather/mythweather/weatherSetup.h
    M mythplugins/mythweather/mythweather/weatherSource.h
    M mythplugins/mythzoneminder/mythzoneminder/zmdefines.h

  Log Message:
  -----------
  tidy: Initialize member fields in constructor. (plugins)

The clang-tidy "member initialization" checker pointed out a number of
classes where member variables were not initialized in the
constructor.  Add initializers for these member variables.

https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines-pro-type-member-init.html

  Commit: 3f37d4804b76880bd2099c6a4cb9bc2d0efdd3ba
      https://github.com/MythTV/mythtv/commit/3f37d4804b76880bd2099c6a4cb9bc2d0efdd3ba
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-01-10 (Fri, 10 Jan 2020)

  Changed paths:
    M mythtv/programs/mythbackend/mainserver.h
    M mythtv/programs/mythcommflag/CannyEdgeDetector.h
    M mythtv/programs/mythcommflag/CustomEventRelayer.h
    M mythtv/programs/mythfrontend/guidegrid.cpp
    M mythtv/programs/mythfrontend/playbackbox.h
    M mythtv/programs/mythfrontend/statusbox.cpp
    M mythtv/programs/mythtranscode/mpeg2fix.cpp
    M mythtv/programs/mythtranscode/mpeg2fix.h
    M mythtv/programs/mythtranscode/transcode.cpp
    M mythtv/programs/mythtranscode/videodecodebuffer.cpp
    M mythtv/programs/mythutil/mpegutils.cpp

  Log Message:
  -----------
  tidy: Initialize member fields in constructor. (programs)

The clang-tidy "member initialization" checker pointed out a number of
classes where member variables were not initialized in the
constructor.  Add initializers for these member variables.

https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines-pro-type-member-init.html

  Commit: 8e70b50643611fac80521e6c638aef67dbfabc41
      https://github.com/MythTV/mythtv/commit/8e70b50643611fac80521e6c638aef67dbfabc41
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-01-10 (Fri, 10 Jan 2020)

  Changed paths:
    M .clang-tidy
    M mythtv/libs/libmyth/audio/audiooutputalsa.cpp
    M mythtv/libs/libmyth/audio/audiooutputalsa.h
    M mythtv/libs/libmyth/audio/audiooutputjack.h
    M mythtv/libs/libmyth/audio/eldutils.h
    M mythtv/libs/libmyth/mythmediamonitor.h
    M mythtv/libs/libmyth/rssparse.h
    M mythtv/libs/libmythbase/mythcdrom.cpp
    M mythtv/libs/libmythbase/mythdbcon.h
    M mythtv/libs/libmythbase/signalhandling.cpp
    M mythtv/libs/libmythbase/verbosedefs.h
    M mythtv/libs/libmythbase/zipentry_p.h
    M mythtv/libs/libmythfreemheg/BaseClasses.h
    M mythtv/libs/libmythfreemheg/Groups.h
    M mythtv/libs/libmythfreesurround/el_processor.cpp
    M mythtv/libs/libmythmetadata/dbaccess.h
    M mythtv/libs/libmythmetadata/musicmetadata.h
    M mythtv/libs/libmythmetadata/videoscan.h
    M mythtv/libs/libmythtv/AirPlay/mythraopconnection.h
    M mythtv/libs/libmythtv/HLS/httplivestreambuffer.cpp
    M mythtv/libs/libmythtv/cc708decoder.h
    M mythtv/libs/libmythtv/cc708reader.h
    M mythtv/libs/libmythtv/cc708window.h
    M mythtv/libs/libmythtv/channelscan/channelimporter.h
    M mythtv/libs/libmythtv/decoders/decoderbase.cpp
    M mythtv/libs/libmythtv/decoders/decoderbase.h
    M mythtv/libs/libmythtv/decoders/mythv4l2m2mcontext.cpp
    M mythtv/libs/libmythtv/decoders/nuppeldecoder.h
    M mythtv/libs/libmythtv/iptvtuningdata.h
    M mythtv/libs/libmythtv/jobqueue.h
    M mythtv/libs/libmythtv/livetvchain.h
    M mythtv/libs/libmythtv/metadataimagehelper.h
    M mythtv/libs/libmythtv/mheg/dsmccbiop.h
    M mythtv/libs/libmythtv/mheg/mhi.cpp
    M mythtv/libs/libmythtv/mpeg/dvbdescriptors.h
    M mythtv/libs/libmythtv/mpeg/dvbtables.h
    M mythtv/libs/libmythtv/mpeg/pespacket.h
    M mythtv/libs/libmythtv/mpeg/splicedescriptors.h
    M mythtv/libs/libmythtv/mpeg/tspacket.h
    M mythtv/libs/libmythtv/mythavutil.cpp
    M mythtv/libs/libmythtv/mythccextractorplayer.h
    M mythtv/libs/libmythtv/mythframe.h
    M mythtv/libs/libmythtv/mythvideooutnull.h
    M mythtv/libs/libmythtv/opengl/mythvaapidrminterop.cpp
    M mythtv/libs/libmythtv/recorders/NuppelVideoRecorder.cpp
    M mythtv/libs/libmythtv/recorders/NuppelVideoRecorder.h
    M mythtv/libs/libmythtv/recorders/avcinfo.h
    M mythtv/libs/libmythtv/recorders/dtvrecorder.h
    M mythtv/libs/libmythtv/recorders/dvbdev/dvbci.h
    M mythtv/libs/libmythtv/recorders/linuxfirewiredevice.cpp
    M mythtv/libs/libmythtv/recorders/rtp/rtcpdatapacket.h
    M mythtv/libs/libmythtv/teletextreader.h
    M mythtv/libs/libmythtv/test/test_copyframes/test_copyframes.h
    M mythtv/libs/libmythtv/textsubtitleparser.cpp
    M mythtv/libs/libmythtv/tv_play.h
    M mythtv/libs/libmythtv/tvremoteutil.h
    M mythtv/libs/libmythtv/videocolourspace.cpp
    M mythtv/libs/libmythtv/videosource.h
    M mythtv/libs/libmythui/mythmainwindow.cpp
    M mythtv/libs/libmythui/myththemedmenu.h
    M mythtv/libs/libmythui/mythvirtualkeyboard.h
    M mythtv/libs/libmythui/opengl/mythrenderopengl.h
    M mythtv/libs/libmythupnp/eventing.h
    M mythtv/libs/libmythupnp/servicehost.h

  Log Message:
  -----------
  tidy: Initialize member fields in constructor. (libs)

The clang-tidy "member initialization" checker pointed out a number of
classes where member variables were not initialized in the
constructor.  Add initializers for these member variables.

https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines-pro-type-member-init.html

  Commit: 5ec649f7d29aa1840f19b97ac05e4c467893a284
      https://github.com/MythTV/mythtv/commit/5ec649f7d29aa1840f19b97ac05e4c467893a284
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-01-10 (Fri, 10 Jan 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mheg/dsmccobjcarousel.cpp

  Log Message:
  -----------
  Fix recently introduced crash in MHEG.

The automatic clang-tidy loop modernize-loop-convert changes caused a
situation where while walking an array the current item was set to
null before it was processed.  Move this assignment to the end of the
loop.

Fixes #13551.

  Commit: 908abc998b5477e5a8646fa0f9a881a935f7db50
      https://github.com/MythTV/mythtv/commit/908abc998b5477e5a8646fa0f9a881a935f7db50
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-01-10 (Fri, 10 Jan 2020)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/channelscan_sm.cpp
    M mythtv/libs/libmythtv/channelscan/channelscan_sm.h
    M mythtv/libs/libmythtv/channelscan/channelscanmiscsettings.h
    M mythtv/libs/libmythtv/channelscan/channelscanner.cpp
    M mythtv/libs/libmythtv/channelscan/channelscanner.h
    M mythtv/libs/libmythtv/channelscan/scanwizardconfig.cpp
    M mythtv/libs/libmythtv/channelscan/scanwizardconfig.h
    M mythtv/libs/libmythtv/decoders/mythv4l2m2mcontext.cpp
    M mythtv/libs/libmythtv/mpeg/dvbdescriptors.cpp
    M mythtv/libs/libmythtv/mpeg/dvbdescriptors.h
    M mythtv/libs/libmythtv/mpeg/dvbstreamdata.cpp
    M mythtv/libs/libmythtv/mpeg/mpegdescriptors.cpp
    M mythtv/libs/libmythtv/mpeg/mpegdescriptors.h
    M mythtv/libs/libmythtv/mpeg/mpegtables.h
    M mythtv/libs/libmythtv/mythplayer.cpp
    M mythtv/libs/libmythtv/opengl/mythdrmprimeinterop.cpp
    M mythtv/libs/libmythtv/opengl/mythmediacodecinterop.cpp
    M mythtv/libs/libmythtv/opengl/mythnvdecinterop.cpp
    M mythtv/libs/libmythtv/opengl/mythopenglinterop.cpp
    M mythtv/libs/libmythtv/opengl/mythvaapidrminterop.cpp
    M mythtv/libs/libmythtv/opengl/mythvaapidrminterop.h
    M mythtv/libs/libmythtv/opengl/mythvaapiglxinterop.h
    M mythtv/libs/libmythtv/scanwizard.cpp
    M mythtv/libs/libmythtv/scanwizard.h
    M mythtv/libs/libmythui/mythdisplay.h
    M mythtv/libs/libmythui/mythdisplaymode.cpp
    M mythtv/libs/libmythui/platforms/mythdisplayx11.cpp
    M mythtv/libs/libmythui/platforms/mythxdisplay.cpp
    M mythtv/programs/mythtv-setup/main.cpp

  Log Message:
  -----------
  Two bugfixes and last set of clang-tidy changes for 0.31.

Compare: https://github.com/MythTV/mythtv/compare/16e26e4818d5...908abc998b54