[mythtv-commits] [MythTV/mythtv] ecb6b7: Fix spdif to properly use an allocated buffer.

Fri Aug 7 21:58:25 UTC 2020

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: ecb6b7e49872aee307c109a8ff2b25191a955a95
      https://github.com/MythTV/mythtv/commit/ecb6b7e49872aee307c109a8ff2b25191a955a95
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-08-07 (Fri, 07 Aug 2020)

  Changed paths:
    M mythtv/libs/libmyth/audio/spdifencoder.cpp
    M mythtv/libs/libmyth/audio/spdifencoder.h

  Log Message:
  -----------
  Fix spdif to properly use an allocated buffer.

This code calls avio_alloc_context and passes a fixed buffer into a
parameter whose documentation specifically states that the buffer must
be allocated with av_malloc.  Fix the code to match the documentation.

  Commit: ae00e52d9fe921dd7360801d896425e494c4a262
      https://github.com/MythTV/mythtv/commit/ae00e52d9fe921dd7360801d896425e494c4a262
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-08-07 (Fri, 07 Aug 2020)

  Changed paths:
    M mythtv/libs/libmythtv/io/mythfilebuffer.cpp
    M mythtv/libs/libmythtv/io/mythmediabuffer.cpp
    M mythtv/libs/libmythtv/io/mythmediabuffer.h

  Log Message:
  -----------
  Convert subtitle filename extensions to a compile time list.

  Commit: 3995541054d34e1a8b80a8fbcf311a9977bcf086
      https://github.com/MythTV/mythtv/commit/3995541054d34e1a8b80a8fbcf311a9977bcf086
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-08-07 (Fri, 07 Aug 2020)

  Changed paths:
    M mythtv/libs/libmythtv/captions/xine_demux_sputext.cpp

  Log Message:
  -----------
  xine: Store pointer to parsed subtitles in the demuxstr struct.

This field already exists in the data structure, it just wasn't
populated before. Previously the only pointer to the parsed subtitles
was the one returned by the function.

  Commit: 06e67c3a39dd43348d5f8acd07110a7b00d29354
      https://github.com/MythTV/mythtv/commit/06e67c3a39dd43348d5f8acd07110a7b00d29354
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-08-07 (Fri, 07 Aug 2020)

  Changed paths:
    M mythtv/libs/libmythtv/captions/xine_demux_sputext.cpp

  Log Message:
  -----------
  xine: Two SAMI subtitle fixes.

1) Make the tag parsing fully case insensitive.  2) Fix the check for
a "<br>" tag. It has to come before the generic tag open (aka "<")
check.

  Commit: 68cc6273e28c4be4467cbf885e51ffe94c6f70c8
      https://github.com/MythTV/mythtv/commit/68cc6273e28c4be4467cbf885e51ffe94c6f70c8
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-08-07 (Fri, 07 Aug 2020)

  Changed paths:
    M mythtv/libs/libmythtv/captions/xine_demux_sputext.cpp
    M mythtv/libs/libmythtv/captions/xine_demux_sputext.h

  Log Message:
  -----------
  xine: Remove emptyRead logic from xine.

MythTV always provides the complete contents of the subtitle file to
xine, so this logic to check for incomplete network reads is
unnecessary. The logic actually causes problems for auto-detection, if
the expected keywords aren't found in the first 1000 bytes.

  Commit: e46ce9a9d2773844a789c4ca172e2ee230042fc4
      https://github.com/MythTV/mythtv/commit/e46ce9a9d2773844a789c4ca172e2ee230042fc4
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-08-07 (Fri, 07 Aug 2020)

  Changed paths:
    M mythtv/libs/libmythtv/captions/xine_demux_sputext.cpp

  Log Message:
  -----------
  xine: Detect JACO subtitles.

The sscanf code stops parsing after populating all the supplied
arguments, so its incorrectly detecting JACO subtitles as VPlayer
subtitles. Force sscanf to check the colon character after the third
number be making it parse the rest of the line into another variable.

  Commit: ca8c32b6dad47de1083738a65f531adc3944a259
      https://github.com/MythTV/mythtv/commit/ca8c32b6dad47de1083738a65f531adc3944a259
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-08-07 (Fri, 07 Aug 2020)

  Changed paths:
    M mythtv/libs/libmythtv/captions/xine_demux_sputext.cpp

  Log Message:
  -----------
  xine: Support continuation lines in JACO subtitles.

  Commit: b266993e83643c67d99319594f7d552af311214b
      https://github.com/MythTV/mythtv/commit/b266993e83643c67d99319594f7d552af311214b
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-08-07 (Fri, 07 Aug 2020)

  Changed paths:
    M mythtv/libs/libmythtv/captions/xine_demux_sputext.cpp

  Log Message:
  -----------
  xine: Recognize RealText subtitle files.

  Commit: d76fec6f7746c24a8561d986336f9fb0aeed1217
      https://github.com/MythTV/mythtv/commit/d76fec6f7746c24a8561d986336f9fb0aeed1217
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-08-07 (Fri, 07 Aug 2020)

  Changed paths:
    M mythtv/libs/libmythtv/captions/xine_demux_sputext.cpp

  Log Message:
  -----------
  xine: Don't eat the last MPSUB subtitle.

Also remove a debugging message.

  Commit: 9eeec6daeec1cfc4e7275d78f295ffdf8a34fac3
      https://github.com/MythTV/mythtv/commit/9eeec6daeec1cfc4e7275d78f295ffdf8a34fac3
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-08-07 (Fri, 07 Aug 2020)

  Changed paths:
    M mythtv/libs/libmythtv/captions/xine_demux_sputext.cpp
    M mythtv/libs/libmythtv/captions/xine_demux_sputext.h

  Log Message:
  -----------
  xine: Move subtitle format constants to the header file.

  Commit: 4ab6afc08a4fd2c0e795b0cacdaac1e00974ede5
      https://github.com/MythTV/mythtv/commit/4ab6afc08a4fd2c0e795b0cacdaac1e00974ede5
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-08-07 (Fri, 07 Aug 2020)

  Changed paths:
    M mythtv/libs/libmythtv/captions/xine_demux_sputext.cpp

  Log Message:
  -----------
  xine: Turn off debugging.

  Commit: 08b4ddcc3ee3cec2221d5d5349d90fc94f5a833d
      https://github.com/MythTV/mythtv/commit/08b4ddcc3ee3cec2221d5d5349d90fc94f5a833d
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-08-07 (Fri, 07 Aug 2020)

  Changed paths:
    A mythtv/libs/libmythtv/test/test_xine_demux/.gitignore
    A mythtv/libs/libmythtv/test/test_xine_demux/samples/advancedssa.ass
    A mythtv/libs/libmythtv/test/test_xine_demux/samples/aqtitles.aqt.sub
    A mythtv/libs/libmythtv/test/test_xine_demux/samples/jaco.sub
    A mythtv/libs/libmythtv/test/test_xine_demux/samples/microdvd.sub
    A mythtv/libs/libmythtv/test/test_xine_demux/samples/mpl2.mpl.sub
    A mythtv/libs/libmythtv/test/test_xine_demux/samples/mpsub.sub
    A mythtv/libs/libmythtv/test/test_xine_demux/samples/phoenixjapanimationsociety.pjs
    A mythtv/libs/libmythtv/test/test_xine_demux/samples/realtext.txt
    A mythtv/libs/libmythtv/test/test_xine_demux/samples/sami.smi
    A mythtv/libs/libmythtv/test/test_xine_demux/samples/subrip.srt
    A mythtv/libs/libmythtv/test/test_xine_demux/samples/subrip09.srt
    A mythtv/libs/libmythtv/test/test_xine_demux/samples/substationalpha.v3.ssa
    A mythtv/libs/libmythtv/test/test_xine_demux/samples/substationalpha.v4.ssa
    A mythtv/libs/libmythtv/test/test_xine_demux/samples/subviewer.sub
    A mythtv/libs/libmythtv/test/test_xine_demux/samples/subviewer2.sub
    A mythtv/libs/libmythtv/test/test_xine_demux/samples/vplayer.txt
    A mythtv/libs/libmythtv/test/test_xine_demux/test_xine_demux.cpp
    A mythtv/libs/libmythtv/test/test_xine_demux/test_xine_demux.h
    A mythtv/libs/libmythtv/test/test_xine_demux/test_xine_demux.pro

  Log Message:
  -----------
  Add testing of the xine subtitle reader.

  Commit: 28d96fec8c4daf1cec1521501e4e9be5aed60648
      https://github.com/MythTV/mythtv/commit/28d96fec8c4daf1cec1521501e4e9be5aed60648
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-08-07 (Fri, 07 Aug 2020)

  Changed paths:
    M mythtv/libs/libmythui/libmythui.pro

  Log Message:
  -----------
  Add missing library linkages on FreeBSD.

I have no idea why this stopped working in the last week (maybe
something in an OS upgrade) but explicitly stating these library names
on the link line makes compiles work again.

Compare: https://github.com/MythTV/mythtv/compare/00a94e00c199...28d96fec8c4d