[mythtv-commits] [MythTV/mythtv] 917a20: Fix segfault in code called from MythMainWindow::D...

[linuxdude42]

  Branch: refs/heads/fixes/31
  Home:   https://github.com/MythTV/mythtv
  Commit: 917a2087ef032b2c36a102cf4a2b220e10bf7bfe
      https://github.com/MythTV/mythtv/commit/917a2087ef032b2c36a102cf4a2b220e10bf7bfe
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-04-21 (Tue, 21 Apr 2020)

  Changed paths:
    M mythtv/libs/libmythui/mythmainwindow.cpp

  Log Message:
  -----------
  Fix segfault in code called from MythMainWindow::Draw.

This reverts three of the changes in 380102ce34.  In
mythmainwindow.cpp while running the m_stackList, the call to
MythScreenStack::GetDrawOrder can apparently modify m_stackList or
something that it points to.  Reverting the range-based for loops and
restoring the original for loops prevents the crash.

Fixes #13613.


  Commit: 5f1993304e35042192aed059dd7cf8717b76c6a7
      https://github.com/MythTV/mythtv/commit/5f1993304e35042192aed059dd7cf8717b76c6a7
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-04-21 (Tue, 21 Apr 2020)

  Changed paths:
    M mythtv/libs/libmythupnp/upnphelpers.cpp

  Log Message:
  -----------
  Fix incorrect data provided to UPnP client.

This bug was introduced in 77b560f3cc when converting from the
obsolete QString::sprintf function to typical QString formatting using
QString::arg.  In one case the arguments were all converted, but the
format string wasn't .  Fix that format string.

Fixes #13612.


Compare: https://github.com/MythTV/mythtv/compare/8bfc909dc70e...5f1993304e35