[mythtv-commits] [MythTV/mythtv] a465f1: Use const_iterator for QMap m_encoderList

kmdewaal noreply at github.com
Tue Apr 7 20:52:30 UTC 2020


  Branch: refs/heads/fixes/31
  Home:   https://github.com/MythTV/mythtv
  Commit: a465f1b03d505b0038ba5d40b11bb10039454733
      https://github.com/MythTV/mythtv/commit/a465f1b03d505b0038ba5d40b11bb10039454733
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2020-04-07 (Tue, 07 Apr 2020)

  Changed paths:
    M mythtv/programs/mythbackend/autoexpire.cpp
    M mythtv/programs/mythbackend/mainserver.cpp
    M mythtv/programs/mythbackend/scheduler.cpp

  Log Message:
  -----------
  Use const_iterator for QMap m_encoderList

Use const_iterator, constBegin, constEnd and constFind while accessing
the tvList and pointers to the tvList such as m_encoderList and m_tvList.
This fixes the problem of crashing while deleting a recording.
When deleting, the m_encoderList is accessed by more than one thread.
The QMap is documented to be re-entrant but this appears to be only the case
when the QMap is accessed with the const variants of the member functions.

Fixes #13571

(cherry picked from commit 4192aab4d31301596b506c47507e8c3d872cc18f)
Signed-off-by: Klaas de Waal <kdewaal at mythtv.org>




More information about the mythtv-commits mailing list