[mythtv-commits] Ticket #13489: Fix TestIPTVRecorder after change to IPTVChannelInfo

[MythTV]

#13489: Fix TestIPTVRecorder after change to IPTVChannelInfo
-------------------------------------+-----------------------------
 Reporter:  ijc                      |          Owner:  paul-h
     Type:  Patch - Bug Fix          |         Status:  closed
 Priority:  blocker                  |      Milestone:  31.0
Component:  MythTV - HTTP Streaming  |        Version:  Master Head
 Severity:  high                     |     Resolution:  Fixed
 Keywords:                           |  Ticket locked:  0
-------------------------------------+-----------------------------
Changes (by paul-h):

 * status:  accepted => closed
 * resolution:   => Fixed


Comment:

 In [changeset:"36d96c956969a85feb8578f0cbe2cc42fee01016/mythtv"
  36d96c956/mythtv]:
  {{{
  #!CommitTicketReference repository="mythtv"
  revision="36d96c956969a85feb8578f0cbe2cc42fee01016"
  Fix TestIPTVRecorder after change to IPTVChannelInfo

  In a60e7429a09a ("IPTVChannelInfo: explictly set IPTVTuningData protocol
  to
  invalid") I removed `IPTVChannelInfo::IsValid()` thinking it was unused
  but
  missed the uses in these test cases. Reintroduce the method, but make it
  `protected` and a friend of the `TestIPTVRecorder` class.

  The above change also changed the behaviour of `IPTVChannelInfo`'s
  constructors
  such that the protocol is not always probed, and therefore `IsValid()` is
  not
  necessarily true. This is the case when constructed via
  `IPTVChannelFetcher::ParsePlayList`. Update
  `TestIPTVRecorder::ParseChanInfo` to
  reflect this by now asserting that the tuning data is not valid and that
  the
  protocol is `inValid` as expected.

  Refs #13488

  Signed-off-by: Paul Harrison <pharrison at mythtv.org>
  }}}

-- 
Ticket URL: <https://code.mythtv.org/trac/ticket/13489#comment:2>
MythTV <http://www.mythtv.org>
MythTV Media Center