[mythtv-commits] Ticket #13488: IPTV fix for deadlock, handle redirects

MythTV noreply at mythtv.org
Mon Oct 7 09:07:18 UTC 2019

#13488: IPTV fix for deadlock, handle redirects
 Reporter:  ijc                      |          Owner:  paul-h
     Type:  Patch - Bug Fix          |         Status:  accepted
 Priority:  minor                    |      Milestone:  31.0
Component:  MythTV - HTTP Streaming  |        Version:  Master Head
 Severity:  medium                   |     Resolution:
 Keywords:                           |  Ticket locked:  0

Comment (by Ian Campbell <ijc@…>):

 In [changeset:"36d96c956969a85feb8578f0cbe2cc42fee01016/mythtv"
 #!CommitTicketReference repository="mythtv"
 Fix TestIPTVRecorder after change to IPTVChannelInfo

 In a60e7429a09a ("IPTVChannelInfo: explictly set IPTVTuningData protocol
 invalid") I removed `IPTVChannelInfo::IsValid()` thinking it was unused
 missed the uses in these test cases. Reintroduce the method, but make it
 `protected` and a friend of the `TestIPTVRecorder` class.

 The above change also changed the behaviour of `IPTVChannelInfo`'s
 such that the protocol is not always probed, and therefore `IsValid()` is
 necessarily true. This is the case when constructed via
 `IPTVChannelFetcher::ParsePlayList`. Update
 `TestIPTVRecorder::ParseChanInfo` to
 reflect this by now asserting that the tuning data is not valid and that
 protocol is `inValid` as expected.

 Refs #13488

 Signed-off-by: Paul Harrison <pharrison at mythtv.org>

Ticket URL: <https://code.mythtv.org/trac/ticket/13488#comment:14>
MythTV <http://www.mythtv.org>
MythTV Media Center

More information about the mythtv-commits mailing list