[mythtv-commits] Ticket #13489: Fix TestIPTVRecorder after change to IPTVChannelInfo

MythTV noreply at mythtv.org
Sun Oct 6 08:42:55 UTC 2019

#13489: Fix TestIPTVRecorder after change to IPTVChannelInfo
     Reporter:  ijc                      |      Owner:  cpinkham
         Type:  Patch - Bug Fix          |     Status:  new
     Priority:  blocker                  |  Milestone:  needs_triage
    Component:  MythTV - HTTP Streaming  |    Version:  Master Head
     Severity:  high                     |   Keywords:
Ticket locked:  0                        |
 My patches in https://code.mythtv.org/trac/ticket/13488 broke the related
 unit tests. My apologies.

 Attached is the fix (also pushed to

 Commit message for reference:

     Fix TestIPTVRecorder after change to IPTVChannelInfo

     In a60e7429a09a ("IPTVChannelInfo: explictly set IPTVTuningData
 protocol to
     invalid") I removed `IPTVChannelInfo::IsValid()` thinking it was
 unused but
     missed the uses in these test cases. Reintroduce the method, but make
     `protected` and a friend of the `TestIPTVRecorder` class.

     The above change also changed the behaviour of `IPTVChannelInfo`'s
     such that the protocol is not always probed, and therefore `IsValid()`
 is not
     necessarily true. This is the case when constructed via
     `IPTVChannelFetcher::ParsePlayList`. Update
 `TestIPTVRecorder::ParseChanInfo` to
     reflect this by now asserting that the tuning data is not valid and
 that the
     protocol is `inValid` as expected.

Ticket URL: <https://code.mythtv.org/trac/ticket/13489>
MythTV <http://www.mythtv.org>
MythTV Media Center

More information about the mythtv-commits mailing list