[mythtv-commits] Ticket #13526: Feature patch - Ansible cleanup of (now) unused legacy lame variables

MythTV noreply at mythtv.org
Thu Nov 28 09:32:03 UTC 2019


#13526: Feature patch - Ansible cleanup of (now) unused legacy lame variables
---------------------------------+---------------------------------
     Reporter:  Gary Buhrmaster  |      Owner:  Stuart Auchterlonie
         Type:  Patch - Feature  |     Status:  new
     Priority:  minor            |  Milestone:  needs_triage
    Component:  Ansible          |    Version:  Master Head
     Severity:  medium           |   Keywords:
Ticket locked:  0                |
---------------------------------+---------------------------------
 Feature patch - Ansible cleanup of unused legacy lame variables

 In 63b454726bf6d4d260d3757ed6c0acb1c4604e5a lame builds were removed from
 the rpm/dnf tasks,but the variables used for those tasks remained.

 Remove the (now) unused variables.

 Proposed patch:

 {{{
 diff --git a/roles/mythtv-dnf/vars/main.yml b/roles/mythtv-
 dnf/vars/main.yml
 index e025e15..61f3ab6 100644
 --- a/roles/mythtv-dnf/vars/main.yml
 +++ b/roles/mythtv-dnf/vars/main.yml
 @@ -6,6 +6,3 @@ rpmfusion_rpm: "http://download1.rpmfusion.org/free/fedora
 /rpmfusion-free-releas
  rpmfusion_rawhide_rpm: "http://download1.rpmfusion.org/free/fedora
 /rpmfusion-free-release-rawhide.noarch.rpm"
  rpmfusion_el_rpm: "https://download1.rpmfusion.org/free/el/rpmfusion-
 free-release-{{ ansible_distribution_major_version }}.noarch.rpm"

 -lame_src: "
 http://download1.rpmfusion.org/free/el/updates/6/SRPMS/lame-3.99.5-1.el6.src.rpm"
 -lame_rpm:
 "~/rpmbuild/RPMS/{{ansible_architecture}}/lame-3.99.5-1.el7.centos.{{ansible_architecture}}.rpm"
 -lame_rpms_all:
 "~/rpmbuild/RPMS/{{ansible_architecture}}/lame-3.99.5-1.el7.centos.{{ansible_architecture}}.rpm
 ~/rpmbuild/RPMS/{{ansible_architecture}}/lame-
 libs-3.99.5-1.el7.centos.{{ansible_architecture}}.rpm
 ~/rpmbuild/RPMS/{{ansible_architecture}}/lame-
 devel-3.99.5-1.el7.centos.{{ansible_architecture}}.rpm"
 diff --git a/roles/mythtv-rpm/vars/main.yml b/roles/mythtv-
 rpm/vars/main.yml
 index c8fc772..4f863f6 100644
 --- a/roles/mythtv-rpm/vars/main.yml
 +++ b/roles/mythtv-rpm/vars/main.yml
 @@ -4,6 +4,3 @@ epel_rpm: "https://dl.fedoraproject.org/pub/epel/epel-
 release-latest-7.noarch.rp

  rpmfusion_rpm: "http://download1.rpmfusion.org/free/fedora/rpmfusion-
 free-release-{{ ansible_distribution_major_version }}.noarch.rpm"

 -lame_src: "
 http://download1.rpmfusion.org/free/el/updates/6/SRPMS/lame-3.99.5-1.el6.src.rpm"
 -lame_rpm:
 "~/rpmbuild/RPMS/{{ansible_architecture}}/lame-3.99.5-1.el7.centos.{{ansible_architecture}}.rpm"
 -lame_rpms_all:
 "~/rpmbuild/RPMS/{{ansible_architecture}}/lame-3.99.5-1.el7.centos.{{ansible_architecture}}.rpm
 ~/rpmbuild/RPMS/{{ansible_architecture}}/lame-
 libs-3.99.5-1.el7.centos.{{ansible_architecture}}.rpm
 ~/rpmbuild/RPMS/{{ansible_architecture}}/lame-
 devel-3.99.5-1.el7.centos.{{ansible_architecture}}.rpm"
 }}}

-- 
Ticket URL: <https://code.mythtv.org/trac/ticket/13526>
MythTV <http://www.mythtv.org>
MythTV Media Center


More information about the mythtv-commits mailing list