[mythtv-commits] Ticket #13521: videosource table userid cannot be set to NULL

[MythTV]

#13521: videosource table userid cannot be set to NULL
----------------------------------+--------------------------
     Reporter:  Gary Buhrmaster   |      Owner:  (none)
         Type:  Patch - Bug Fix   |     Status:  new
     Priority:  minor             |  Milestone:  needs_triage
    Component:  MythTV - General  |    Version:  Master Head
     Severity:  medium            |   Keywords:
Ticket locked:  0                 |
----------------------------------+--------------------------
 While looking at something else, I noticed that in videosource.cpp there
 is a sql statement that is not correct.  Userid, in the videosource table,
 is created as NOT NULL.

 The failure can probably produce noise in the mythtv-setup logs when one
 configures videosources, but it is (highly) likely that almost no one
 looks at the logs from running mythtv-setup unless something really bad
 happened.

 Completely untested.

 Proposed patch:

 {{{
 diff --git a/mythtv/libs/libmythtv/videosource.cpp
 b/mythtv/libs/libmythtv/videosource.cpp
 index d599fd1761..55afc1d512 100644
 --- a/mythtv/libs/libmythtv/videosource.cpp
 +++ b/mythtv/libs/libmythtv/videosource.cpp
 @@ -296,7 +296,7 @@ class XMLTVGrabber : public MythUIComboBoxSetting
          MSqlQuery query(MSqlQuery::InitCon());
          query.prepare(
              "UPDATE videosource "
 -            "SET userid=NULL, password=NULL "
 +            "SET userid='', password=NULL "
              "WHERE xmltvgrabber NOT IN ( 'technovera' )");
          if (!query.exec())
              MythDB::DBError("XMLTVGrabber::Save", query);
 }}}

-- 
Ticket URL: <https://code.mythtv.org/trac/ticket/13521>
MythTV <http://www.mythtv.org>
MythTV Media Center