[mythtv-commits] [MythTV/mythtv] 13a2bd: Fix bug in commit 9749e34efc which caused missed r...

linuxdude42 noreply at github.com
Wed Mar 13 15:35:52 UTC 2019


  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 13a2bd36ea3b48f017962e1836b3ce5c410cd0f2
      https://github.com/MythTV/mythtv/commit/13a2bd36ea3b48f017962e1836b3ce5c410cd0f2
  Author: David Engel <dengel at mythtv.org>
  Date:   2019-02-27 (Wed, 27 Feb 2019)

  Changed paths:
    M mythtv/libs/libmythtv/recordinginfo.cpp

  Log Message:
  -----------
  Fix bug in commit 9749e34efc which caused missed recordings.

There was confusion between a member variable and function parameter.


  Commit: 6fae9af7e3dcb1297f93f8ad46748eb6d0cc8b4e
      https://github.com/MythTV/mythtv/commit/6fae9af7e3dcb1297f93f8ad46748eb6d0cc8b4e
  Author: Klaas de Waal <klaas.de.waal at gmail.com>
  Date:   2019-02-27 (Wed, 27 Feb 2019)

  Changed paths:
    M mythtv/libs/libmythbase/threadedfilewriter.h

  Log Message:
  -----------
  Fix missing initialization of variable.

Fixes #13412.

Signed-off-by: David Hampton <mythtv at love2code.net>


  Commit: 4bb310bef69fe04c7c5d64797821adb860e883c9
      https://github.com/MythTV/mythtv/commit/4bb310bef69fe04c7c5d64797821adb860e883c9
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-02-27 (Wed, 27 Feb 2019)

  Changed paths:
    M mythtv/programs/mythfrontend/themechooser.h

  Log Message:
  -----------
  Fix initialization of ThemeChooser::m_downloadState.

Fixes coverity issue 1442853.


  Commit: 5b3f308fd0ed70639dc997270b277797fb7e40dd
      https://github.com/MythTV/mythtv/commit/5b3f308fd0ed70639dc997270b277797fb7e40dd
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-02-27 (Wed, 27 Feb 2019)

  Changed paths:
    M mythplugins/mytharchive/mytharchive/archivesettings.cpp
    M mythplugins/mythmusic/mythmusic/pls.cpp
    M mythtv/libs/libmyth/output.h
    M mythtv/libs/libmythbase/codecutil.cpp
    M mythtv/libs/libmythbase/hardwareprofile.cpp
    M mythtv/libs/libmythbase/hardwareprofile.h
    M mythtv/libs/libmythbase/iso639.cpp
    M mythtv/libs/libmythbase/iso639.h
    M mythtv/libs/libmythbase/mythcommandlineparser.h
    M mythtv/libs/libmythbase/mythcorecontext.h
    M mythtv/libs/libmythbase/mythdbcon.cpp
    M mythtv/libs/libmythbase/mythdbcon.h
    M mythtv/libs/libmythbase/mythlocale.cpp
    M mythtv/libs/libmythbase/mythlocale.h
    M mythtv/libs/libmythbase/mythobservable.h
    M mythtv/libs/libmythbase/mythsorthelper.cpp
    M mythtv/libs/libmythbase/mythsorthelper.h
    M mythtv/libs/libmythbase/mythstorage.cpp
    M mythtv/libs/libmythbase/mythstorage.h
    M mythtv/libs/libmythbase/mythsystem.cpp
    M mythtv/libs/libmythbase/portchecker.cpp
    M mythtv/libs/libmythservicecontracts/service.h
    M mythtv/libs/libmythtv/avfringbuffer.h
    M mythtv/libs/libmythtv/channelscan/channelscan_sm.cpp
    M mythtv/libs/libmythtv/channelscan/externrecscanner.h
    M mythtv/libs/libmythtv/channelsettings.cpp
    M mythtv/libs/libmythtv/channelutil.cpp
    R mythtv/libs/libmythtv/datadirect.cpp
    R mythtv/libs/libmythtv/datadirect.h
    M mythtv/libs/libmythtv/dbcheck.cpp
    M mythtv/libs/libmythtv/libmythtv.pro
    M mythtv/libs/libmythtv/mpeg/mpegtables.h
    M mythtv/libs/libmythtv/mythplayer.cpp
    M mythtv/libs/libmythtv/mythplayer.h
    M mythtv/libs/libmythtv/recorders/ExternalStreamHandler.cpp
    M mythtv/libs/libmythtv/recorders/RTjpegN.cpp
    M mythtv/libs/libmythtv/recorders/cetonrtsp.cpp
    M mythtv/libs/libmythtv/recordingrule.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tv_play.h
    M mythtv/libs/libmythtv/tv_rec.cpp
    M mythtv/libs/libmythtv/videosource.cpp
    M mythtv/libs/libmythtv/videosource.h
    M mythtv/libs/libmythui/AppleRemote.h
    M mythtv/libs/libmythui/mythuiguidegrid.cpp
    M mythtv/libs/libmythui/screensaver-android.h
    M mythtv/libs/libmythui/screensaver-dbus.cpp
    M mythtv/libs/libmythui/screensaver-osx.h
    M mythtv/libs/libmythupnp/ssdpcache.h
    M mythtv/libs/libmythupnp/upnpsubscription.h
    M mythtv/programs/mythbackend/backendhousekeeper.cpp
    M mythtv/programs/mythbackend/httpstatus.cpp
    M mythtv/programs/mythbackend/scheduler.cpp
    M mythtv/programs/mythbackend/services/channel.cpp
    M mythtv/programs/mythbackend/services/channel.h
    M mythtv/programs/mythexternrecorder/MythExternRecApp.cpp
    M mythtv/programs/mythexternrecorder/MythExternRecApp.h
    M mythtv/programs/mythexternrecorder/external-ffmpeg.conf
    M mythtv/programs/mythexternrecorder/external-twitch.conf
    M mythtv/programs/mythexternrecorder/external-vlc.conf
    M mythtv/programs/mythexternrecorder/main.cpp
    M mythtv/programs/mythfilldatabase/channeldata.cpp
    M mythtv/programs/mythfilldatabase/channeldata.h
    M mythtv/programs/mythfilldatabase/commandlineparser.cpp
    M mythtv/programs/mythfilldatabase/filldata.cpp
    M mythtv/programs/mythfilldatabase/filldata.h
    M mythtv/programs/mythfilldatabase/main.cpp
    M mythtv/programs/mythfrontend/customedit.cpp
    M mythtv/programs/mythfrontend/statusbox.cpp
    M mythtv/programs/mythtv-setup/backendsettings.cpp
    M mythtv/programs/mythtv-setup/checksetup.cpp
    M mythtv/programs/scripts/unittests.sh

  Log Message:
  -----------
  Merge master branch into class member names/initialization branch.


  Commit: 2147d6cefb057c57fb7da10e74580a07a66c68d2
      https://github.com/MythTV/mythtv/commit/2147d6cefb057c57fb7da10e74580a07a66c68d2
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-03-12 (Tue, 12 Mar 2019)

  Changed paths:
    M mythtv/libs/libmythtv/frequencytables.cpp
    M mythtv/libs/libmythtv/recorders/rtp/rtcpdatapacket.h

  Log Message:
  -----------
  Remove 'm_' from a couple of local variable names.


  Commit: d88d9432f35e68e10df7cc9bea465614d2fa0c5d
      https://github.com/MythTV/mythtv/commit/d88d9432f35e68e10df7cc9bea465614d2fa0c5d
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-03-13 (Wed, 13 Mar 2019)

  Changed paths:
    M mythtv/libs/libmythtv/Bluray/mythbdplayer.cpp
    M mythtv/libs/libmythtv/DVD/mythdvdplayer.cpp
    M mythtv/libs/libmythtv/commbreakmap.cpp
    M mythtv/libs/libmythtv/deletemap.cpp
    M mythtv/libs/libmythtv/mythccextractorplayer.cpp
    M mythtv/libs/libmythtv/mythcommflagplayer.cpp
    M mythtv/libs/libmythtv/mythplayer.cpp
    M mythtv/libs/libmythtv/playercontext.cpp
    M mythtv/libs/libmythtv/playercontext.h
    M mythtv/libs/libmythtv/previewgenerator.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tvbrowsehelper.cpp
    M mythtv/programs/mythtranscode/transcode.h

  Log Message:
  -----------
  Use c++11 initialization.  Use m_ for class member names. (libmythtv 1/7)

Convert classes to use use the new c++11 brace initialization style.
Also update class member names (when needed) so that all member names
start with 'm_'.  This makes it easy to distinguish class members.


  Commit: 1c2a6e352d2f678484faaf440b43d7cd5efc057a
      https://github.com/MythTV/mythtv/commit/1c2a6e352d2f678484faaf440b43d7cd5efc057a
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-03-13 (Wed, 13 Mar 2019)

  Changed paths:
    M mythtv/libs/libmythtv/eitfixup.cpp
    M mythtv/libs/libmythtv/eithelper.cpp
    M mythtv/libs/libmythtv/playgroup.h
    M mythtv/libs/libmythtv/programdata.cpp
    M mythtv/libs/libmythtv/programdata.h
    M mythtv/libs/libmythtv/test/test_eitfixups/test_eitfixups.cpp
    M mythtv/programs/mythfilldatabase/xmltvparser.cpp

  Log Message:
  -----------
  Use c++11 initialization.  Use m_ for class member names. (libmythtv 2/7)

Convert classes to use use the new c++11 brace initialization style.
Also update class member names (when needed) so that all member names
start with 'm_'.  This makes it easy to distinguish class members.


  Commit: 19a51cb4052152e5429962f6ee65e2f6dc4592bb
      https://github.com/MythTV/mythtv/commit/19a51cb4052152e5429962f6ee65e2f6dc4592bb
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-03-13 (Wed, 13 Mar 2019)

  Changed paths:
    M mythtv/libs/libmythbase/mythdbcon.cpp
    M mythtv/libs/libmythbase/mythdbcon.h
    M mythtv/libs/libmythtv/channelinfo.cpp

  Log Message:
  -----------
  Catch and fix uninitialized QStrings passed to SQL code.

Most of Qt5 treats an uninitialized string and an empty string as the
same thing.  QSqlQuery doesn't, storing NULL for the former and "" for
the latter.  Add a new function for storing a non-null database field
that will store both of these QStrings as "".

Fixes #13420


  Commit: bbab5e5957753762da05de9464b79356ecdb6ef1
      https://github.com/MythTV/mythtv/commit/bbab5e5957753762da05de9464b79356ecdb6ef1
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-03-13 (Wed, 13 Mar 2019)

  Changed paths:
    M mythtv/libs/libmythtv/previewgenerator.cpp
    M mythtv/libs/libmythtv/previewgenerator.h
    M mythtv/libs/libmythtv/previewgeneratorqueue.cpp
    M mythtv/libs/libmythtv/previewgeneratorqueue.h
    M mythtv/libs/libmythtv/profilegroup.cpp
    M mythtv/libs/libmythtv/profilegroup.h
    M mythtv/libs/libmythtv/recordingfile.cpp
    M mythtv/libs/libmythtv/recordingfile.h
    M mythtv/libs/libmythtv/recordingprofile.cpp
    M mythtv/libs/libmythtv/recordingprofile.h
    M mythtv/libs/libmythtv/recordingquality.cpp
    M mythtv/libs/libmythtv/recordingquality.h
    M mythtv/libs/libmythtv/recordingrule.cpp
    M mythtv/libs/libmythtv/recordingrule.h
    M mythtv/libs/libmythtv/remoteencoder.cpp
    M mythtv/libs/libmythtv/remoteencoder.h

  Log Message:
  -----------
  Use c++11 initialization.  Use m_ for class member names. (libmythtv 3/7)

Convert classes to use use the new c++11 brace initialization style.
Also update class member names (when needed) so that all member names
start with 'm_'.  This makes it easy to distinguish class members.


  Commit: 092c9c50ab81b614a1e6f6e09f76fc90c00cfd00
      https://github.com/MythTV/mythtv/commit/092c9c50ab81b614a1e6f6e09f76fc90c00cfd00
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-03-13 (Wed, 13 Mar 2019)

  Changed paths:
    M mythtv/libs/libmythtv/Bluray/bdoverlayscreen.cpp
    M mythtv/libs/libmythtv/Bluray/bdringbuffer.cpp
    M mythtv/libs/libmythtv/Bluray/bdringbuffer.h
    M mythtv/libs/libmythtv/DVD/dvdringbuffer.cpp
    M mythtv/libs/libmythtv/HLS/httplivestreambuffer.cpp
    M mythtv/libs/libmythtv/dvdstream.cpp
    M mythtv/libs/libmythtv/fileringbuffer.cpp
    M mythtv/libs/libmythtv/fileringbuffer.h
    M mythtv/libs/libmythtv/icringbuffer.cpp
    M mythtv/libs/libmythtv/ringbuffer.cpp
    M mythtv/libs/libmythtv/ringbuffer.h
    M mythtv/libs/libmythtv/streamingringbuffer.cpp
    M mythtv/libs/libmythtv/streamingringbuffer.h

  Log Message:
  -----------
  Use c++11 initialization.  Use m_ for class member names. (libmythtv 4/7)

Convert classes to use use the new c++11 brace initialization style.
Also update class member names (when needed) so that all member names
start with 'm_'.  This makes it easy to distinguish class members.


  Commit: 33103a002a15077f08e6f5f5678c2e3c346034d7
      https://github.com/MythTV/mythtv/commit/33103a002a15077f08e6f5f5678c2e3c346034d7
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-03-13 (Wed, 13 Mar 2019)

  Changed paths:
    M mythtv/libs/libmythtv/tv_rec.cpp
    M mythtv/libs/libmythtv/tv_rec.h

  Log Message:
  -----------
  Use c++11 initialization.  Use m_ for class member names. (libmythtv 5/7)

Convert classes to use use the new c++11 brace initialization style.
Also update class member names (when needed) so that all member names
start with 'm_'.  This makes it easy to distinguish class members.


  Commit: 053483cae59cfeb19b64d76662c2bee9f482f85d
      https://github.com/MythTV/mythtv/commit/053483cae59cfeb19b64d76662c2bee9f482f85d
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-03-13 (Wed, 13 Mar 2019)

  Changed paths:
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tv_play.h
    M mythtv/libs/libmythtv/tvbrowsehelper.cpp
    M mythtv/libs/libmythtv/tvbrowsehelper.h

  Log Message:
  -----------
  Use c++11 initialization.  Use m_ for class member names. (libmythtv 6/7)

Convert classes to use use the new c++11 brace initialization style.
Also update class member names (when needed) so that all member names
start with 'm_'.  This makes it easy to distinguish class members.


  Commit: 0a8c8c2f0ccd79c413c16fe216820ffab71f5787
      https://github.com/MythTV/mythtv/commit/0a8c8c2f0ccd79c413c16fe216820ffab71f5787
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-03-13 (Wed, 13 Mar 2019)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/vbitext/lang.c
    M mythtv/libs/libmythtv/recorders/vbitext/lang.h
    M mythtv/libs/libmythtv/recorders/vbitext/vbi.c

  Log Message:
  -----------
  Fix "function name hides constructor for struct" warning.


  Commit: cfe8c97bc02570e9875f3222f32781bfbe4ade44
      https://github.com/MythTV/mythtv/commit/cfe8c97bc02570e9875f3222f32781bfbe4ade44
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-03-13 (Wed, 13 Mar 2019)

  Changed paths:
    M mythtv/libs/libmythtv/recordingquality.cpp

  Log Message:
  -----------
  Fix variable declaration shadows a parameter warning.


  Commit: 50310355574053c533a61dcd546b2ea67d7a25b2
      https://github.com/MythTV/mythtv/commit/50310355574053c533a61dcd546b2ea67d7a25b2
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-03-13 (Wed, 13 Mar 2019)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/RTjpegN.cpp
    M mythtv/libs/libmythtv/recorders/v4lchannel.h

  Log Message:
  -----------
  Fixes 'variable declaration shadows a class member' warning.

Remove unused member variable in one case.  Rename the parameter in
the other case.


  Commit: 4049984e3e3b90ac3b6d209e9ca620525aca30cf
      https://github.com/MythTV/mythtv/commit/4049984e3e3b90ac3b6d209e9ca620525aca30cf
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-03-13 (Wed, 13 Mar 2019)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/scanwizardconfig.cpp
    M mythtv/libs/libmythtv/mythccextractorplayer.cpp
    M mythtv/libs/libmythtv/scanwizard.cpp
    M mythtv/libs/libmythtv/scanwizard.h
    M mythtv/libs/libmythtv/signalmonitorvalue.cpp
    M mythtv/libs/libmythtv/signalmonitorvalue.h
    M mythtv/libs/libmythtv/subtitlereader.cpp
    M mythtv/libs/libmythtv/subtitlereader.h
    M mythtv/libs/libmythtv/subtitlescreen.cpp
    M mythtv/libs/libmythtv/subtitlescreen.h
    M mythtv/libs/libmythtv/teletextdecoder.h
    M mythtv/libs/libmythtv/teletextreader.cpp
    M mythtv/libs/libmythtv/teletextreader.h
    M mythtv/libs/libmythtv/teletextscreen.cpp
    M mythtv/libs/libmythtv/teletextscreen.h
    M mythtv/libs/libmythtv/textsubtitleparser.cpp
    M mythtv/libs/libmythtv/textsubtitleparser.h
    M mythtv/libs/libmythtv/transporteditor.cpp
    M mythtv/libs/libmythtv/transporteditor.h
    M mythtv/libs/libmythtv/tvbrowsehelper.h
    M mythtv/libs/libmythtv/v4l2util.cpp
    M mythtv/libs/libmythtv/v4l2util.h
    M mythtv/libs/libmythtv/vbi608extractor.cpp
    M mythtv/libs/libmythtv/vbi608extractor.h
    M mythtv/libs/libmythtv/videobuffers.cpp
    M mythtv/libs/libmythtv/videobuffers.h
    M mythtv/libs/libmythtv/videoout_xv.cpp
    M mythtv/libs/libmythtv/videosource.cpp
    M mythtv/libs/libmythtv/videosource.h
    M mythtv/libs/libmythtv/vsync.cpp
    M mythtv/libs/libmythtv/vsync.h

  Log Message:
  -----------
  Use c++11 initialization.  Use m_ for class member names. (libmythtv 7/7)

Convert classes to use use the new c++11 brace initialization style.
Also update class member names (when needed) so that all member names
start with 'm_'.  This makes it easy to distinguish class members.


  Commit: f348b7a76bfdad868944c3a5abe8d81ed85ddf77
      https://github.com/MythTV/mythtv/commit/f348b7a76bfdad868944c3a5abe8d81ed85ddf77
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-03-13 (Wed, 13 Mar 2019)

  Changed paths:
    M mythplugins/mythgallery/mythgallery/galleryfilter.cpp
    M mythplugins/mythmusic/mythmusic/smartplaylist.cpp
    M mythplugins/mythnews/mythnews/newssite.cpp
    M mythtv/libs/libmythbase/mythcommandlineparser.cpp
    M mythtv/libs/libmythbase/mythcommandlineparser.h
    M mythtv/libs/libmythmetadata/musicmetadata.cpp
    M mythtv/libs/libmythtv/avformatdecoder.cpp
    M mythtv/libs/libmythtv/channelinfo.cpp
    M mythtv/libs/libmythtv/channelscan/channelscan_sm.cpp
    M mythtv/libs/libmythtv/channelscan/channelscanner.cpp
    M mythtv/libs/libmythtv/channelutil.h
    M mythtv/libs/libmythtv/decoderbase.h
    M mythtv/libs/libmythtv/livetvchain.cpp
    M mythtv/libs/libmythtv/mpeg/dvbdescriptors.cpp
    M mythtv/libs/libmythtv/mpeg/dvbdescriptors.h
    M mythtv/libs/libmythtv/mpeg/dvbtables.cpp
    M mythtv/libs/libmythtv/mpeg/mpegdescriptors.cpp
    M mythtv/libs/libmythtv/mpeg/mpegdescriptors.h
    M mythtv/libs/libmythtv/mythplayer.cpp
    M mythtv/libs/libmythtv/mythplayer.h
    M mythtv/libs/libmythtv/programdata.cpp
    M mythtv/libs/libmythtv/recorders/channelbase.cpp
    M mythtv/libs/libmythtv/recorders/dtvsignalmonitor.cpp
    M mythtv/libs/libmythtv/recorders/dvbchannel.cpp
    M mythtv/libs/libmythtv/recorders/dvbdev/dvbci.cpp
    M mythtv/libs/libmythtv/recorders/dvbstreamhandler.cpp
    M mythtv/libs/libmythtv/recorders/dvbstreamhandler.h
    M mythtv/libs/libmythtv/videooutbase.cpp
    M mythtv/programs/mythfrontend/prevreclist.cpp

  Log Message:
  -----------
  Merge master branch into class member names/initialization branch.


  Commit: 686ab4092b86c686c908b5b1388ce2b7df6a3819
      https://github.com/MythTV/mythtv/commit/686ab4092b86c686c908b5b1388ce2b7df6a3819
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-03-13 (Wed, 13 Mar 2019)

  Changed paths:
    M mythtv/configure
    M mythtv/filters/quickdnr/filter_quickdnr.c
    M mythtv/filters/yadif/filter_yadif.c
    M mythtv/libs/libmythtv/recorders/RTjpegN.cpp
    M mythtv/libs/libmythtv/videoout_xv.cpp

  Log Message:
  -----------
  Enable -Wshadow compilation warnings.


Compare: https://github.com/MythTV/mythtv/compare/e4d8b8974c2f...686ab4092b86


More information about the mythtv-commits mailing list