[mythtv-commits] Ticket #13415: DVBChannel hangs during Close() and Open() due to corruption of is_open

[MythTV]

#13415: DVBChannel hangs during Close() and Open() due to corruption of is_open
----------------------------------------+-------------------------------
 Reporter:  simonhyde                   |          Owner:  Klaas de Waal
     Type:  Bug Report - Hang/Deadlock  |         Status:  closed
 Priority:  minor                       |      Milestone:  30.1
Component:  MythTV - DVB                |        Version:  v30-fixes
 Severity:  medium                      |     Resolution:  Fixed
 Keywords:  DVB                         |  Ticket locked:  0
----------------------------------------+-------------------------------

Comment (by Klaas de Waal):

 Backported to v30-fixes on 30 May 2019, 10:28 (7 days ago).


 {{{
 Branch: refs/heads/fixes/30
   Home:   https://github.com/MythTV/mythtv
   Commit: 57ffe65dbc1a80b0f4289f7c6a2b8f2e73e2cf51
 https://github.com/MythTV/mythtv/commit/57ffe65dbc1a80b0f4289f7c6a2b8f2e73e2cf51
   Author: Simon Hyde <simon at icedrop.net>
   Date:   2019-05-30 (Thu, 30 May 2019)

   Changed paths:
     M mythtv/libs/libmythtv/recorders/dvbchannel.cpp

   Log Message:
   -----------
   Prevent data corruption in dvbchannel.cpp causing hang

 m_is_open was being corrupted by multiple simultaneous modifications,
 leading to it managing to create infinite loops within its underlying
 data structure. This patch extends the locking of m_hw_lock to cover
 all uses of m_is_open, preventing issues.


   Commit: 6bd8cd499382fd8b132218274fb4ae326c2b0243
 https://github.com/MythTV/mythtv/commit/6bd8cd499382fd8b132218274fb4ae326c2b0243
   Author: Klaas de Waal <klaas at modu.home.lan>
   Date:   2019-05-30 (Thu, 30 May 2019)

   Changed paths:
     M mythtv/libs/libmythtv/recorders/dvbchannel.cpp

   Log Message:
   -----------
   Remove m_ in class member names for backport to fixes-30

 }}}

-- 
Ticket URL: <https://code.mythtv.org/trac/ticket/13415#comment:5>
MythTV <http://www.mythtv.org>
MythTV Media Center