[mythtv-commits] Ticket #13057: Program title and/or description sometimes wrong

[MythTV]

#13057: Program title and/or description sometimes wrong
--------------------------------+-----------------------------
 Reporter:  klaas@…             |          Owner:  Karl Egly
     Type:  Patch - Bug Fix     |         Status:  new
 Priority:  minor               |      Milestone:  unknown
Component:  MythTV - EIT        |        Version:  Master Head
 Severity:  low                 |     Resolution:
 Keywords:  EIT DVB-C UpdateDB  |  Ticket locked:  0
--------------------------------+-----------------------------

Comment (by Klaas de Waal):

 Updated the patch for today's master.\\
 The changes are now limited to title/subtitle/description and airdate.\\

 The existing code for title/subtitle/description compares the string as
 stored in the database with the newly received string and uses the
 longest. This is wrong as already documented in the original bug report.\\
 This patch copies the old value of title/subtitle/description only if
 there is no new value but there is an old value.\\
 Example: the modification for the title:

 {{{
 -    if (match.title.length() >= ltitle.length())
 +    if (ltitle.isEmpty() && !match.title.isEmpty())
          ltitle = match.title;

 }}}
 N.B. The code for title/subtitle/description update is copied from branch
 fixes/0.27 of the mythtv fork of dcjm/David Matthews. He apparently found
 this bug also but he has not submitted a ticket for this AFAIK.\\

 The attached patch does also have a correction for the update of the
 airdate:

 {{{
 -    if (!lairdate && !match.airdate)
 +    if (!lairdate && match.airdate)
          lairdate = match.airdate;

 }}}
 The old code uses the old airdate only if the newly received airdate and
 the old airdate are both zero. This is obviously a mistake.
 The new code uses the old airdate only if the new airdate is zero and the
 old airdate is not.

-- 
Ticket URL: <https://code.mythtv.org/trac/ticket/13057#comment:3>
MythTV <http://www.mythtv.org>
MythTV Media Center