[mythtv-commits] Ticket #13381: "Setting NIT-ID" message shows unsigned int

[MythTV]

#13381: "Setting NIT-ID" message shows unsigned int
-------------------------------------+-------------------------------------
     Reporter:  Klaas de Waal        |      Owner:  (none)
         Type:  Bug Report -         |     Status:  new
  General                            |
     Priority:  trivial              |  Milestone:  needs_triage
    Component:  MythTV - Channel     |    Version:  Master Head
  Scanner                            |   Keywords:  NIT-ID DVB-T
     Severity:  low                  |  channelscan
Ticket locked:  0                    |
-------------------------------------+-------------------------------------
 My mythtv-setup gives the following message on a DVB-T scan:

 {{{
 I  ChannelScanSM(/dev/dvb/adapter1/frontend0): Setting NIT-ID to
 4294967295
 }}}
 This is obviously not correct and it happens when the "Network ID" of a
 video source is left at its default value of -1.\\
 The value is printed as an unsigned int in channelscan_sm.cpp in lines
 193-198:\\
 {{{
         {
             uint nitid = query.value(0).toInt();
             data->SetRealNetworkID(nitid);
             LOG(VB_CHANSCAN, LOG_INFO, LOC +
                 QString("Setting NIT-ID to %1").arg(nitid));
         }

 }}}

 The value should be printed as an integer as it is really an integer where
 it is used, as shown in dvbstreamdata.h:

 {{{
    // Real network ID for broken providers
     int                       _dvb_real_network_id;
 }}}

 {{{
 inline void DVBStreamData::SetRealNetworkID(int real_network_id)
 {
     QMutexLocker locker(&_listener_lock);
     _dvb_real_network_id = real_network_id;
 }
 }}}

 The (trivial) patch to change "uint nitid" to "int nitid" is attached.

-- 
Ticket URL: <https://code.mythtv.org/trac/ticket/13381>
MythTV <http://www.mythtv.org>
MythTV Media Center