[mythtv-commits] [MythTV/mythtv] 934db3: Fix bug in commit 9749e34efc which caused missed r...

Mark Kendall noreply at github.com
Thu Feb 28 11:38:57 UTC 2019


  Branch: refs/heads/devel/2019-render
  Home:   https://github.com/MythTV/mythtv
  Commit: 934db3b3d82ebe14a9337328fb59b970094032af
      https://github.com/MythTV/mythtv/commit/934db3b3d82ebe14a9337328fb59b970094032af
  Author: David Engel <dengel at mythtv.org>
  Date:   2019-02-23 (Sat, 23 Feb 2019)

  Changed paths:
    M mythtv/libs/libmythtv/recordinginfo.cpp

  Log Message:
  -----------
  Fix bug in commit 9749e34efc which caused missed recordings.

There was confusion between a member variable and function parameter.


  Commit: efc9123f421c05b9eb51afe3d9c98d03eb351c92
      https://github.com/MythTV/mythtv/commit/efc9123f421c05b9eb51afe3d9c98d03eb351c92
  Author: Klaas de Waal <klaas.de.waal at gmail.com>
  Date:   2019-02-24 (Sun, 24 Feb 2019)

  Changed paths:
    M mythtv/libs/libmythbase/threadedfilewriter.h

  Log Message:
  -----------
  Fix missing initialization of variable.

Fixes #13412.

Signed-off-by: David Hampton <mythtv at love2code.net>


  Commit: 4089bf1ff031224fa1fefe990ef376628ef7589e
      https://github.com/MythTV/mythtv/commit/4089bf1ff031224fa1fefe990ef376628ef7589e
  Author: Peter Bennett <pbennett at mythtv.org>
  Date:   2019-02-24 (Sun, 24 Feb 2019)

  Changed paths:
    M mythtv/libs/libmythtv/mythplayer.cpp

  Log Message:
  -----------
  Playback: AvSync2 fix fast forward/rewind

Fast forward and rewind were not handling frame timing correctly so that
they were dropping frames, resulting in no frames displayed in some cases.


  Commit: d6252135d684a9f6c1aa486fd9b684025f3d23d7
      https://github.com/MythTV/mythtv/commit/d6252135d684a9f6c1aa486fd9b684025f3d23d7
  Author: Peter Bennett <pbennett at mythtv.org>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M mythtv/libs/libmythui/mythuiguidegrid.cpp

  Log Message:
  -----------
  Program Guide: Fix for current selection text not showing

With certain themes (e.g. Blue Abstract) the current selection program name
was not showing in the guide grid.


  Commit: f331d1f26c134b2c751e80213aa2c2b265b4821d
      https://github.com/MythTV/mythtv/commit/f331d1f26c134b2c751e80213aa2c2b265b4821d
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M mythtv/libs/libmythtv/avfringbuffer.h

  Log Message:
  -----------
  Initialize AVFRingBuffer::m_initState to true.

Fixes coverity issue 1442850.


  Commit: 81f4b7bd2f86b3850ad419dd8c7a3f3283c0f7ae
      https://github.com/MythTV/mythtv/commit/81f4b7bd2f86b3850ad419dd8c7a3f3283c0f7ae
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M mythtv/programs/mythfrontend/themechooser.h

  Log Message:
  -----------
  Fix initialization of ThemeChooser::m_downloadState.

Fixes coverity issue 1442853.


  Commit: 8229e46f73ec3b3fd42c2781c48360bf2050f3c8
      https://github.com/MythTV/mythtv/commit/8229e46f73ec3b3fd42c2781c48360bf2050f3c8
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/externrecscanner.h

  Log Message:
  -----------
  Add initialization of ExternRecChannelScanner::m_channel_total.

Fixes coverity issue 1442028.


  Commit: 90346bc928953c5d8cad6ea13a84ac3ad66efdf0
      https://github.com/MythTV/mythtv/commit/90346bc928953c5d8cad6ea13a84ac3ad66efdf0
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M mythtv/libs/libmythtv/mpeg/mpegtables.h

  Log Message:
  -----------
  Add initialization of SpliceInformationTable::scte_pid.

Fixes coverity issue 1442033.


  Commit: 3260e981b0aacf5b1b32be114a8cc07169792568
      https://github.com/MythTV/mythtv/commit/3260e981b0aacf5b1b32be114a8cc07169792568
  Author: David Engel <dengel at mythtv.org>
  Date:   2019-02-26 (Tue, 26 Feb 2019)

  Changed paths:
    M mythtv/libs/libmythbase/mythdbcon.cpp
    M mythtv/libs/libmythbase/mythdbcon.h
    M mythtv/libs/libmythtv/channelscan/channelscan_sm.cpp
    M mythtv/libs/libmythtv/channelsettings.cpp
    M mythtv/libs/libmythtv/channelutil.cpp
    R mythtv/libs/libmythtv/datadirect.cpp
    R mythtv/libs/libmythtv/datadirect.h
    M mythtv/libs/libmythtv/dbcheck.cpp
    M mythtv/libs/libmythtv/libmythtv.pro
    M mythtv/libs/libmythtv/recordingrule.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tv_play.h
    M mythtv/libs/libmythtv/videosource.cpp
    M mythtv/libs/libmythtv/videosource.h
    M mythtv/programs/mythbackend/backendhousekeeper.cpp
    M mythtv/programs/mythbackend/httpstatus.cpp
    M mythtv/programs/mythbackend/scheduler.cpp
    M mythtv/programs/mythbackend/services/channel.cpp
    M mythtv/programs/mythfilldatabase/channeldata.cpp
    M mythtv/programs/mythfilldatabase/channeldata.h
    M mythtv/programs/mythfilldatabase/commandlineparser.cpp
    M mythtv/programs/mythfilldatabase/filldata.cpp
    M mythtv/programs/mythfilldatabase/filldata.h
    M mythtv/programs/mythfilldatabase/main.cpp
    M mythtv/programs/mythfrontend/customedit.cpp
    M mythtv/programs/mythfrontend/statusbox.cpp
    M mythtv/programs/mythtv-setup/backendsettings.cpp
    M mythtv/programs/mythtv-setup/checksetup.cpp

  Log Message:
  -----------
  Remove support for the DataDirect guide service from Schedules Direct.

As discussed on the development, mailing list, either of the two XMLTV
grabbers for Schedules Direct should now be used.

Fixes #13411


  Commit: 5b63846899946c0c150d1bf3ca4c90289293ca9f
      https://github.com/MythTV/mythtv/commit/5b63846899946c0c150d1bf3ca4c90289293ca9f
  Author: John Poet <jpoet at mythtv.org>
  Date:   2019-02-26 (Tue, 26 Feb 2019)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/ExternalStreamHandler.cpp
    M mythtv/programs/mythexternrecorder/MythExternRecApp.cpp
    M mythtv/programs/mythexternrecorder/MythExternRecApp.h
    M mythtv/programs/mythexternrecorder/external-ffmpeg.conf
    M mythtv/programs/mythexternrecorder/external-twitch.conf
    M mythtv/programs/mythexternrecorder/external-vlc.conf
    M mythtv/programs/mythexternrecorder/main.cpp

  Log Message:
  -----------
  mythexternrecorder: Allow config to pass logging options.


  Commit: 45aca1e8efd55b5a6bdb58ac09e8736dc44cc08e
      https://github.com/MythTV/mythtv/commit/45aca1e8efd55b5a6bdb58ac09e8736dc44cc08e
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-02-26 (Tue, 26 Feb 2019)

  Changed paths:
    M mythtv/libs/libmythbase/hardwareprofile.cpp
    M mythtv/libs/libmythbase/hardwareprofile.h
    M mythtv/libs/libmythbase/iso639.cpp
    M mythtv/libs/libmythbase/iso639.h
    M mythtv/libs/libmythbase/mythcommandlineparser.h
    M mythtv/libs/libmythbase/mythlocale.cpp
    M mythtv/libs/libmythbase/mythlocale.h
    M mythtv/libs/libmythbase/mythsorthelper.cpp
    M mythtv/libs/libmythbase/mythsorthelper.h
    M mythtv/libs/libmythbase/mythstorage.cpp
    M mythtv/libs/libmythbase/mythstorage.h
    M mythtv/libs/libmythui/screensaver-dbus.cpp

  Log Message:
  -----------
  cppcheck: Clean up "parameter should passed as a const reference" messages.


  Commit: cff08e3f13f994d2faec1c35cd89b75ba0583ce9
      https://github.com/MythTV/mythtv/commit/cff08e3f13f994d2faec1c35cd89b75ba0583ce9
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-02-26 (Tue, 26 Feb 2019)

  Changed paths:
    M mythtv/libs/libmythbase/mythsorthelper.h

  Log Message:
  -----------
  cppcheck: Clean up "one argument constructor not explicit" message.


  Commit: 0823653b4390d7b01d36bf8a88851df696ee34b3
      https://github.com/MythTV/mythtv/commit/0823653b4390d7b01d36bf8a88851df696ee34b3
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-02-26 (Tue, 26 Feb 2019)

  Changed paths:
    M mythtv/libs/libmythui/AppleRemote.h
    M mythtv/libs/libmythui/screensaver-android.h
    M mythtv/libs/libmythui/screensaver-osx.h

  Log Message:
  -----------
  cppcheck: Clean up "not marked with a 'override' specifier" messages.


  Commit: 3ee127de7a0ce643a5db283c3095d137ab8b49b8
      https://github.com/MythTV/mythtv/commit/3ee127de7a0ce643a5db283c3095d137ab8b49b8
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-02-26 (Tue, 26 Feb 2019)

  Changed paths:
    M mythplugins/mythmusic/mythmusic/pls.cpp
    M mythtv/libs/libmythbase/codecutil.cpp
    M mythtv/libs/libmythbase/mythsystem.cpp
    M mythtv/libs/libmythbase/portchecker.cpp
    M mythtv/libs/libmythtv/recorders/RTjpegN.cpp
    M mythtv/libs/libmythtv/recorders/cetonrtsp.cpp
    M mythtv/programs/mythtv-setup/checksetup.cpp

  Log Message:
  -----------
  cppcheck: Clean up "variable assigned a value that is never used" messages.

Mostly removing the variable assignment.  In one case the value is
assigned from a function call, one of the other parameters is a return
value and is used, so just quiet the warning.  In another case the
variable is only used inside of an ifdef, so declare the variable in
an ifdef.


  Commit: 97c40cd15354ae438b131751e302047219e5846d
      https://github.com/MythTV/mythtv/commit/97c40cd15354ae438b131751e302047219e5846d
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-02-27 (Wed, 27 Feb 2019)

  Changed paths:
    M mythtv/libs/libmyth/output.h
    M mythtv/libs/libmythbase/mythcorecontext.h
    M mythtv/libs/libmythbase/mythobservable.h
    M mythtv/libs/libmythupnp/ssdpcache.h
    M mythtv/libs/libmythupnp/upnpsubscription.h

  Log Message:
  -----------
  Mark MythObservable as not copyable.

Also mark classes based off MythObservable as not copyable.  These all
seems to be singleton classes, so copying doesn't make sense anyway.
This will eliminate cppcheck warnings about a missing copy
constructor.


  Commit: 7f28a7408af22162902d3dd6d3eade6274a70302
      https://github.com/MythTV/mythtv/commit/7f28a7408af22162902d3dd6d3eade6274a70302
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-02-27 (Wed, 27 Feb 2019)

  Changed paths:
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tv_play.h
    M mythtv/programs/mythbackend/services/channel.cpp
    M mythtv/programs/mythbackend/services/channel.h
    M mythtv/programs/mythfilldatabase/filldata.cpp
    M mythtv/programs/mythfilldatabase/filldata.h
    M mythtv/programs/mythfilldatabase/main.cpp

  Log Message:
  -----------
  Clean up unused parameter/variable warnings from removing DataDirect.


  Commit: e4689155d2d71cf29521d7cc91dba48d79f3068f
      https://github.com/MythTV/mythtv/commit/e4689155d2d71cf29521d7cc91dba48d79f3068f
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2019-02-28 (Thu, 28 Feb 2019)

  Changed paths:
    M mythplugins/mythmusic/mythmusic/pls.cpp
    M mythtv/libs/libmyth/output.h
    M mythtv/libs/libmythbase/codecutil.cpp
    M mythtv/libs/libmythbase/hardwareprofile.cpp
    M mythtv/libs/libmythbase/hardwareprofile.h
    M mythtv/libs/libmythbase/iso639.cpp
    M mythtv/libs/libmythbase/iso639.h
    M mythtv/libs/libmythbase/mythcommandlineparser.h
    M mythtv/libs/libmythbase/mythcorecontext.h
    M mythtv/libs/libmythbase/mythdbcon.cpp
    M mythtv/libs/libmythbase/mythdbcon.h
    M mythtv/libs/libmythbase/mythlocale.cpp
    M mythtv/libs/libmythbase/mythlocale.h
    M mythtv/libs/libmythbase/mythobservable.h
    M mythtv/libs/libmythbase/mythsorthelper.cpp
    M mythtv/libs/libmythbase/mythsorthelper.h
    M mythtv/libs/libmythbase/mythstorage.cpp
    M mythtv/libs/libmythbase/mythstorage.h
    M mythtv/libs/libmythbase/mythsystem.cpp
    M mythtv/libs/libmythbase/portchecker.cpp
    M mythtv/libs/libmythbase/threadedfilewriter.h
    M mythtv/libs/libmythtv/avfringbuffer.h
    M mythtv/libs/libmythtv/channelscan/channelscan_sm.cpp
    M mythtv/libs/libmythtv/channelscan/externrecscanner.h
    M mythtv/libs/libmythtv/channelsettings.cpp
    M mythtv/libs/libmythtv/channelutil.cpp
    R mythtv/libs/libmythtv/datadirect.cpp
    R mythtv/libs/libmythtv/datadirect.h
    M mythtv/libs/libmythtv/dbcheck.cpp
    M mythtv/libs/libmythtv/libmythtv.pro
    M mythtv/libs/libmythtv/mpeg/mpegtables.h
    M mythtv/libs/libmythtv/mythplayer.cpp
    M mythtv/libs/libmythtv/recorders/ExternalStreamHandler.cpp
    M mythtv/libs/libmythtv/recorders/RTjpegN.cpp
    M mythtv/libs/libmythtv/recorders/cetonrtsp.cpp
    M mythtv/libs/libmythtv/recordinginfo.cpp
    M mythtv/libs/libmythtv/recordingrule.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tv_play.h
    M mythtv/libs/libmythtv/videosource.cpp
    M mythtv/libs/libmythtv/videosource.h
    M mythtv/libs/libmythui/AppleRemote.h
    M mythtv/libs/libmythui/mythuiguidegrid.cpp
    M mythtv/libs/libmythui/screensaver-android.h
    M mythtv/libs/libmythui/screensaver-dbus.cpp
    M mythtv/libs/libmythui/screensaver-osx.h
    M mythtv/libs/libmythupnp/ssdpcache.h
    M mythtv/libs/libmythupnp/upnpsubscription.h
    M mythtv/programs/mythbackend/backendhousekeeper.cpp
    M mythtv/programs/mythbackend/httpstatus.cpp
    M mythtv/programs/mythbackend/scheduler.cpp
    M mythtv/programs/mythbackend/services/channel.cpp
    M mythtv/programs/mythbackend/services/channel.h
    M mythtv/programs/mythexternrecorder/MythExternRecApp.cpp
    M mythtv/programs/mythexternrecorder/MythExternRecApp.h
    M mythtv/programs/mythexternrecorder/external-ffmpeg.conf
    M mythtv/programs/mythexternrecorder/external-twitch.conf
    M mythtv/programs/mythexternrecorder/external-vlc.conf
    M mythtv/programs/mythexternrecorder/main.cpp
    M mythtv/programs/mythfilldatabase/channeldata.cpp
    M mythtv/programs/mythfilldatabase/channeldata.h
    M mythtv/programs/mythfilldatabase/commandlineparser.cpp
    M mythtv/programs/mythfilldatabase/filldata.cpp
    M mythtv/programs/mythfilldatabase/filldata.h
    M mythtv/programs/mythfilldatabase/main.cpp
    M mythtv/programs/mythfrontend/customedit.cpp
    M mythtv/programs/mythfrontend/statusbox.cpp
    M mythtv/programs/mythfrontend/themechooser.h
    M mythtv/programs/mythtv-setup/backendsettings.cpp
    M mythtv/programs/mythtv-setup/checksetup.cpp

  Log Message:
  -----------
  Merge branch 'master' into devel/2019-render


Compare: https://github.com/MythTV/mythtv/compare/03b27577f74f...e4689155d2d7


More information about the mythtv-commits mailing list