[mythtv-commits] Ticket #13539: Feature patch - python bindings - remove errant executable bit from library file

[MythTV]

#13539: Feature patch - python bindings - remove errant executable bit from library
file
-----------------------------------+--------------------------
     Reporter:  Gary Buhrmaster    |      Owner:  Bill Meek
         Type:  Patch - Feature    |     Status:  new
     Priority:  minor              |  Milestone:  needs_triage
    Component:  Bindings - Python  |    Version:  Master Head
     Severity:  medium             |   Keywords:
Ticket locked:  0                  |
-----------------------------------+--------------------------
 Feature patch - python bindings - remove errant executable bit from
 library file.

 Remove the execute bit from ttvbXslt.py in the source code.  As a library
 file to be imported, it does not need to be executable.  Indeed, the
 setup.py that is invoked as part of make install installs the file without
 the execute bit in my tests (typically into .../site-packages/).

 The proposed patch removes the execute bit from the source file itself (no
 other library file in the bindings/python directory is set executable,
 only scripts which are intended to be installed as executable).

 Really (really) trivial/low priority/severity source cleanup ticket (but
 ticket protocol says I should not set the priority/severity for new
 tickets, so it ends up being minor/medium, sorry).


 Some history of the execute bit status on this file that I have
 researched:

 6f13458f3e2947b884217057d3b741554d67fd2b - June 2010 - file originally
 added as non-executable

 b5de4d167013b787cd024ea610f738440b7e2b67 - August 2010 - file executable
 (accidentally?) as part of a larger fix

 d1da17e6bb322028c21acf02bf9cca139a60e5fa - September 2010 - removed the
 errant executable bit from the library file

 774f0d3ee833039f42f368685a5360b98f55e801 - July 2011 - (contributed patch)
 added the executable bit back (accidentally?) as part of a larger patch
 series


 Proposed patch:

 {{{
 diff --git a/mythtv/bindings/python/MythTV/ttvdb/tvdbXslt.py
 b/mythtv/bindings/python/MythTV/ttvdb/tvdbXslt.py
 old mode 100755
 new mode 100644
 }}}

-- 
Ticket URL: <https://code.mythtv.org/trac/ticket/13539>
MythTV <http://www.mythtv.org>
MythTV Media Center