[mythtv-commits] Ticket #13292: LiveTV Channel Switching - DVB-T/T2 UK Freeview

MythTV noreply at mythtv.org
Thu Aug 29 12:31:53 UTC 2019

#13292: LiveTV Channel Switching - DVB-T/T2 UK Freeview
 Reporter:  Mike Bibbings         |          Owner:  Peter Bennett
     Type:  Bug Report - General  |         Status:  assigned
 Priority:  minor                 |      Milestone:  needs_triage
Component:  MythTV - DVB          |        Version:  Master Head
 Severity:  medium                |     Resolution:
 Keywords:                        |  Ticket locked:  0

Comment (by Mike Bibbings):

 Replying to [comment:11 Peter Bennett]:
 > By always returning 1 from the FAIL macro, the patch means that the
 function has_codec_parameters always returns true. In that case the
 has_codec_parameters function as well as the loop from where it is called,
 will have no effect and could be removed.
 > It looks like the loop is designed to pause for 50 ms if the data is not
 ready for live tv.
 > Is that loop really unnecessary? It seems that the worst it can do is
 cause a fraction of a second delay, while removing it could cause playback
 to fail if the data is not really there when needed.
 > Am I understanding this correctly? Do you have any insight on why this
 fixes the problem?

 Done some more testing by completely removing has_codec_parameters
 function and the loop.
 Live TV channel changes worked with no problems for DVB-T/T2 and DVB-S/S2,
 channel changes are faster (to be expected) and do not result in dropping
 back to in-file detection.
 FindStreamInfo() is happy, it is just that the checks failure.

 My only concern about totally removing the function and the loop is
 possible side effects on other transmission systems e.g atsc, which I
 don't have and cannot test.

 I have created a patch (for fixes/30 and master) which makes the checks
 conditional on a new mythbackend setting.

 No action is required for most users, as the default is to allow the
 checks to run.
 For those users with DVB-T/T2 tuners having the problem  e.g. UK Freeview,
 mythtv-setup>General>Locale Settings has a new option "Live TV Codec
 Checks" which when set to "No" bypasses the checks.

Ticket URL: <https://code.mythtv.org/trac/ticket/13292#comment:14>
MythTV <http://www.mythtv.org>
MythTV Media Center

More information about the mythtv-commits mailing list