[mythtv-commits] [MythTV/mythtv] a66571: tidy: Fix suspicious string comparisons.
linuxdude42
noreply at github.com
Fri Apr 5 00:19:06 UTC 2019
Branch: refs/heads/master
Home: https://github.com/MythTV/mythtv
Commit: a665716e46d8afaf925bcddb79f287071d63d4a3
https://github.com/MythTV/mythtv/commit/a665716e46d8afaf925bcddb79f287071d63d4a3
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-03 (Wed, 03 Apr 2019)
Changed paths:
M mythplugins/mythzoneminder/mythzmserver/main.cpp
M mythtv/libs/libmythtv/Bluray/bdiowrapper.cpp
M mythtv/libs/libmythtv/avformatdecoder.cpp
M mythtv/libs/libmythtv/mythiowrapper.cpp
M mythtv/libs/libmythtv/nuppeldecoder.cpp
M mythtv/libs/libmythtv/xine_demux_sputext.cpp
M mythtv/programs/mythtranscode/mpeg2fix.cpp
Log Message:
-----------
tidy: Fix suspicious string comparisons.
The clang-tidy "suspicion string comparison" warns when a compare
function, which returns [-1, 0, -1], is cast to a boolean value and
used in a comparison. Make these explicit comparisons to zero,
instead of implicit comparisons. Changes made by the clang-tidy
program.
https://clang.llvm.org/extra/clang-tidy/checks/bugprone-suspicious-string-compare.html
Commit: 16790d5a1b079bfcf3b643f8382a3a9b20bb0108
https://github.com/MythTV/mythtv/commit/16790d5a1b079bfcf3b643f8382a3a9b20bb0108
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-03 (Wed, 03 Apr 2019)
Changed paths:
M mythtv/libs/libmythtv/xine_demux_sputext.cpp
M mythtv/libs/libmythui/util-nvctrl.cpp
Log Message:
-----------
tidy: Convert function return argument to boolean.
The clang-tidy "implicit boolean conversion" check pointed out some
suspicious conversions to/from boolean values. Fix the code by
converting a local variable to boolean, and converting a function
return argument to boolean.
https://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-conversion.html
Commit: 1c0b00bc53a29d8cce05b698692fcada477b84ad
https://github.com/MythTV/mythtv/commit/1c0b00bc53a29d8cce05b698692fcada477b84ad
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-03 (Wed, 03 Apr 2019)
Changed paths:
M mythtv/libs/libmythfreesurround/el_processor.cpp
M mythtv/libs/libmythmpeg2/cpu_state.c
Log Message:
-----------
tidy: Comment out unused parameter names.
The clang-tidy "unused parameters" check pointed out two function
variables that weren't used in the body of the function. Comment out
these two variable names.
https://clang.llvm.org/extra/clang-tidy/checks/misc-unused-parameters.html
Commit: bbf93fef606c4db316b1959adf6c2a471bebbc66
https://github.com/MythTV/mythtv/commit/bbf93fef606c4db316b1959adf6c2a471bebbc66
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-03 (Wed, 03 Apr 2019)
Changed paths:
R message
Log Message:
-----------
Remove accidentally committed file.
Commit: c97e546405464df4609124840eea1a396f2acb6a
https://github.com/MythTV/mythtv/commit/c97e546405464df4609124840eea1a396f2acb6a
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-03 (Wed, 03 Apr 2019)
Changed paths:
M mythplugins/mythgame/mythgame/gamehandler.cpp
M mythplugins/mythnews/mythnews/mythnews.cpp
M mythtv/libs/libmyth/netutils.cpp
M mythtv/libs/libmyth/programinfo.cpp
M mythtv/libs/libmythmetadata/imagemanager.cpp
M mythtv/libs/libmythtv/channelutil.cpp
M mythtv/libs/libmythtv/diseqc.cpp
M mythtv/libs/libmythtv/dtvmultiplex.cpp
M mythtv/libs/libmythtv/livetvchain.cpp
M mythtv/libs/libmythtv/recorders/channelbase.cpp
M mythtv/libs/libmythtv/sourceutil.cpp
M mythtv/libs/libmythtv/tv_rec.cpp
M mythtv/programs/mythbackend/scheduler.cpp
M mythtv/programs/mythbackend/services/capture.cpp
Log Message:
-----------
tidy: Use the toBool function when converting SQL query responses.
The clang-tidy "implicit boolean conversion" check pointed out a
number of places where SQL query results are explicitly converted to
an integer with the QVariant::toInt function, and the implicitly
converted to a boolean. Convert these directly to boolean by using
the QVariant::toBool function.
https://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-conversion.html
Commit: 3246b15fc2dd87157de2d0b420caf6b2491ebdeb
https://github.com/MythTV/mythtv/commit/3246b15fc2dd87157de2d0b420caf6b2491ebdeb
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-03 (Wed, 03 Apr 2019)
Changed paths:
M mythplugins/mythgame/mythgame/rominfo.cpp
M mythplugins/mythzoneminder/mythzoneminder/zmclient.cpp
M mythtv/libs/libmythbase/remotefile.cpp
M mythtv/libs/libmythmetadata/imagemanager.cpp
M mythtv/libs/libmythmetadata/metaiomp4.cpp
M mythtv/libs/libmythprotoserver/requesthandler/fileserverhandler.cpp
M mythtv/libs/libmythtv/channelsettings.cpp
M mythtv/libs/libmythtv/inputinfo.cpp
M mythtv/libs/libmythtv/livetvchain.cpp
M mythtv/libs/libmythtv/remoteencoder.cpp
M mythtv/libs/libmythtv/tv_play.cpp
M mythtv/libs/libmythtv/tvremoteutil.cpp
M mythtv/libs/libmythtv/videodisplayprofile.cpp
M mythtv/libs/libmythtv/videosource.cpp
M mythtv/libs/libmythui/mythmainwindow.cpp
M mythtv/libs/libmythui/mythnotification.cpp
M mythtv/libs/libmythui/xmlparsebase.cpp
M mythtv/libs/libmythupnp/upnpdevice.cpp
M mythtv/programs/mythbackend/httpconfig.cpp
M mythtv/programs/mythbackend/mainserver.cpp
M mythtv/programs/mythbackend/playbacksock.cpp
M mythtv/programs/mythfrontend/playbackbox.cpp
M mythtv/programs/mythfrontend/playbackboxhelper.cpp
M mythtv/programs/mythlcdserver/lcdserver.cpp
Log Message:
-----------
tidy: Perform explicit zero-non-zero test when converting string to boolean.
The clang-tidy "implicit boolean conversion" check pointed out a
number of places where integers are implicitly converted to boolean
values. In the places where these are string -> integer -> boolean
conversions, perform an explicit check for zero/non-zero. Changes
made by the clang-tidy program.
https://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-conversion.html
Commit: a18f47685ea783d9cfac44e979de55a264e06afa
https://github.com/MythTV/mythtv/commit/a18f47685ea783d9cfac44e979de55a264e06afa
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-03 (Wed, 03 Apr 2019)
Changed paths:
M mythtv/programs/mythfrontend/playbackbox.cpp
Log Message:
-----------
tidy: Explicitly convert from boolean to AutoExpireType in playbackbox.cpp.
The clang-tidy "implicit boolean conversion" check pointed out one
place where a boolean was being converted to an integer, which on
investigation was then being cast to AutoExpireType. Fix this to
explicitly convert from a boolean straight to AutoExpireType.
https://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-conversion.html
Commit: 962e4852bdadda16b053b94d0567ce618d80cf6a
https://github.com/MythTV/mythtv/commit/962e4852bdadda16b053b94d0567ce618d80cf6a
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-03 (Wed, 03 Apr 2019)
Changed paths:
M mythtv/libs/libmythbase/mythmiscutil.cpp
Log Message:
-----------
tidy: Explicitly test the return value of calling myth_system.
The clang-tidy "implicit boolean conversion" check pointed out one
spot where the return value of myth_system was implicitly converted
into a boolean result. Fix to explicitly check the return value
against zero. Changes made by the clang-tidy program.
https://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-conversion.html
Commit: e9620c67e1c0eb7c79eb416ddd663def795593a5
https://github.com/MythTV/mythtv/commit/e9620c67e1c0eb7c79eb416ddd663def795593a5
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-03 (Wed, 03 Apr 2019)
Changed paths:
M mythtv/libs/libmythtv/dbcheck.cpp
M mythtv/programs/mythbackend/mainserver.cpp
Log Message:
-----------
tidy: Explicitly test the return value of system library functions.
The clang-tidy "implicit boolean conversion" check pointed out one
spot where the return value of a system library function was
implicitly converted into a boolean result. Fix to explicitly check
the return value against zero. Changes made by the clang-tidy
program.
https://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-conversion.html
Commit: bc18e0cb4bbe3fb5fca530f921d5cbe5a47a0f65
https://github.com/MythTV/mythtv/commit/bc18e0cb4bbe3fb5fca530f921d5cbe5a47a0f65
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-03 (Wed, 03 Apr 2019)
Changed paths:
M mythtv/libs/libmythtv/previewgenerator.cpp
Log Message:
-----------
tidy: Explicitly check file size in previewgenerator.cpp.
The clang-tidy "implicit boolean conversion" check pointed out a spot
where a file size was implicitly converted to a boolean value. Fix to
explicitly test to see if the file is non-zero in length. Changes
made by the clang-tidy program.
https://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-conversion.html
Commit: 2032ac013221e9367c9f720459e5e9f546caf66e
https://github.com/MythTV/mythtv/commit/2032ac013221e9367c9f720459e5e9f546caf66e
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-03 (Wed, 03 Apr 2019)
Changed paths:
M mythtv/libs/libmythmetadata/bluraymetadata.cpp
M mythtv/libs/libmythtv/Bluray/bdringbuffer.cpp
M mythtv/libs/libmythtv/DVD/dvdringbuffer.cpp
M mythtv/libs/libmythtv/DVD/dvdringbuffer.h
M mythtv/libs/libmythtv/DVD/mythdvdplayer.cpp
Log Message:
-----------
tidy: Convert from library APIs to boolean.
The clang-tidy "implicit boolean conversion" check pointed out a
number of places where integers are being implicitly converted to
boolean values. These are system library APIs that use
'int/int8/Bool' instead of 'boolean'. Convert to explicit non-zero
tests for assigning to booleans. Changes made by the clang-tidy
program.
https://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-conversion.html
Commit: 0bf0880d3e7ff0f78d1b90953e1f48618421e62d
https://github.com/MythTV/mythtv/commit/0bf0880d3e7ff0f78d1b90953e1f48618421e62d
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-03 (Wed, 03 Apr 2019)
Changed paths:
M mythtv/libs/libmythtv/mythplayer.cpp
M mythtv/libs/libmythtv/playercontext.cpp
Log Message:
-----------
Fix "in progress" check in mythplayer.
The clang-tidy "implicit boolean conversion" check pointed out a
couple of nonsensical implicit conversion from TVState to boolean.
Fix the code to properly test for one of two TV watching states.
Fixes #13442.
https://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-conversion.html
Commit: 5f1a0d358cd9651a95050b90e7dbd233eff6c68a
https://github.com/MythTV/mythtv/commit/5f1a0d358cd9651a95050b90e7dbd233eff6c68a
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-03 (Wed, 03 Apr 2019)
Changed paths:
M mythtv/libs/libmythtv/tv_play.cpp
Log Message:
-----------
Convert local variables from int to boolean.
The clang-tidy "implicit boolean conversion" check pointed out a
couple of integer to boolean conversions that can be eliminated by
converting a local variable to a boolean. Changes made by the
clang-tidy program.
https://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-conversion.html
Commit: 2f929b7ae7259bc7836f1a0d9fe8526df1ef55ca
https://github.com/MythTV/mythtv/commit/2f929b7ae7259bc7836f1a0d9fe8526df1ef55ca
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-03 (Wed, 03 Apr 2019)
Changed paths:
M mythtv/programs/mythfrontend/playbackbox.cpp
Log Message:
-----------
Use SaveBoolSetting instead of SaveSetting.
The clang-tidy "implicit boolean conversion" check pointed out a
boolean to intinteger conversion that would be better handled by using
the MythCoreContext::SaveBoolSetting function.
Commit: 9be52d6df4307a8c94df2a2be35de77be20d32ed
https://github.com/MythTV/mythtv/commit/9be52d6df4307a8c94df2a2be35de77be20d32ed
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-03 (Wed, 03 Apr 2019)
Changed paths:
M mythtv/libs/libmythtv/cardutil.cpp
Log Message:
-----------
tidy: Clean up control flow jumps followed by else statements.
If the last statement in an "if" block unconditional changes the
control flow, then there is no need to follow that statement with an
else block. Omitting the "else" statement and the indentation of the
subsequent block makes the code easier to follow. Changes made by the
clang-tidy program.
https://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html
Commit: 764c00863f05a3a92059b5c920080f0d288b4713
https://github.com/MythTV/mythtv/commit/764c00863f05a3a92059b5c920080f0d288b4713
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-03 (Wed, 03 Apr 2019)
Changed paths:
M mythtv/libs/libmyth/programinfo.cpp
M mythtv/libs/libmyth/programtypes.cpp
M mythtv/libs/libmythbase/mythdate.cpp
M mythtv/libs/libmythbase/mythsystemlegacy.cpp
M mythtv/libs/libmythtv/avformatdecoder.cpp
M mythtv/libs/libmythtv/cardutil.cpp
M mythtv/libs/libmythtv/channelscan/channelimporter.cpp
M mythtv/libs/libmythtv/eitfixup.cpp
M mythtv/libs/libmythtv/jobqueue.cpp
M mythtv/libs/libmythtv/mpeg/mpegtables.cpp
M mythtv/libs/libmythtv/mpeg/sctetables.cpp
M mythtv/libs/libmythtv/mythplayer.cpp
M mythtv/libs/libmythtv/openglvideo.cpp
M mythtv/libs/libmythtv/osdchromakey.cpp
M mythtv/libs/libmythtv/recorders/NuppelVideoRecorder.cpp
M mythtv/libs/libmythtv/recorders/dtvrecorder.cpp
M mythtv/libs/libmythtv/recorders/dvbchannel.cpp
M mythtv/libs/libmythtv/recorders/dvbdev/dvbci.cpp
M mythtv/libs/libmythtv/recorders/signalmonitor.cpp
M mythtv/libs/libmythtv/recorders/v4lchannel.cpp
M mythtv/libs/libmythtv/subtitlescreen.cpp
M mythtv/libs/libmythtv/teletextreader.cpp
M mythtv/libs/libmythtv/tv_play.cpp
M mythtv/libs/libmythtv/tv_rec.cpp
M mythtv/libs/libmythtv/v4l2util.cpp
M mythtv/libs/libmythtv/visualisations/videovisualgoom.cpp
M mythtv/libs/libmythui/mythmainwindow.cpp
M mythtv/libs/libmythui/mythrender_opengl.cpp
M mythtv/libs/libmythui/mythrender_vdpau.cpp
M mythtv/libs/libmythui/mythuifilebrowser.cpp
M mythtv/libs/libmythui/mythuitext.cpp
M mythtv/libs/libmythui/mythuitextedit.cpp
M mythtv/libs/libmythupnp/websocket.cpp
M mythtv/programs/mythbackend/scheduler.cpp
M mythtv/programs/mythbackend/services/dvr.cpp
M mythtv/programs/mythcommflag/ClassicCommDetector.cpp
M mythtv/programs/mythfrontend/keygrabber.cpp
M mythtv/programs/mythfrontend/playbackbox.cpp
M mythtv/programs/mythfrontend/prevreclist.cpp
M mythtv/programs/mythfrontend/schedulecommon.cpp
M mythtv/programs/mythfrontend/scheduleeditor.cpp
M mythtv/programs/mythfrontend/themechooser.cpp
M mythtv/programs/mythutil/mpegutils.cpp
Log Message:
-----------
tidy: Perform explicit zero/non-zero test when converting bit flags to boolean.
The clang-tidy "implicit boolean conversion" check pointed out a
number of places where integers have a bitmask applied, and are then
implicitly converted to boolean values. Make the conversion explicit
by adding a test for zero/non-zero. Changes made by the clang-tidy
program.
https://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-conversion.html
Commit: 27e397260122a2391c9ca751003779f5ad02fb2b
https://github.com/MythTV/mythtv/commit/27e397260122a2391c9ca751003779f5ad02fb2b
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-03 (Wed, 03 Apr 2019)
Changed paths:
M mythtv/libs/libmythtv/jobqueue.cpp
M mythtv/libs/libmythtv/previewgenerator.cpp
M mythtv/libs/libmythtv/recorders/analogsignalmonitor.cpp
M mythtv/libs/libmythtv/recorders/mpegrecorder.cpp
M mythtv/libs/libmythtv/recorders/v4lchannel.cpp
M mythtv/programs/mythtranscode/mpeg2fix.cpp
Log Message:
-----------
tidy: Perform explicit zero/non-zero test when converting bit flags to boolean. (2)
The clang-tidy "implicit boolean conversion" check pointed out a
number of places where integers have a bitmask applied, and are then
implicitly converted to boolean values. Make the conversion explicit
by adding a test for zero/non-zero. Changes made by the clang-tidy
program, then tweaked by hand because clang-tidy doesn't handle the
"not not" idiom.
https://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-conversion.html
Commit: d726068eb4ade648aa04e47beea7c873196c9004
https://github.com/MythTV/mythtv/commit/d726068eb4ade648aa04e47beea7c873196c9004
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-03 (Wed, 03 Apr 2019)
Changed paths:
M mythtv/libs/libmythtv/mythiowrapper.cpp
Log Message:
-----------
Add comment explaining why this function returns an int.
Commit: 2c5ccea2891c97631119b9087ae8175c82166cd8
https://github.com/MythTV/mythtv/commit/2c5ccea2891c97631119b9087ae8175c82166cd8
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-03 (Wed, 03 Apr 2019)
Changed paths:
M mythtv/libs/libmythtv/tv_play.cpp
Log Message:
-----------
Use the right type argument to vector::insert.
Commit: 102c8a26dba25566e7f189af52ff61c72f755b30
https://github.com/MythTV/mythtv/commit/102c8a26dba25566e7f189af52ff61c72f755b30
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-03 (Wed, 03 Apr 2019)
Changed paths:
M mythtv/libs/libmythfreemheg/Stream.cpp
M mythtv/libs/libmythtv/avformatdecoder.cpp
M mythtv/libs/libmythtv/eitcache.cpp
M mythtv/libs/libmythtv/mpeg/H264Parser.cpp
M mythtv/libs/libmythtv/mpeg/mpegstreamdata.cpp
M mythtv/libs/libmythtv/openglvideo.cpp
M mythtv/libs/libmythtv/recorders/NuppelVideoRecorder.cpp
M mythtv/libs/libmythtv/recorders/analogsignalmonitor.cpp
M mythtv/libs/libmythtv/recorders/dtvrecorder.cpp
M mythtv/libs/libmythtv/recorders/v4lchannel.cpp
M mythtv/libs/libmythtv/textsubtitleparser.cpp
M mythtv/libs/libmythtv/tv_rec.cpp
M mythtv/libs/libmythui/mythmainwindow.cpp
M mythtv/libs/libmythui/mythuitextedit.cpp
M mythtv/libs/libmythupnp/msocketdevice.cpp
M mythtv/programs/mythbackend/mainserver.cpp
M mythtv/programs/mythbackend/scheduler.cpp
M mythtv/programs/mythfilldatabase/xmltvparser.cpp
M mythtv/programs/mythfrontend/actionset.cpp
M mythtv/programs/mythfrontend/guidegrid.cpp
M mythtv/programs/mythfrontend/keygrabber.cpp
M mythtv/programs/mythfrontend/playbackbox.cpp
M mythtv/programs/mythfrontend/programinfocache.cpp
M mythtv/programs/mythfrontend/videometadatasettings.cpp
M mythtv/programs/mythfrontend/videoplayersettings.cpp
M mythtv/programs/mythmetadatalookup/lookup.cpp
M mythtv/programs/mythtv-setup/main.cpp
Log Message:
-----------
tidy: Perform explicit zero/non-zero tests when converting to boolean.
The clang-tidy "implicit boolean conversion" check pointed out a
number of places where integers are implicitly converted to boolean
values. Make the conversion explicit by adding a test for
zero/non-zero. Changes made by the clang-tidy program.
https://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-conversion.html
Commit: 11eba7068c8d68abef8b640bf2be41df933127d2
https://github.com/MythTV/mythtv/commit/11eba7068c8d68abef8b640bf2be41df933127d2
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-03 (Wed, 03 Apr 2019)
Changed paths:
M mythtv/libs/libmythtv/channelscan/channelscanner_cli.cpp
M mythtv/libs/libmythtv/channelscan/scanmonitor.h
Log Message:
-----------
Add a boolValue function to ScannerEvent.
Commit: a753da424379d75b6123ed822bb386fa978f5480
https://github.com/MythTV/mythtv/commit/a753da424379d75b6123ed822bb386fa978f5480
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-03 (Wed, 03 Apr 2019)
Changed paths:
M mythtv/libs/libmythui/myththemedmenu.cpp
M mythtv/programs/mythfrontend/main.cpp
Log Message:
-----------
Use available the GetBoolSetting functions.
Commit: ad1b1f0432b82c82906a7e52499bec4f98507da3
https://github.com/MythTV/mythtv/commit/ad1b1f0432b82c82906a7e52499bec4f98507da3
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-03 (Wed, 03 Apr 2019)
Changed paths:
M mythtv/programs/mythtranscode/transcode.cpp
Log Message:
-----------
Fix the type of the recently added get_bool_option in transcode.cpp.
Commit: 5b85fd9b2560f83052f1c0f58a73b4a9c9e55148
https://github.com/MythTV/mythtv/commit/5b85fd9b2560f83052f1c0f58a73b4a9c9e55148
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-03 (Wed, 03 Apr 2019)
Changed paths:
M mythtv/libs/libmythui/DisplayResScreen.cpp
Log Message:
-----------
tidy: Perform explicit zero/non-zero test when converting bit flags to boolean.
The clang-tidy "inefficient vector operation" check pointed out a case
where items were pushed onto a list from within a loop. To prevent
multiple memory reallocations, the space should be reserved up front.
Changes made by the clang-tidy program.
https://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-conversion.html
Commit: 28ca2972cb25a4e0f11e19c656eb742b5e18e254
https://github.com/MythTV/mythtv/commit/28ca2972cb25a4e0f11e19c656eb742b5e18e254
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-03 (Wed, 03 Apr 2019)
Changed paths:
M mythplugins/mytharchive/mytharchive/themeselector.cpp
M mythplugins/mythgallery/mythgallery/galleryutil.cpp
M mythplugins/mythgame/mythgame/gameui.cpp
M mythplugins/mythnetvision/mythnetvision/netbase.cpp
M mythplugins/mythnetvision/mythnetvision/neteditorbase.cpp
M mythplugins/mythnetvision/mythnetvision/nettree.cpp
M mythplugins/mythnetvision/mythnetvision/rsseditor.cpp
M mythplugins/mythzoneminder/mythzmserver/zmserver.cpp
M mythplugins/mythzoneminder/mythzoneminder/zmliveplayer.cpp
M mythtv/libs/libmyth/audio/audiooutput.cpp
M mythtv/libs/libmyth/backendselect.cpp
M mythtv/libs/libmyth/netgrabbermanager.cpp
M mythtv/libs/libmythbase/mythcommandlineparser.cpp
M mythtv/libs/libmythbase/mythdb.cpp
M mythtv/libs/libmythmetadata/dirscan.cpp
M mythtv/libs/libmythtv/cardutil.cpp
M mythtv/libs/libmythtv/channelscan/channelscan_sm.cpp
M mythtv/libs/libmythtv/channelscan/iptvchannelfetcher.cpp
M mythtv/libs/libmythtv/channelscan/vboxchannelfetcher.cpp
M mythtv/libs/libmythtv/eithelper.cpp
M mythtv/libs/libmythtv/mhi.cpp
M mythtv/libs/libmythtv/playercontext.cpp
M mythtv/libs/libmythtv/previewgenerator.cpp
M mythtv/libs/libmythtv/previewgeneratorqueue.cpp
M mythtv/libs/libmythtv/recorders/asistreamhandler.cpp
M mythtv/libs/libmythtv/recorders/cetonrtsp.cpp
M mythtv/libs/libmythtv/recorders/dtvrecorder.cpp
M mythtv/libs/libmythtv/recorders/signalmonitor.cpp
M mythtv/libs/libmythtv/recorders/v4l2encstreamhandler.cpp
M mythtv/libs/libmythtv/recorders/v4lchannel.cpp
M mythtv/libs/libmythtv/recorders/vboxutils.cpp
M mythtv/libs/libmythtv/signalmonitorvalue.cpp
M mythtv/libs/libmythtv/tv_play.cpp
M mythtv/libs/libmythtv/videometadatautil.cpp
M mythtv/libs/libmythtv/videosource.cpp
M mythtv/libs/libmythui/mythmainwindow.cpp
M mythtv/libs/libmythui/mythuihelper.cpp
M mythtv/libs/libmythui/mythuistatetype.cpp
M mythtv/libs/libmythui/mythuitext.cpp
M mythtv/libs/libmythui/mythuiwebbrowser.cpp
M mythtv/libs/libmythupnp/serverSideScripting.cpp
M mythtv/programs/mythbackend/mainserver.cpp
M mythtv/programs/mythbackend/services/dvr.cpp
M mythtv/programs/mythbackend/services/guide.cpp
M mythtv/programs/mythfrontend/backendconnectionmanager.cpp
M mythtv/programs/mythfrontend/editvideometadata.cpp
M mythtv/programs/mythfrontend/galleryslideview.cpp
M mythtv/programs/mythfrontend/gallerythumbview.cpp
M mythtv/programs/mythfrontend/guidegrid.cpp
M mythtv/programs/mythfrontend/networkcontrol.cpp
M mythtv/programs/mythfrontend/playbackbox.cpp
M mythtv/programs/mythfrontend/playbackboxhelper.cpp
M mythtv/programs/mythfrontend/progfind.cpp
M mythtv/programs/mythfrontend/proglist.cpp
M mythtv/programs/mythfrontend/proglist_helpers.cpp
M mythtv/programs/mythfrontend/scheduleeditor.cpp
M mythtv/programs/mythfrontend/upnpscanner.cpp
M mythtv/programs/mythfrontend/videodlg.cpp
M mythtv/programs/mythfrontend/videofilter.cpp
M mythtv/programs/mythfrontend/videolist.cpp
M mythtv/programs/mythfrontend/viewscheduled.cpp
M mythtv/programs/mythtranscode/main.cpp
M mythtv/programs/mythutil/messageutils.cpp
Log Message:
-----------
tidy: Use const reference instead of copying objects.
The clang-tidy "unnecessary copy initialization" check pointed out a
number of places where copies of objects can be replaced by a const
reference to the object. Changes made by the clang-tidy program.
https://clang.llvm.org/extra/clang-tidy/checks/performance-unnecessary-copy-initialization.html
Commit: 9ab1d202a79527fb32753bbc1d79ee1ff32b7e8b
https://github.com/MythTV/mythtv/commit/9ab1d202a79527fb32753bbc1d79ee1ff32b7e8b
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-03 (Wed, 03 Apr 2019)
Changed paths:
M mythtv/programs/mythbackend/services/myth.cpp
Log Message:
-----------
tidy: Use const reference in a "for range" loop.
The clang-tidy "performance for range loop" check pointed out two
places where an object is copied for each iteration of a "for range"
loop. Replace these copies with a const reference to the object.
Changes made by the clang-tidy program.
https://clang.llvm.org/extra/clang-tidy/checks/performance-for-range-copy.html
Commit: 3251c0ce5e2fc4097d53045a087f215e660767c9
https://github.com/MythTV/mythtv/commit/3251c0ce5e2fc4097d53045a087f215e660767c9
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-04 (Thu, 04 Apr 2019)
Changed paths:
M mythtv/filters/adjust/filter_adjust.c
M mythtv/libs/libmythfreesurround/el_processor.cpp
M mythtv/libs/libmythtv/visualisations/goom/mathtools.h
M mythtv/libs/libmythtv/visualisations/goom/tentacle3d.c
Log Message:
-----------
tidy: Fix implicit float->double conversions.
The clang-tidy "type promotion in math function" check pointed out a
couple of places where floating point numbers are implicitly converted
to double precision numbers. Replace these calls to math functions
with functions that don't cause the implicit type promotion. Changes
made by the clang-tidy program.
https://clang.llvm.org/extra/clang-tidy/checks/performance-type-promotion-in-math-fn.html
Commit: 18669e373f8bb8462aaeb984d90038ea8c80297c
https://github.com/MythTV/mythtv/commit/18669e373f8bb8462aaeb984d90038ea8c80297c
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-04 (Thu, 04 Apr 2019)
Changed paths:
M mythplugins/mytharchive/mytharchive/dbcheck.cpp
M mythplugins/mytharchive/mytharchive/importnative.cpp
M mythplugins/mytharchive/mytharchive/importnative.h
M mythplugins/mytharchive/mytharchive/logviewer.cpp
M mythplugins/mytharchive/mytharchive/logviewer.h
M mythplugins/mytharchive/mytharchive/main.cpp
M mythplugins/mytharchive/mytharchive/mythburn.cpp
M mythplugins/mytharchive/mytharchive/mythburn.h
M mythplugins/mytharchive/mytharchive/selectdestination.cpp
M mythplugins/mytharchive/mytharchive/selectdestination.h
M mythplugins/mytharchive/mytharchive/themeselector.cpp
M mythplugins/mytharchive/mytharchive/themeselector.h
M mythplugins/mytharchive/mytharchivehelper/main.cpp
M mythplugins/mythbrowser/mythbrowser/bookmarkeditor.cpp
M mythplugins/mythbrowser/mythbrowser/bookmarkeditor.h
M mythplugins/mythbrowser/mythbrowser/browserdbutil.cpp
M mythplugins/mythgallery/dcrawplugin/dcrawhandler.cpp
M mythplugins/mythgallery/dcrawplugin/dcrawhandler.h
M mythplugins/mythgallery/mythgallery/dbcheck.cpp
M mythplugins/mythgallery/mythgallery/galleryfilter.cpp
M mythplugins/mythgallery/mythgallery/galleryfilter.h
M mythplugins/mythgallery/mythgallery/galleryfilterdlg.cpp
M mythplugins/mythgallery/mythgallery/galleryfilterdlg.h
M mythplugins/mythgallery/mythgallery/galleryutil.cpp
M mythplugins/mythgallery/mythgallery/galleryutil.h
M mythplugins/mythgallery/mythgallery/glsingleview.cpp
M mythplugins/mythgallery/mythgallery/glsingleview.h
M mythplugins/mythgallery/mythgallery/iconview.cpp
M mythplugins/mythgallery/mythgallery/iconview.h
M mythplugins/mythgallery/mythgallery/singleview.cpp
M mythplugins/mythgallery/mythgallery/singleview.h
M mythplugins/mythgame/mythgame/dbcheck.cpp
M mythplugins/mythgame/mythgame/gamehandler.cpp
M mythplugins/mythgame/mythgame/gamehandler.h
M mythplugins/mythgame/mythgame/gamescan.cpp
M mythplugins/mythgame/mythgame/gamesettings.cpp
M mythplugins/mythgame/mythgame/gamesettings.h
M mythplugins/mythgame/mythgame/gameui.cpp
M mythplugins/mythgame/mythgame/gameui.h
M mythplugins/mythgame/mythgame/main.cpp
M mythplugins/mythgame/mythgame/rom_metadata.cpp
M mythplugins/mythgame/mythgame/rom_metadata.h
M mythplugins/mythgame/mythgame/romedit.cpp
M mythplugins/mythgame/mythgame/romedit.h
M mythplugins/mythgame/mythgame/rominfo.cpp
M mythplugins/mythgame/mythgame/rominfo.h
M mythplugins/mythmusic/mythmusic/cdrip.cpp
M mythplugins/mythmusic/mythmusic/cdrip.h
M mythplugins/mythmusic/mythmusic/dbcheck.cpp
M mythplugins/mythmusic/mythmusic/editmetadata.cpp
M mythplugins/mythmusic/mythmusic/editmetadata.h
M mythplugins/mythmusic/mythmusic/importmusic.cpp
M mythplugins/mythmusic/mythmusic/importmusic.h
M mythplugins/mythmusic/mythmusic/main.cpp
M mythplugins/mythmusic/mythmusic/playlist.cpp
M mythplugins/mythmusic/mythmusic/playlist.h
M mythplugins/mythmusic/mythmusic/playlistcontainer.cpp
M mythplugins/mythmusic/mythmusic/playlistcontainer.h
M mythplugins/mythmusic/mythmusic/smartplaylist.cpp
M mythplugins/mythmusic/mythmusic/smartplaylist.h
M mythplugins/mythmusic/mythmusic/visualize.cpp
M mythplugins/mythmusic/mythmusic/visualize.h
M mythplugins/mythnetvision/mythnetvision/netcommon.cpp
M mythplugins/mythnetvision/mythnetvision/netcommon.h
M mythplugins/mythnetvision/mythnetvision/neteditorbase.cpp
M mythplugins/mythnetvision/mythnetvision/neteditorbase.h
M mythplugins/mythnetvision/mythnetvision/nettree.cpp
M mythplugins/mythnetvision/mythnetvision/nettree.h
M mythplugins/mythnews/mythnews/dbcheck.cpp
M mythplugins/mythnews/mythnews/newssite.cpp
M mythplugins/mythnews/mythnews/newssite.h
M mythplugins/mythweather/mythweather/dbcheck.cpp
M mythplugins/mythweather/mythweather/weatherSource.cpp
M mythplugins/mythweather/mythweather/weatherSource.h
M mythplugins/mythweather/mythweather/weatherUtils.cpp
M mythplugins/mythweather/mythweather/weatherUtils.h
M mythplugins/mythzoneminder/mythzmserver/zmserver.cpp
M mythplugins/mythzoneminder/mythzmserver/zmserver.h
M mythplugins/mythzoneminder/mythzoneminder/main.cpp
Log Message:
-----------
tidy: Eliminate unnecessary copying of objects. (plugins)
The clang-tidy "unnecessary value param" check pointed out many places
where objects were passed by copying when they could be passed by
const reference. The vast majority of these fixes convert a QString
object into a const QString& reference. There are also a number of
other objects that get passed by reference instead of copying.
This check also added '::std::move' to a number of object uses. If
the last reference to an object is to assign that object to a variable
or to use it as a parameter in a function call, then its a waste of
cycles to duplicate the object for the operation. Just pass ownership
of the already existing object to the target of the operation.
Changes made by the clang-tidy program.
https://clang.llvm.org/extra/clang-tidy/checks/performance-unnecessary-value-param.html
Commit: 49e987798ace7d125496cbf874b6bcf43791c8fa
https://github.com/MythTV/mythtv/commit/49e987798ace7d125496cbf874b6bcf43791c8fa
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-04 (Thu, 04 Apr 2019)
Changed paths:
M mythtv/libs/libmyth/audio/spdifencoder.cpp
M mythtv/libs/libmyth/audio/spdifencoder.h
M mythtv/libs/libmyth/backendselect.cpp
M mythtv/libs/libmyth/backendselect.h
M mythtv/libs/libmyth/mediamonitor-unix.cpp
M mythtv/libs/libmyth/mediamonitor-unix.h
M mythtv/libs/libmyth/mythmediamonitor.cpp
M mythtv/libs/libmyth/mythterminal.cpp
M mythtv/libs/libmyth/netgrabbermanager.cpp
M mythtv/libs/libmyth/netutils.cpp
M mythtv/libs/libmyth/netutils.h
M mythtv/libs/libmyth/programinfo.cpp
M mythtv/libs/libmyth/programinfo.h
M mythtv/libs/libmyth/recordingtypes.cpp
M mythtv/libs/libmyth/recordingtypes.h
M mythtv/libs/libmyth/remoteutil.cpp
M mythtv/libs/libmyth/remoteutil.h
M mythtv/libs/libmyth/rssparse.cpp
M mythtv/libs/libmyth/rssparse.h
M mythtv/libs/libmyth/schemawizard.cpp
M mythtv/libs/libmyth/standardsettings.cpp
M mythtv/libs/libmyth/storagegroupeditor.cpp
M mythtv/libs/libmyth/storagegroupeditor.h
M mythtv/libs/libmythbase/dbutil.cpp
M mythtv/libs/libmythbase/dbutil.h
M mythtv/libs/libmythbase/filesysteminfo.cpp
M mythtv/libs/libmythbase/filesysteminfo.h
M mythtv/libs/libmythbase/housekeeper.cpp
M mythtv/libs/libmythbase/logging.cpp
M mythtv/libs/libmythbase/loggingserver.cpp
M mythtv/libs/libmythbase/loggingserver.h
M mythtv/libs/libmythbase/mthreadpool.cpp
M mythtv/libs/libmythbase/mthreadpool.h
M mythtv/libs/libmythbase/mythcommandlineparser.cpp
M mythtv/libs/libmythbase/mythcommandlineparser.h
M mythtv/libs/libmythbase/mythcorecontext.cpp
M mythtv/libs/libmythbase/mythcorecontext.h
M mythtv/libs/libmythbase/mythdbcon.cpp
M mythtv/libs/libmythbase/mythdbcon.h
M mythtv/libs/libmythbase/mythlogging.h
M mythtv/libs/libmythbase/mythmiscutil.cpp
M mythtv/libs/libmythbase/mythmiscutil.h
M mythtv/libs/libmythbase/mythsocket.cpp
M mythtv/libs/libmythbase/mythsocket.h
M mythtv/libs/libmythbase/mythsystem.cpp
M mythtv/libs/libmythbase/mythsystem.h
M mythtv/libs/libmythbase/mythtimezone.cpp
M mythtv/libs/libmythbase/remotefile.cpp
M mythtv/libs/libmythbase/remotefile.h
M mythtv/libs/libmythbase/serverpool.cpp
M mythtv/libs/libmythbase/threadedfilewriter.cpp
M mythtv/libs/libmythbase/threadedfilewriter.h
M mythtv/libs/libmythfreemheg/Engine.cpp
M mythtv/libs/libmythfreemheg/Engine.h
M mythtv/libs/libmythfreemheg/Logging.h
M mythtv/libs/libmythmetadata/imagemanager.cpp
M mythtv/libs/libmythmetadata/imagemanager.h
M mythtv/libs/libmythmetadata/metadatacommon.cpp
M mythtv/libs/libmythmetadata/metadatacommon.h
M mythtv/libs/libmythmetadata/metadatadownload.cpp
M mythtv/libs/libmythmetadata/metadatadownload.h
M mythtv/libs/libmythmetadata/metadatafactory.cpp
M mythtv/libs/libmythmetadata/metadatafactory.h
M mythtv/libs/libmythmetadata/metadatagrabber.cpp
M mythtv/libs/libmythmetadata/metadataimagedownload.cpp
M mythtv/libs/libmythmetadata/metadataimagedownload.h
M mythtv/libs/libmythmetadata/musicmetadata.cpp
M mythtv/libs/libmythmetadata/musicmetadata.h
M mythtv/libs/libmythmetadata/mythuiimageresults.cpp
M mythtv/libs/libmythmetadata/mythuiimageresults.h
M mythtv/libs/libmythmetadata/parentalcontrols.cpp
M mythtv/libs/libmythmetadata/videometadatalistmanager.cpp
M mythtv/libs/libmythmetadata/videoscan.cpp
M mythtv/libs/libmythmetadata/videoutils.cpp
M mythtv/libs/libmythmetadata/videoutils.h
M mythtv/libs/libmythprotoserver/requesthandler/deletethread.cpp
M mythtv/libs/libmythprotoserver/requesthandler/deletethread.h
M mythtv/libs/libmythprotoserver/requesthandler/fileserverhandler.cpp
M mythtv/libs/libmythprotoserver/requesthandler/fileserverhandler.h
M mythtv/libs/libmythprotoserver/requesthandler/fileserverutil.cpp
M mythtv/libs/libmythprotoserver/requesthandler/fileserverutil.h
M mythtv/libs/libmythprotoserver/sockethandler.cpp
M mythtv/libs/libmythprotoserver/sockethandler/filetransfer.cpp
M mythtv/libs/libmythtv/AirPlay/mythairplayserver.cpp
M mythtv/libs/libmythtv/AirPlay/mythairplayserver.h
M mythtv/libs/libmythtv/AirPlay/mythraopconnection.cpp
M mythtv/libs/libmythtv/AirPlay/mythraopconnection.h
M mythtv/libs/libmythtv/HLS/httplivestream.cpp
M mythtv/libs/libmythtv/HLS/httplivestream.h
M mythtv/libs/libmythtv/avformatwriter.cpp
M mythtv/libs/libmythtv/avformatwriter.h
M mythtv/libs/libmythtv/cardutil.cpp
M mythtv/libs/libmythtv/cardutil.h
M mythtv/libs/libmythtv/channelgroup.cpp
M mythtv/libs/libmythtv/channelgroup.h
M mythtv/libs/libmythtv/channelscan/channelimporter.cpp
M mythtv/libs/libmythtv/channelscan/channelimporter.h
M mythtv/libs/libmythtv/channelscan/scanwizardconfig.cpp
M mythtv/libs/libmythtv/channelutil.cpp
M mythtv/libs/libmythtv/channelutil.h
M mythtv/libs/libmythtv/deletemap.cpp
M mythtv/libs/libmythtv/deletemap.h
M mythtv/libs/libmythtv/dtvmultiplex.cpp
M mythtv/libs/libmythtv/dtvmultiplex.h
M mythtv/libs/libmythtv/eithelper.cpp
M mythtv/libs/libmythtv/fifowriter.cpp
M mythtv/libs/libmythtv/fifowriter.h
M mythtv/libs/libmythtv/filtermanager.cpp
M mythtv/libs/libmythtv/filtermanager.h
M mythtv/libs/libmythtv/frequencytables.cpp
M mythtv/libs/libmythtv/frequencytables.h
M mythtv/libs/libmythtv/interactivetv.cpp
M mythtv/libs/libmythtv/jobqueue.cpp
M mythtv/libs/libmythtv/jobqueue.h
M mythtv/libs/libmythtv/livetvchain.cpp
M mythtv/libs/libmythtv/livetvchain.h
M mythtv/libs/libmythtv/metadataimagehelper.cpp
M mythtv/libs/libmythtv/metadataimagehelper.h
M mythtv/libs/libmythtv/mhi.cpp
M mythtv/libs/libmythtv/mhi.h
M mythtv/libs/libmythtv/mpeg/mpegdescriptors.cpp
M mythtv/libs/libmythtv/mpeg/mpegtables.cpp
M mythtv/libs/libmythtv/mpeg/mpegtables.h
M mythtv/libs/libmythtv/mpeg/scanstreamdata.cpp
M mythtv/libs/libmythtv/mpeg/scanstreamdata.h
M mythtv/libs/libmythtv/mythcodeccontext.cpp
M mythtv/libs/libmythtv/mythcodeccontext.h
M mythtv/libs/libmythtv/mythplayer.cpp
M mythtv/libs/libmythtv/mythplayer.h
M mythtv/libs/libmythtv/mythsystemevent.cpp
M mythtv/libs/libmythtv/openglvideo.cpp
M mythtv/libs/libmythtv/openglvideo.h
M mythtv/libs/libmythtv/osd.cpp
M mythtv/libs/libmythtv/osd.h
M mythtv/libs/libmythtv/playgroup.cpp
M mythtv/libs/libmythtv/previewgeneratorqueue.cpp
M mythtv/libs/libmythtv/previewgeneratorqueue.h
M mythtv/libs/libmythtv/recorders/audioinputalsa.cpp
M mythtv/libs/libmythtv/recorders/audioinputalsa.h
M mythtv/libs/libmythtv/recorders/httptsstreamhandler.cpp
M mythtv/libs/libmythtv/recorders/httptsstreamhandler.h
M mythtv/libs/libmythtv/recorders/signalmonitor.cpp
M mythtv/libs/libmythtv/recorders/signalmonitor.h
M mythtv/libs/libmythtv/recorders/streamhandler.cpp
M mythtv/libs/libmythtv/recorders/v4lchannel.cpp
M mythtv/libs/libmythtv/recorders/v4lchannel.h
M mythtv/libs/libmythtv/recordinginfo.cpp
M mythtv/libs/libmythtv/recordinginfo.h
M mythtv/libs/libmythtv/recordingprofile.cpp
M mythtv/libs/libmythtv/recordingprofile.h
M mythtv/libs/libmythtv/recordingrule.cpp
M mythtv/libs/libmythtv/recordingrule.h
M mythtv/libs/libmythtv/remoteencoder.cpp
M mythtv/libs/libmythtv/remoteencoder.h
M mythtv/libs/libmythtv/scanwizard.cpp
M mythtv/libs/libmythtv/scanwizard.h
M mythtv/libs/libmythtv/sourceutil.cpp
M mythtv/libs/libmythtv/sourceutil.h
M mythtv/libs/libmythtv/subtitlereader.cpp
M mythtv/libs/libmythtv/subtitlereader.h
M mythtv/libs/libmythtv/subtitlescreen.cpp
M mythtv/libs/libmythtv/subtitlescreen.h
M mythtv/libs/libmythtv/test/test_eitfixups/test_eitfixups.cpp
M mythtv/libs/libmythtv/test/test_eitfixups/test_eitfixups.h
M mythtv/libs/libmythtv/transporteditor.cpp
M mythtv/libs/libmythtv/tv_play.cpp
M mythtv/libs/libmythtv/tv_play.h
M mythtv/libs/libmythtv/tv_rec.cpp
M mythtv/libs/libmythtv/tv_rec.h
M mythtv/libs/libmythtv/tvbrowsehelper.cpp
M mythtv/libs/libmythtv/tvbrowsehelper.h
M mythtv/libs/libmythtv/videodisplayprofile.cpp
M mythtv/libs/libmythtv/videodisplayprofile.h
M mythtv/libs/libmythtv/videosource.cpp
M mythtv/libs/libmythtv/videosource.h
M mythtv/libs/libmythui/jsmenu.cpp
M mythtv/libs/libmythui/jsmenu.h
M mythtv/libs/libmythui/mythdialogbox.cpp
M mythtv/libs/libmythui/mythdialogbox.h
M mythtv/libs/libmythui/mythmainwindow.cpp
M mythtv/libs/libmythui/mythmainwindow.h
M mythtv/libs/libmythui/mythrender_vdpau.cpp
M mythtv/libs/libmythui/mythscreentype.cpp
M mythtv/libs/libmythui/mythscreentype.h
M mythtv/libs/libmythui/mythudplistener.cpp
M mythtv/libs/libmythui/mythudplistener.h
M mythtv/libs/libmythui/mythuibutton.cpp
M mythtv/libs/libmythui/mythuibutton.h
M mythtv/libs/libmythui/mythuibuttonlist.cpp
M mythtv/libs/libmythui/mythuibuttonlist.h
M mythtv/libs/libmythui/mythuibuttontree.cpp
M mythtv/libs/libmythui/mythuifilebrowser.cpp
M mythtv/libs/libmythui/mythuifilebrowser.h
M mythtv/libs/libmythui/mythuihelper.cpp
M mythtv/libs/libmythui/mythuihelper.h
M mythtv/libs/libmythui/mythuiimage.cpp
M mythtv/libs/libmythui/mythuishape.cpp
M mythtv/libs/libmythui/mythuispinbox.cpp
M mythtv/libs/libmythui/mythuitext.cpp
M mythtv/libs/libmythui/mythuitext.h
M mythtv/libs/libmythui/mythuitype.cpp
M mythtv/libs/libmythui/mythuiwebbrowser.cpp
M mythtv/libs/libmythui/mythuiwebbrowser.h
M mythtv/libs/libmythui/mythvirtualkeyboard.cpp
M mythtv/libs/libmythui/mythvirtualkeyboard.h
M mythtv/libs/libmythui/themeinfo.cpp
M mythtv/libs/libmythui/themeinfo.h
M mythtv/libs/libmythupnp/bufferedsocketdevice.cpp
M mythtv/libs/libmythupnp/httprequest.cpp
M mythtv/libs/libmythupnp/httprequest.h
M mythtv/libs/libmythupnp/httpserver.cpp
M mythtv/libs/libmythupnp/httpserver.h
M mythtv/libs/libmythupnp/mmulticastsocketdevice.cpp
M mythtv/libs/libmythupnp/mmulticastsocketdevice.h
M mythtv/libs/libmythupnp/serializers/serializer.cpp
M mythtv/libs/libmythupnp/serializers/serializer.h
M mythtv/libs/libmythupnp/ssdp.cpp
M mythtv/libs/libmythupnp/ssdp.h
M mythtv/libs/libmythupnp/upnpcdsobjects.cpp
M mythtv/libs/libmythupnp/upnpcdsobjects.h
M mythtv/libs/libmythupnp/upnpdevice.cpp
M mythtv/libs/libmythupnp/upnpdevice.h
M mythtv/libs/libmythupnp/upnpsubscription.cpp
M mythtv/libs/libmythupnp/upnptaskevent.cpp
M mythtv/libs/libmythupnp/upnptasknotify.cpp
M mythtv/libs/libmythupnp/upnptasknotify.h
M mythtv/libs/libmythupnp/upnptasksearch.cpp
M mythtv/libs/libmythupnp/upnptasksearch.h
M mythtv/libs/libmythupnp/websocket.cpp
M mythtv/libs/libmythupnp/websocket.h
M mythtv/libs/libmythupnp/wsdl.cpp
M mythtv/libs/libmythupnp/wsdl.h
M mythtv/libs/libmythupnp/xsd.cpp
M mythtv/libs/libmythupnp/xsd.h
Log Message:
-----------
tidy: Eliminate unnecessary copying of objects. (libs)
The clang-tidy "unnecessary value param" check pointed out many places
where objects were passed by copying when they could be passed by
const reference. The vast majority of these fixes convert a QString
object into a const QString& reference. There are also a number of
other objects that get passed by reference instead of copying.
This check also added '::std::move' to a number of object uses. If
the last reference to an object is to assign that object to a variable
or to use it as a parameter in a function call, then its a waste of
cycles to duplicate the object for the operation. Just pass ownership
of the already existing object to the target of the operation.
Changes made by the clang-tidy program.
https://clang.llvm.org/extra/clang-tidy/checks/performance-unnecessary-value-param.html
Commit: 541281f5d674fbb52d8dc6f40333a6e02eafbf50
https://github.com/MythTV/mythtv/commit/541281f5d674fbb52d8dc6f40333a6e02eafbf50
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-04 (Thu, 04 Apr 2019)
Changed paths:
M mythtv/programs/mythbackend/autoexpire.cpp
M mythtv/programs/mythbackend/autoexpire.h
M mythtv/programs/mythbackend/encoderlink.cpp
M mythtv/programs/mythbackend/encoderlink.h
M mythtv/programs/mythbackend/filetransfer.cpp
M mythtv/programs/mythbackend/httpstatus.cpp
M mythtv/programs/mythbackend/httpstatus.h
M mythtv/programs/mythbackend/mainserver.cpp
M mythtv/programs/mythbackend/mainserver.h
M mythtv/programs/mythbackend/playbacksock.cpp
M mythtv/programs/mythbackend/playbacksock.h
M mythtv/programs/mythbackend/scheduler.cpp
M mythtv/programs/mythbackend/scheduler.h
M mythtv/programs/mythbackend/services/guide.h
M mythtv/programs/mythbackend/services/myth.h
M mythtv/programs/mythbackend/services/serviceUtil.cpp
M mythtv/programs/mythbackend/services/serviceUtil.h
M mythtv/programs/mythbackend/upnpcdsmusic.cpp
M mythtv/programs/mythbackend/upnpcdsmusic.h
M mythtv/programs/mythbackend/upnpcdstv.cpp
M mythtv/programs/mythbackend/upnpcdstv.h
M mythtv/programs/mythbackend/upnpcdsvideo.cpp
M mythtv/programs/mythbackend/upnpcdsvideo.h
M mythtv/programs/mythcommflag/BlankFrameDetector.cpp
M mythtv/programs/mythcommflag/CommDetector2.cpp
M mythtv/programs/mythcommflag/CommDetector2.h
M mythtv/programs/mythcommflag/HistogramAnalyzer.cpp
M mythtv/programs/mythcommflag/HistogramAnalyzer.h
M mythtv/programs/mythcommflag/SceneChangeDetector.cpp
M mythtv/programs/mythcommflag/SceneChangeDetector.h
M mythtv/programs/mythcommflag/TemplateFinder.cpp
M mythtv/programs/mythcommflag/TemplateFinder.h
M mythtv/programs/mythcommflag/TemplateMatcher.cpp
M mythtv/programs/mythcommflag/TemplateMatcher.h
M mythtv/programs/mythcommflag/main.cpp
M mythtv/programs/mythfilldatabase/channeldata.cpp
M mythtv/programs/mythfilldatabase/filldata.cpp
M mythtv/programs/mythfilldatabase/filldata.h
M mythtv/programs/mythfilldatabase/xmltvparser.cpp
M mythtv/programs/mythfilldatabase/xmltvparser.h
M mythtv/programs/mythfrontend/audiogeneralsettings.cpp
M mythtv/programs/mythfrontend/channelrecpriority.cpp
M mythtv/programs/mythfrontend/channelrecpriority.h
M mythtv/programs/mythfrontend/editvideometadata.cpp
M mythtv/programs/mythfrontend/editvideometadata.h
M mythtv/programs/mythfrontend/galleryconfig.cpp
M mythtv/programs/mythfrontend/galleryinfo.cpp
M mythtv/programs/mythfrontend/galleryinfo.h
M mythtv/programs/mythfrontend/galleryslide.cpp
M mythtv/programs/mythfrontend/galleryslide.h
M mythtv/programs/mythfrontend/galleryslideview.cpp
M mythtv/programs/mythfrontend/gallerythumbview.cpp
M mythtv/programs/mythfrontend/gallerythumbview.h
M mythtv/programs/mythfrontend/gallerytransitions.cpp
M mythtv/programs/mythfrontend/gallerytransitions.h
M mythtv/programs/mythfrontend/globalsettings.cpp
M mythtv/programs/mythfrontend/globalsettings.h
M mythtv/programs/mythfrontend/guidegrid.cpp
M mythtv/programs/mythfrontend/guidegrid.h
M mythtv/programs/mythfrontend/main.cpp
M mythtv/programs/mythfrontend/mythcontrols.cpp
M mythtv/programs/mythfrontend/mythcontrols.h
M mythtv/programs/mythfrontend/networkcontrol.cpp
M mythtv/programs/mythfrontend/networkcontrol.h
M mythtv/programs/mythfrontend/playbackbox.cpp
M mythtv/programs/mythfrontend/playbackbox.h
M mythtv/programs/mythfrontend/progdetails.cpp
M mythtv/programs/mythfrontend/progdetails.h
M mythtv/programs/mythfrontend/proginfolist.cpp
M mythtv/programs/mythfrontend/proginfolist.h
M mythtv/programs/mythfrontend/proglist.cpp
M mythtv/programs/mythfrontend/proglist.h
M mythtv/programs/mythfrontend/scheduleeditor.cpp
M mythtv/programs/mythfrontend/scheduleeditor.h
M mythtv/programs/mythfrontend/setupwizard_general.cpp
M mythtv/programs/mythfrontend/setupwizard_general.h
M mythtv/programs/mythfrontend/setupwizard_video.cpp
M mythtv/programs/mythfrontend/setupwizard_video.h
M mythtv/programs/mythfrontend/statusbox.cpp
M mythtv/programs/mythfrontend/statusbox.h
M mythtv/programs/mythfrontend/themechooser.cpp
M mythtv/programs/mythfrontend/themechooser.h
M mythtv/programs/mythfrontend/upnpscanner.cpp
M mythtv/programs/mythfrontend/videodlg.cpp
M mythtv/programs/mythfrontend/videodlg.h
M mythtv/programs/mythfrontend/videofileassoc.cpp
M mythtv/programs/mythfrontend/videofilter.cpp
M mythtv/programs/mythfrontend/videofilter.h
M mythtv/programs/mythfrontend/videolist.cpp
M mythtv/programs/mythlcdserver/lcdprocclient.cpp
M mythtv/programs/mythlcdserver/lcdprocclient.h
M mythtv/programs/mythlcdserver/lcdserver.cpp
M mythtv/programs/mythlcdserver/lcdserver.h
M mythtv/programs/mythshutdown/main.cpp
M mythtv/programs/mythtranscode/main.cpp
M mythtv/programs/mythtranscode/mpeg2fix.cpp
M mythtv/programs/mythtranscode/mpeg2fix.h
M mythtv/programs/mythtranscode/transcode.cpp
M mythtv/programs/mythtranscode/transcode.h
M mythtv/programs/mythtv-setup/importicons.cpp
M mythtv/programs/mythtv-setup/importicons.h
M mythtv/programs/mythtv-setup/main.cpp
M mythtv/programs/mythwelcome/welcomesettings.cpp
Log Message:
-----------
tidy: Eliminate unnecessary copying of objects. (programs)
The clang-tidy "unnecessary value param" check pointed out many places
where objects were passed by copying when they could be passed by
const reference. The vast majority of these fixes convert a QString
object into a const QString& reference. There are also a number of
other objects that get passed by reference instead of copying.
This check also added '::std::move' to a number of object uses. If
the last reference to an object is to assign that object to a variable
or to use it as a parameter in a function call, then its a waste of
cycles to duplicate the object for the operation. Just pass ownership
of the already existing object to the target of the operation.
Changes made by the clang-tidy program.
https://clang.llvm.org/extra/clang-tidy/checks/performance-unnecessary-value-param.html
Commit: faf56a44ec072f9ee58ac31ba2c9fc04e9195de1
https://github.com/MythTV/mythtv/commit/faf56a44ec072f9ee58ac31ba2c9fc04e9195de1
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-04 (Thu, 04 Apr 2019)
Changed paths:
M .clang-tidy
Log Message:
-----------
Updates to the working .clang-tidy file.
Commit: cb876be4607b34b7d4d005b25d88deefdb10a43f
https://github.com/MythTV/mythtv/commit/cb876be4607b34b7d4d005b25d88deefdb10a43f
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-04 (Thu, 04 Apr 2019)
Changed paths:
M .clang-tidy
M mythplugins/mytharchive/mytharchive/dbcheck.cpp
M mythplugins/mytharchive/mytharchive/importnative.cpp
M mythplugins/mytharchive/mytharchive/importnative.h
M mythplugins/mytharchive/mytharchive/logviewer.cpp
M mythplugins/mytharchive/mytharchive/logviewer.h
M mythplugins/mytharchive/mytharchive/main.cpp
M mythplugins/mytharchive/mytharchive/mythburn.cpp
M mythplugins/mytharchive/mytharchive/mythburn.h
M mythplugins/mytharchive/mytharchive/selectdestination.cpp
M mythplugins/mytharchive/mytharchive/selectdestination.h
M mythplugins/mytharchive/mytharchive/themeselector.cpp
M mythplugins/mytharchive/mytharchive/themeselector.h
M mythplugins/mytharchive/mytharchivehelper/main.cpp
M mythplugins/mythbrowser/mythbrowser/bookmarkeditor.cpp
M mythplugins/mythbrowser/mythbrowser/bookmarkeditor.h
M mythplugins/mythbrowser/mythbrowser/browserdbutil.cpp
M mythplugins/mythgallery/dcrawplugin/dcrawhandler.cpp
M mythplugins/mythgallery/dcrawplugin/dcrawhandler.h
M mythplugins/mythgallery/mythgallery/dbcheck.cpp
M mythplugins/mythgallery/mythgallery/galleryfilter.cpp
M mythplugins/mythgallery/mythgallery/galleryfilter.h
M mythplugins/mythgallery/mythgallery/galleryfilterdlg.cpp
M mythplugins/mythgallery/mythgallery/galleryfilterdlg.h
M mythplugins/mythgallery/mythgallery/galleryutil.cpp
M mythplugins/mythgallery/mythgallery/galleryutil.h
M mythplugins/mythgallery/mythgallery/glsingleview.cpp
M mythplugins/mythgallery/mythgallery/glsingleview.h
M mythplugins/mythgallery/mythgallery/iconview.cpp
M mythplugins/mythgallery/mythgallery/iconview.h
M mythplugins/mythgallery/mythgallery/singleview.cpp
M mythplugins/mythgallery/mythgallery/singleview.h
M mythplugins/mythgame/mythgame/dbcheck.cpp
M mythplugins/mythgame/mythgame/gamehandler.cpp
M mythplugins/mythgame/mythgame/gamehandler.h
M mythplugins/mythgame/mythgame/gamescan.cpp
M mythplugins/mythgame/mythgame/gamesettings.cpp
M mythplugins/mythgame/mythgame/gamesettings.h
M mythplugins/mythgame/mythgame/gameui.cpp
M mythplugins/mythgame/mythgame/gameui.h
M mythplugins/mythgame/mythgame/main.cpp
M mythplugins/mythgame/mythgame/rom_metadata.cpp
M mythplugins/mythgame/mythgame/rom_metadata.h
M mythplugins/mythgame/mythgame/romedit.cpp
M mythplugins/mythgame/mythgame/romedit.h
M mythplugins/mythgame/mythgame/rominfo.cpp
M mythplugins/mythgame/mythgame/rominfo.h
M mythplugins/mythmusic/mythmusic/cdrip.cpp
M mythplugins/mythmusic/mythmusic/cdrip.h
M mythplugins/mythmusic/mythmusic/dbcheck.cpp
M mythplugins/mythmusic/mythmusic/editmetadata.cpp
M mythplugins/mythmusic/mythmusic/editmetadata.h
M mythplugins/mythmusic/mythmusic/importmusic.cpp
M mythplugins/mythmusic/mythmusic/importmusic.h
M mythplugins/mythmusic/mythmusic/main.cpp
M mythplugins/mythmusic/mythmusic/playlist.cpp
M mythplugins/mythmusic/mythmusic/playlist.h
M mythplugins/mythmusic/mythmusic/playlistcontainer.cpp
M mythplugins/mythmusic/mythmusic/playlistcontainer.h
M mythplugins/mythmusic/mythmusic/smartplaylist.cpp
M mythplugins/mythmusic/mythmusic/smartplaylist.h
M mythplugins/mythmusic/mythmusic/visualize.cpp
M mythplugins/mythmusic/mythmusic/visualize.h
M mythplugins/mythnetvision/mythnetvision/netbase.cpp
M mythplugins/mythnetvision/mythnetvision/netcommon.cpp
M mythplugins/mythnetvision/mythnetvision/netcommon.h
M mythplugins/mythnetvision/mythnetvision/neteditorbase.cpp
M mythplugins/mythnetvision/mythnetvision/neteditorbase.h
M mythplugins/mythnetvision/mythnetvision/nettree.cpp
M mythplugins/mythnetvision/mythnetvision/nettree.h
M mythplugins/mythnetvision/mythnetvision/rsseditor.cpp
M mythplugins/mythnews/mythnews/dbcheck.cpp
M mythplugins/mythnews/mythnews/mythnews.cpp
M mythplugins/mythnews/mythnews/newssite.cpp
M mythplugins/mythnews/mythnews/newssite.h
M mythplugins/mythweather/mythweather/dbcheck.cpp
M mythplugins/mythweather/mythweather/weatherSource.cpp
M mythplugins/mythweather/mythweather/weatherSource.h
M mythplugins/mythweather/mythweather/weatherUtils.cpp
M mythplugins/mythweather/mythweather/weatherUtils.h
M mythplugins/mythzoneminder/mythzmserver/main.cpp
M mythplugins/mythzoneminder/mythzmserver/zmserver.cpp
M mythplugins/mythzoneminder/mythzmserver/zmserver.h
M mythplugins/mythzoneminder/mythzoneminder/main.cpp
M mythplugins/mythzoneminder/mythzoneminder/zmclient.cpp
M mythplugins/mythzoneminder/mythzoneminder/zmliveplayer.cpp
M mythtv/filters/adjust/filter_adjust.c
M mythtv/libs/libmyth/audio/audiooutput.cpp
M mythtv/libs/libmyth/audio/spdifencoder.cpp
M mythtv/libs/libmyth/audio/spdifencoder.h
M mythtv/libs/libmyth/backendselect.cpp
M mythtv/libs/libmyth/backendselect.h
M mythtv/libs/libmyth/mediamonitor-unix.cpp
M mythtv/libs/libmyth/mediamonitor-unix.h
M mythtv/libs/libmyth/mythmediamonitor.cpp
M mythtv/libs/libmyth/mythterminal.cpp
M mythtv/libs/libmyth/netgrabbermanager.cpp
M mythtv/libs/libmyth/netutils.cpp
M mythtv/libs/libmyth/netutils.h
M mythtv/libs/libmyth/programinfo.cpp
M mythtv/libs/libmyth/programinfo.h
M mythtv/libs/libmyth/programtypes.cpp
M mythtv/libs/libmyth/recordingtypes.cpp
M mythtv/libs/libmyth/recordingtypes.h
M mythtv/libs/libmyth/remoteutil.cpp
M mythtv/libs/libmyth/remoteutil.h
M mythtv/libs/libmyth/rssparse.cpp
M mythtv/libs/libmyth/rssparse.h
M mythtv/libs/libmyth/schemawizard.cpp
M mythtv/libs/libmyth/standardsettings.cpp
M mythtv/libs/libmyth/storagegroupeditor.cpp
M mythtv/libs/libmyth/storagegroupeditor.h
M mythtv/libs/libmythbase/dbutil.cpp
M mythtv/libs/libmythbase/dbutil.h
M mythtv/libs/libmythbase/filesysteminfo.cpp
M mythtv/libs/libmythbase/filesysteminfo.h
M mythtv/libs/libmythbase/housekeeper.cpp
M mythtv/libs/libmythbase/logging.cpp
M mythtv/libs/libmythbase/loggingserver.cpp
M mythtv/libs/libmythbase/loggingserver.h
M mythtv/libs/libmythbase/mthreadpool.cpp
M mythtv/libs/libmythbase/mthreadpool.h
M mythtv/libs/libmythbase/mythcommandlineparser.cpp
M mythtv/libs/libmythbase/mythcommandlineparser.h
M mythtv/libs/libmythbase/mythcorecontext.cpp
M mythtv/libs/libmythbase/mythcorecontext.h
M mythtv/libs/libmythbase/mythdate.cpp
M mythtv/libs/libmythbase/mythdb.cpp
M mythtv/libs/libmythbase/mythdbcon.cpp
M mythtv/libs/libmythbase/mythdbcon.h
M mythtv/libs/libmythbase/mythlogging.h
M mythtv/libs/libmythbase/mythmiscutil.cpp
M mythtv/libs/libmythbase/mythmiscutil.h
M mythtv/libs/libmythbase/mythsocket.cpp
M mythtv/libs/libmythbase/mythsocket.h
M mythtv/libs/libmythbase/mythsystem.cpp
M mythtv/libs/libmythbase/mythsystem.h
M mythtv/libs/libmythbase/mythsystemlegacy.cpp
M mythtv/libs/libmythbase/mythtimezone.cpp
M mythtv/libs/libmythbase/remotefile.cpp
M mythtv/libs/libmythbase/remotefile.h
M mythtv/libs/libmythbase/serverpool.cpp
M mythtv/libs/libmythbase/threadedfilewriter.cpp
M mythtv/libs/libmythbase/threadedfilewriter.h
M mythtv/libs/libmythfreemheg/Engine.cpp
M mythtv/libs/libmythfreemheg/Engine.h
M mythtv/libs/libmythfreemheg/Logging.h
M mythtv/libs/libmythfreemheg/Stream.cpp
M mythtv/libs/libmythfreesurround/el_processor.cpp
M mythtv/libs/libmythmetadata/bluraymetadata.cpp
M mythtv/libs/libmythmetadata/dirscan.cpp
M mythtv/libs/libmythmetadata/imagemanager.cpp
M mythtv/libs/libmythmetadata/imagemanager.h
M mythtv/libs/libmythmetadata/metadatacommon.cpp
M mythtv/libs/libmythmetadata/metadatacommon.h
M mythtv/libs/libmythmetadata/metadatadownload.cpp
M mythtv/libs/libmythmetadata/metadatadownload.h
M mythtv/libs/libmythmetadata/metadatafactory.cpp
M mythtv/libs/libmythmetadata/metadatafactory.h
M mythtv/libs/libmythmetadata/metadatagrabber.cpp
M mythtv/libs/libmythmetadata/metadataimagedownload.cpp
M mythtv/libs/libmythmetadata/metadataimagedownload.h
M mythtv/libs/libmythmetadata/metaiomp4.cpp
M mythtv/libs/libmythmetadata/musicmetadata.cpp
M mythtv/libs/libmythmetadata/musicmetadata.h
M mythtv/libs/libmythmetadata/mythuiimageresults.cpp
M mythtv/libs/libmythmetadata/mythuiimageresults.h
M mythtv/libs/libmythmetadata/parentalcontrols.cpp
M mythtv/libs/libmythmetadata/videometadatalistmanager.cpp
M mythtv/libs/libmythmetadata/videoscan.cpp
M mythtv/libs/libmythmetadata/videoutils.cpp
M mythtv/libs/libmythmetadata/videoutils.h
M mythtv/libs/libmythmpeg2/cpu_state.c
M mythtv/libs/libmythprotoserver/requesthandler/deletethread.cpp
M mythtv/libs/libmythprotoserver/requesthandler/deletethread.h
M mythtv/libs/libmythprotoserver/requesthandler/fileserverhandler.cpp
M mythtv/libs/libmythprotoserver/requesthandler/fileserverhandler.h
M mythtv/libs/libmythprotoserver/requesthandler/fileserverutil.cpp
M mythtv/libs/libmythprotoserver/requesthandler/fileserverutil.h
M mythtv/libs/libmythprotoserver/sockethandler.cpp
M mythtv/libs/libmythprotoserver/sockethandler/filetransfer.cpp
M mythtv/libs/libmythtv/AirPlay/mythairplayserver.cpp
M mythtv/libs/libmythtv/AirPlay/mythairplayserver.h
M mythtv/libs/libmythtv/AirPlay/mythraopconnection.cpp
M mythtv/libs/libmythtv/AirPlay/mythraopconnection.h
M mythtv/libs/libmythtv/Bluray/bdiowrapper.cpp
M mythtv/libs/libmythtv/Bluray/bdringbuffer.cpp
M mythtv/libs/libmythtv/DVD/dvdringbuffer.cpp
M mythtv/libs/libmythtv/DVD/dvdringbuffer.h
M mythtv/libs/libmythtv/DVD/mythdvdplayer.cpp
M mythtv/libs/libmythtv/HLS/httplivestream.cpp
M mythtv/libs/libmythtv/HLS/httplivestream.h
M mythtv/libs/libmythtv/avformatdecoder.cpp
M mythtv/libs/libmythtv/avformatwriter.cpp
M mythtv/libs/libmythtv/avformatwriter.h
M mythtv/libs/libmythtv/cardutil.cpp
M mythtv/libs/libmythtv/cardutil.h
M mythtv/libs/libmythtv/channelgroup.cpp
M mythtv/libs/libmythtv/channelgroup.h
M mythtv/libs/libmythtv/channelscan/channelimporter.cpp
M mythtv/libs/libmythtv/channelscan/channelimporter.h
M mythtv/libs/libmythtv/channelscan/channelscan_sm.cpp
M mythtv/libs/libmythtv/channelscan/channelscanner_cli.cpp
M mythtv/libs/libmythtv/channelscan/iptvchannelfetcher.cpp
M mythtv/libs/libmythtv/channelscan/scanmonitor.h
M mythtv/libs/libmythtv/channelscan/scanwizardconfig.cpp
M mythtv/libs/libmythtv/channelscan/vboxchannelfetcher.cpp
M mythtv/libs/libmythtv/channelsettings.cpp
M mythtv/libs/libmythtv/channelutil.cpp
M mythtv/libs/libmythtv/channelutil.h
M mythtv/libs/libmythtv/dbcheck.cpp
M mythtv/libs/libmythtv/deletemap.cpp
M mythtv/libs/libmythtv/deletemap.h
M mythtv/libs/libmythtv/diseqc.cpp
M mythtv/libs/libmythtv/dtvmultiplex.cpp
M mythtv/libs/libmythtv/dtvmultiplex.h
M mythtv/libs/libmythtv/eitcache.cpp
M mythtv/libs/libmythtv/eitfixup.cpp
M mythtv/libs/libmythtv/eithelper.cpp
M mythtv/libs/libmythtv/fifowriter.cpp
M mythtv/libs/libmythtv/fifowriter.h
M mythtv/libs/libmythtv/filtermanager.cpp
M mythtv/libs/libmythtv/filtermanager.h
M mythtv/libs/libmythtv/frequencytables.cpp
M mythtv/libs/libmythtv/frequencytables.h
M mythtv/libs/libmythtv/inputinfo.cpp
M mythtv/libs/libmythtv/interactivetv.cpp
M mythtv/libs/libmythtv/jobqueue.cpp
M mythtv/libs/libmythtv/jobqueue.h
M mythtv/libs/libmythtv/livetvchain.cpp
M mythtv/libs/libmythtv/livetvchain.h
M mythtv/libs/libmythtv/metadataimagehelper.cpp
M mythtv/libs/libmythtv/metadataimagehelper.h
M mythtv/libs/libmythtv/mhi.cpp
M mythtv/libs/libmythtv/mhi.h
M mythtv/libs/libmythtv/mpeg/H264Parser.cpp
M mythtv/libs/libmythtv/mpeg/mpegdescriptors.cpp
M mythtv/libs/libmythtv/mpeg/mpegstreamdata.cpp
M mythtv/libs/libmythtv/mpeg/mpegtables.cpp
M mythtv/libs/libmythtv/mpeg/mpegtables.h
M mythtv/libs/libmythtv/mpeg/scanstreamdata.cpp
M mythtv/libs/libmythtv/mpeg/scanstreamdata.h
M mythtv/libs/libmythtv/mpeg/sctetables.cpp
M mythtv/libs/libmythtv/mythcodeccontext.cpp
M mythtv/libs/libmythtv/mythcodeccontext.h
M mythtv/libs/libmythtv/mythiowrapper.cpp
M mythtv/libs/libmythtv/mythplayer.cpp
M mythtv/libs/libmythtv/mythplayer.h
M mythtv/libs/libmythtv/mythsystemevent.cpp
M mythtv/libs/libmythtv/nuppeldecoder.cpp
M mythtv/libs/libmythtv/openglvideo.cpp
M mythtv/libs/libmythtv/openglvideo.h
M mythtv/libs/libmythtv/osd.cpp
M mythtv/libs/libmythtv/osd.h
M mythtv/libs/libmythtv/osdchromakey.cpp
M mythtv/libs/libmythtv/playercontext.cpp
M mythtv/libs/libmythtv/playgroup.cpp
M mythtv/libs/libmythtv/previewgenerator.cpp
M mythtv/libs/libmythtv/previewgeneratorqueue.cpp
M mythtv/libs/libmythtv/previewgeneratorqueue.h
M mythtv/libs/libmythtv/recorders/NuppelVideoRecorder.cpp
M mythtv/libs/libmythtv/recorders/analogsignalmonitor.cpp
M mythtv/libs/libmythtv/recorders/asistreamhandler.cpp
M mythtv/libs/libmythtv/recorders/audioinputalsa.cpp
M mythtv/libs/libmythtv/recorders/audioinputalsa.h
M mythtv/libs/libmythtv/recorders/cetonrtsp.cpp
M mythtv/libs/libmythtv/recorders/channelbase.cpp
M mythtv/libs/libmythtv/recorders/dtvrecorder.cpp
M mythtv/libs/libmythtv/recorders/dvbchannel.cpp
M mythtv/libs/libmythtv/recorders/dvbdev/dvbci.cpp
M mythtv/libs/libmythtv/recorders/httptsstreamhandler.cpp
M mythtv/libs/libmythtv/recorders/httptsstreamhandler.h
M mythtv/libs/libmythtv/recorders/mpegrecorder.cpp
M mythtv/libs/libmythtv/recorders/signalmonitor.cpp
M mythtv/libs/libmythtv/recorders/signalmonitor.h
M mythtv/libs/libmythtv/recorders/streamhandler.cpp
M mythtv/libs/libmythtv/recorders/v4l2encstreamhandler.cpp
M mythtv/libs/libmythtv/recorders/v4lchannel.cpp
M mythtv/libs/libmythtv/recorders/v4lchannel.h
M mythtv/libs/libmythtv/recorders/vboxutils.cpp
M mythtv/libs/libmythtv/recordinginfo.cpp
M mythtv/libs/libmythtv/recordinginfo.h
M mythtv/libs/libmythtv/recordingprofile.cpp
M mythtv/libs/libmythtv/recordingprofile.h
M mythtv/libs/libmythtv/recordingrule.cpp
M mythtv/libs/libmythtv/recordingrule.h
M mythtv/libs/libmythtv/remoteencoder.cpp
M mythtv/libs/libmythtv/remoteencoder.h
M mythtv/libs/libmythtv/scanwizard.cpp
M mythtv/libs/libmythtv/scanwizard.h
M mythtv/libs/libmythtv/signalmonitorvalue.cpp
M mythtv/libs/libmythtv/sourceutil.cpp
M mythtv/libs/libmythtv/sourceutil.h
M mythtv/libs/libmythtv/subtitlereader.cpp
M mythtv/libs/libmythtv/subtitlereader.h
M mythtv/libs/libmythtv/subtitlescreen.cpp
M mythtv/libs/libmythtv/subtitlescreen.h
M mythtv/libs/libmythtv/teletextreader.cpp
M mythtv/libs/libmythtv/test/test_eitfixups/test_eitfixups.cpp
M mythtv/libs/libmythtv/test/test_eitfixups/test_eitfixups.h
M mythtv/libs/libmythtv/textsubtitleparser.cpp
M mythtv/libs/libmythtv/transporteditor.cpp
M mythtv/libs/libmythtv/tv_play.cpp
M mythtv/libs/libmythtv/tv_play.h
M mythtv/libs/libmythtv/tv_rec.cpp
M mythtv/libs/libmythtv/tv_rec.h
M mythtv/libs/libmythtv/tvbrowsehelper.cpp
M mythtv/libs/libmythtv/tvbrowsehelper.h
M mythtv/libs/libmythtv/tvremoteutil.cpp
M mythtv/libs/libmythtv/v4l2util.cpp
M mythtv/libs/libmythtv/videodisplayprofile.cpp
M mythtv/libs/libmythtv/videodisplayprofile.h
M mythtv/libs/libmythtv/videometadatautil.cpp
M mythtv/libs/libmythtv/videosource.cpp
M mythtv/libs/libmythtv/videosource.h
M mythtv/libs/libmythtv/visualisations/goom/mathtools.h
M mythtv/libs/libmythtv/visualisations/goom/tentacle3d.c
M mythtv/libs/libmythtv/visualisations/videovisualgoom.cpp
M mythtv/libs/libmythtv/xine_demux_sputext.cpp
M mythtv/libs/libmythui/DisplayResScreen.cpp
M mythtv/libs/libmythui/jsmenu.cpp
M mythtv/libs/libmythui/jsmenu.h
M mythtv/libs/libmythui/mythdialogbox.cpp
M mythtv/libs/libmythui/mythdialogbox.h
M mythtv/libs/libmythui/mythmainwindow.cpp
M mythtv/libs/libmythui/mythmainwindow.h
M mythtv/libs/libmythui/mythnotification.cpp
M mythtv/libs/libmythui/mythrender_opengl.cpp
M mythtv/libs/libmythui/mythrender_vdpau.cpp
M mythtv/libs/libmythui/mythscreentype.cpp
M mythtv/libs/libmythui/mythscreentype.h
M mythtv/libs/libmythui/myththemedmenu.cpp
M mythtv/libs/libmythui/mythudplistener.cpp
M mythtv/libs/libmythui/mythudplistener.h
M mythtv/libs/libmythui/mythuibutton.cpp
M mythtv/libs/libmythui/mythuibutton.h
M mythtv/libs/libmythui/mythuibuttonlist.cpp
M mythtv/libs/libmythui/mythuibuttonlist.h
M mythtv/libs/libmythui/mythuibuttontree.cpp
M mythtv/libs/libmythui/mythuifilebrowser.cpp
M mythtv/libs/libmythui/mythuifilebrowser.h
M mythtv/libs/libmythui/mythuihelper.cpp
M mythtv/libs/libmythui/mythuihelper.h
M mythtv/libs/libmythui/mythuiimage.cpp
M mythtv/libs/libmythui/mythuishape.cpp
M mythtv/libs/libmythui/mythuispinbox.cpp
M mythtv/libs/libmythui/mythuistatetype.cpp
M mythtv/libs/libmythui/mythuitext.cpp
M mythtv/libs/libmythui/mythuitext.h
M mythtv/libs/libmythui/mythuitextedit.cpp
M mythtv/libs/libmythui/mythuitype.cpp
M mythtv/libs/libmythui/mythuiwebbrowser.cpp
M mythtv/libs/libmythui/mythuiwebbrowser.h
M mythtv/libs/libmythui/mythvirtualkeyboard.cpp
M mythtv/libs/libmythui/mythvirtualkeyboard.h
M mythtv/libs/libmythui/themeinfo.cpp
M mythtv/libs/libmythui/themeinfo.h
M mythtv/libs/libmythui/util-nvctrl.cpp
M mythtv/libs/libmythui/xmlparsebase.cpp
M mythtv/libs/libmythupnp/bufferedsocketdevice.cpp
M mythtv/libs/libmythupnp/httprequest.cpp
M mythtv/libs/libmythupnp/httprequest.h
M mythtv/libs/libmythupnp/httpserver.cpp
M mythtv/libs/libmythupnp/httpserver.h
M mythtv/libs/libmythupnp/mmulticastsocketdevice.cpp
M mythtv/libs/libmythupnp/mmulticastsocketdevice.h
M mythtv/libs/libmythupnp/msocketdevice.cpp
M mythtv/libs/libmythupnp/serializers/serializer.cpp
M mythtv/libs/libmythupnp/serializers/serializer.h
M mythtv/libs/libmythupnp/serverSideScripting.cpp
M mythtv/libs/libmythupnp/ssdp.cpp
M mythtv/libs/libmythupnp/ssdp.h
M mythtv/libs/libmythupnp/upnpcdsobjects.cpp
M mythtv/libs/libmythupnp/upnpcdsobjects.h
M mythtv/libs/libmythupnp/upnpdevice.cpp
M mythtv/libs/libmythupnp/upnpdevice.h
M mythtv/libs/libmythupnp/upnpsubscription.cpp
M mythtv/libs/libmythupnp/upnptaskevent.cpp
M mythtv/libs/libmythupnp/upnptasknotify.cpp
M mythtv/libs/libmythupnp/upnptasknotify.h
M mythtv/libs/libmythupnp/upnptasksearch.cpp
M mythtv/libs/libmythupnp/upnptasksearch.h
M mythtv/libs/libmythupnp/websocket.cpp
M mythtv/libs/libmythupnp/websocket.h
M mythtv/libs/libmythupnp/wsdl.cpp
M mythtv/libs/libmythupnp/wsdl.h
M mythtv/libs/libmythupnp/xsd.cpp
M mythtv/libs/libmythupnp/xsd.h
M mythtv/programs/mythbackend/autoexpire.cpp
M mythtv/programs/mythbackend/autoexpire.h
M mythtv/programs/mythbackend/encoderlink.cpp
M mythtv/programs/mythbackend/encoderlink.h
M mythtv/programs/mythbackend/filetransfer.cpp
M mythtv/programs/mythbackend/httpconfig.cpp
M mythtv/programs/mythbackend/httpstatus.cpp
M mythtv/programs/mythbackend/httpstatus.h
M mythtv/programs/mythbackend/mainserver.cpp
M mythtv/programs/mythbackend/mainserver.h
M mythtv/programs/mythbackend/playbacksock.cpp
M mythtv/programs/mythbackend/playbacksock.h
M mythtv/programs/mythbackend/scheduler.cpp
M mythtv/programs/mythbackend/scheduler.h
M mythtv/programs/mythbackend/services/capture.cpp
M mythtv/programs/mythbackend/services/dvr.cpp
M mythtv/programs/mythbackend/services/guide.cpp
M mythtv/programs/mythbackend/services/guide.h
M mythtv/programs/mythbackend/services/myth.cpp
M mythtv/programs/mythbackend/services/myth.h
M mythtv/programs/mythbackend/services/serviceUtil.cpp
M mythtv/programs/mythbackend/services/serviceUtil.h
M mythtv/programs/mythbackend/upnpcdsmusic.cpp
M mythtv/programs/mythbackend/upnpcdsmusic.h
M mythtv/programs/mythbackend/upnpcdstv.cpp
M mythtv/programs/mythbackend/upnpcdstv.h
M mythtv/programs/mythbackend/upnpcdsvideo.cpp
M mythtv/programs/mythbackend/upnpcdsvideo.h
M mythtv/programs/mythcommflag/BlankFrameDetector.cpp
M mythtv/programs/mythcommflag/ClassicCommDetector.cpp
M mythtv/programs/mythcommflag/CommDetector2.cpp
M mythtv/programs/mythcommflag/CommDetector2.h
M mythtv/programs/mythcommflag/HistogramAnalyzer.cpp
M mythtv/programs/mythcommflag/HistogramAnalyzer.h
M mythtv/programs/mythcommflag/SceneChangeDetector.cpp
M mythtv/programs/mythcommflag/SceneChangeDetector.h
M mythtv/programs/mythcommflag/TemplateFinder.cpp
M mythtv/programs/mythcommflag/TemplateFinder.h
M mythtv/programs/mythcommflag/TemplateMatcher.cpp
M mythtv/programs/mythcommflag/TemplateMatcher.h
M mythtv/programs/mythcommflag/main.cpp
M mythtv/programs/mythfilldatabase/channeldata.cpp
M mythtv/programs/mythfilldatabase/filldata.cpp
M mythtv/programs/mythfilldatabase/filldata.h
M mythtv/programs/mythfilldatabase/xmltvparser.cpp
M mythtv/programs/mythfilldatabase/xmltvparser.h
M mythtv/programs/mythfrontend/actionset.cpp
M mythtv/programs/mythfrontend/audiogeneralsettings.cpp
M mythtv/programs/mythfrontend/backendconnectionmanager.cpp
M mythtv/programs/mythfrontend/channelrecpriority.cpp
M mythtv/programs/mythfrontend/channelrecpriority.h
M mythtv/programs/mythfrontend/editvideometadata.cpp
M mythtv/programs/mythfrontend/editvideometadata.h
M mythtv/programs/mythfrontend/galleryconfig.cpp
M mythtv/programs/mythfrontend/galleryinfo.cpp
M mythtv/programs/mythfrontend/galleryinfo.h
M mythtv/programs/mythfrontend/galleryslide.cpp
M mythtv/programs/mythfrontend/galleryslide.h
M mythtv/programs/mythfrontend/galleryslideview.cpp
M mythtv/programs/mythfrontend/gallerythumbview.cpp
M mythtv/programs/mythfrontend/gallerythumbview.h
M mythtv/programs/mythfrontend/gallerytransitions.cpp
M mythtv/programs/mythfrontend/gallerytransitions.h
M mythtv/programs/mythfrontend/globalsettings.cpp
M mythtv/programs/mythfrontend/globalsettings.h
M mythtv/programs/mythfrontend/guidegrid.cpp
M mythtv/programs/mythfrontend/guidegrid.h
M mythtv/programs/mythfrontend/keygrabber.cpp
M mythtv/programs/mythfrontend/main.cpp
M mythtv/programs/mythfrontend/mythcontrols.cpp
M mythtv/programs/mythfrontend/mythcontrols.h
M mythtv/programs/mythfrontend/networkcontrol.cpp
M mythtv/programs/mythfrontend/networkcontrol.h
M mythtv/programs/mythfrontend/playbackbox.cpp
M mythtv/programs/mythfrontend/playbackbox.h
M mythtv/programs/mythfrontend/playbackboxhelper.cpp
M mythtv/programs/mythfrontend/prevreclist.cpp
M mythtv/programs/mythfrontend/progdetails.cpp
M mythtv/programs/mythfrontend/progdetails.h
M mythtv/programs/mythfrontend/progfind.cpp
M mythtv/programs/mythfrontend/proginfolist.cpp
M mythtv/programs/mythfrontend/proginfolist.h
M mythtv/programs/mythfrontend/proglist.cpp
M mythtv/programs/mythfrontend/proglist.h
M mythtv/programs/mythfrontend/proglist_helpers.cpp
M mythtv/programs/mythfrontend/programinfocache.cpp
M mythtv/programs/mythfrontend/schedulecommon.cpp
M mythtv/programs/mythfrontend/scheduleeditor.cpp
M mythtv/programs/mythfrontend/scheduleeditor.h
M mythtv/programs/mythfrontend/setupwizard_general.cpp
M mythtv/programs/mythfrontend/setupwizard_general.h
M mythtv/programs/mythfrontend/setupwizard_video.cpp
M mythtv/programs/mythfrontend/setupwizard_video.h
M mythtv/programs/mythfrontend/statusbox.cpp
M mythtv/programs/mythfrontend/statusbox.h
M mythtv/programs/mythfrontend/themechooser.cpp
M mythtv/programs/mythfrontend/themechooser.h
M mythtv/programs/mythfrontend/upnpscanner.cpp
M mythtv/programs/mythfrontend/videodlg.cpp
M mythtv/programs/mythfrontend/videodlg.h
M mythtv/programs/mythfrontend/videofileassoc.cpp
M mythtv/programs/mythfrontend/videofilter.cpp
M mythtv/programs/mythfrontend/videofilter.h
M mythtv/programs/mythfrontend/videolist.cpp
M mythtv/programs/mythfrontend/videometadatasettings.cpp
M mythtv/programs/mythfrontend/videoplayersettings.cpp
M mythtv/programs/mythfrontend/viewscheduled.cpp
M mythtv/programs/mythlcdserver/lcdprocclient.cpp
M mythtv/programs/mythlcdserver/lcdprocclient.h
M mythtv/programs/mythlcdserver/lcdserver.cpp
M mythtv/programs/mythlcdserver/lcdserver.h
M mythtv/programs/mythmetadatalookup/lookup.cpp
M mythtv/programs/mythshutdown/main.cpp
M mythtv/programs/mythtranscode/main.cpp
M mythtv/programs/mythtranscode/mpeg2fix.cpp
M mythtv/programs/mythtranscode/mpeg2fix.h
M mythtv/programs/mythtranscode/transcode.cpp
M mythtv/programs/mythtranscode/transcode.h
M mythtv/programs/mythtv-setup/importicons.cpp
M mythtv/programs/mythtv-setup/importicons.h
M mythtv/programs/mythtv-setup/main.cpp
M mythtv/programs/mythutil/messageutils.cpp
M mythtv/programs/mythutil/mpegutils.cpp
M mythtv/programs/mythwelcome/welcomesettings.cpp
Log Message:
-----------
Merge clang-tidy cleanups. (set 4)
Commit: f29362010665887707fc030569300b81e010a02a
https://github.com/MythTV/mythtv/commit/f29362010665887707fc030569300b81e010a02a
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-04 (Thu, 04 Apr 2019)
Changed paths:
M mythtv/libs/libmythbase/serverpool.cpp
Log Message:
-----------
cppcheck: Suppress warning about bind in serverpool.cpp.
This is calling the class function, not the system function.
Commit: 5b6dd666adbe3ccc538312e675ee8615d0585e45
https://github.com/MythTV/mythtv/commit/5b6dd666adbe3ccc538312e675ee8615d0585e45
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-04 (Thu, 04 Apr 2019)
Changed paths:
M mythtv/libs/libmyth/audio/audiooutput.cpp
M mythtv/libs/libmythtv/cardutil.cpp
M mythtv/libs/libmythtv/privatedecoder_vda.cpp
M mythtv/programs/mythbackend/services/channelicon.cpp
Log Message:
-----------
cppcheck: Fix local variables shadowing outer variables.
Commit: c7e66557f3830e8438f056cb43c098ad669048ef
https://github.com/MythTV/mythtv/commit/c7e66557f3830e8438f056cb43c098ad669048ef
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-04 (Thu, 04 Apr 2019)
Changed paths:
M mythtv/libs/libmyth/audio/audiooutputca.cpp
M mythtv/libs/libmyth/audio/audiooutputca.h
M mythtv/libs/libmythbase/filesysteminfo.h
M mythtv/libs/libmythbase/lcddevice.h
M mythtv/libs/libmythbase/mythevent.h
M mythtv/libs/libmythservicecontracts/services/dvrServices.h
M mythtv/libs/libmythtv/channelinfo.h
M mythtv/libs/libmythtv/channelsettings.h
M mythtv/libs/libmythtv/eithelper.h
M mythtv/libs/libmythtv/filewriterbase.h
M mythtv/libs/libmythtv/frequencytables.h
M mythtv/libs/libmythtv/previewgeneratorqueue.h
M mythtv/libs/libmythtv/profilegroup.h
M mythtv/libs/libmythtv/recordingprofile.h
M mythtv/libs/libmythtv/tv_play.h
M mythtv/libs/libmythtv/tv_rec.h
M mythtv/libs/libmythtv/videosource.h
M mythtv/programs/mythbackend/mainserver.h
M mythtv/programs/mythbackend/mythsettings.h
M mythtv/programs/mythbackend/services/dvr.cpp
M mythtv/programs/mythbackend/services/dvr.h
M mythtv/programs/mythfrontend/audiogeneralsettings.h
M mythtv/programs/mythfrontend/gallerytransitions.h
M mythtv/programs/mythfrontend/playbackbox.h
M mythtv/programs/mythfrontend/upnpscanner.h
M mythtv/programs/mythfrontend/viewschedulediff.h
M mythtv/programs/mythtranscode/transcode.h
Log Message:
-----------
cppcheck: Convert a number of function parameters to be const references.
Commit: d447f7a6f9fd37dcdc40da4d501c4a993638876d
https://github.com/MythTV/mythtv/commit/d447f7a6f9fd37dcdc40da4d501c4a993638876d
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-04 (Thu, 04 Apr 2019)
Changed paths:
M mythtv/libs/libmythtv/avformatdecoder.cpp
M mythtv/libs/libmythtv/mpeg/dvbdescriptors.h
M mythtv/libs/libmythtv/recorders/darwinfirewiredevice.cpp
M mythtv/libs/libmythtv/visualisations/goom/filters.c
M mythtv/libs/libmythtv/visualisations/goom/ifs.c
M mythtv/libs/libmythtv/visualisations/goom/surf3d.c
M mythtv/libs/libmythtv/visualisations/goom/tentacle3d.c
M mythtv/libs/libmythtv/xine_demux_sputext.cpp
M mythtv/libs/libmythtv/yuv2rgb.cpp
M mythtv/libs/libmythui/lirc_client.c
M mythtv/programs/mythcommflag/ClassicCommDetector.cpp
Log Message:
-----------
cppcheck: Reduce variable scope where possible.
Commit: 5e3b91290047a69aceb1f66e11235c6baac206b6
https://github.com/MythTV/mythtv/commit/5e3b91290047a69aceb1f66e11235c6baac206b6
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-04 (Thu, 04 Apr 2019)
Changed paths:
M mythtv/libs/libmyth/audio/audiooutputdx.cpp
Log Message:
-----------
cppcheck: Fix typo in audiooutputdx.cpp.
Commit: ee3906f5e9827c4704c9e256021550980fba86b4
https://github.com/MythTV/mythtv/commit/ee3906f5e9827c4704c9e256021550980fba86b4
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-04 (Thu, 04 Apr 2019)
Changed paths:
M mythtv/libs/libmyth/audio/audiooutputca.cpp
M mythtv/libs/libmythbase/dbutil.cpp
M mythtv/libs/libmythbase/portchecker.cpp
M mythtv/libs/libmythtv/Bluray/mythbdplayer.cpp
M mythtv/libs/libmythtv/DVD/dvdringbuffer.cpp
M mythtv/libs/libmythtv/DVD/mythdvdplayer.cpp
M mythtv/libs/libmythtv/avformatdecoder.cpp
M mythtv/libs/libmythtv/channelscan/channelimporter.cpp
M mythtv/libs/libmythtv/channelutil.cpp
M mythtv/libs/libmythtv/eitfixup.cpp
M mythtv/libs/libmythtv/fileringbuffer.cpp
M mythtv/libs/libmythtv/jobqueue.cpp
M mythtv/libs/libmythtv/mpeg/H264Parser.cpp
M mythtv/libs/libmythtv/mpeg/sctetables.cpp
M mythtv/libs/libmythtv/mythcommflagplayer.cpp
M mythtv/libs/libmythtv/openglvideo.cpp
M mythtv/libs/libmythtv/playercontext.cpp
M mythtv/libs/libmythtv/previewgenerator.cpp
M mythtv/libs/libmythtv/previewgeneratorqueue.cpp
M mythtv/libs/libmythtv/programdata.cpp
M mythtv/libs/libmythtv/recorders/ExternalStreamHandler.cpp
M mythtv/libs/libmythtv/recorders/channelbase.cpp
M mythtv/libs/libmythtv/tv_play.cpp
M mythtv/libs/libmythtv/tv_rec.cpp
M mythtv/libs/libmythtv/tvbrowsehelper.cpp
M mythtv/libs/libmythtv/videoout_d3d.cpp
M mythtv/libs/libmythtv/videosource.cpp
M mythtv/libs/libmythtv/yuv2rgb.cpp
M mythtv/libs/libmythupnp/serializers/xmlSerializer.cpp
M mythtv/programs/mythbackend/httpconfig.cpp
M mythtv/programs/mythbackend/httpstatus.cpp
M mythtv/programs/mythbackend/mainserver.cpp
M mythtv/programs/mythbackend/services/guide.cpp
M mythtv/programs/mythcommflag/ClassicCommDetector.cpp
M mythtv/programs/mythfilldatabase/filldata.cpp
M mythtv/programs/mythfrontend/editvideometadata.cpp
M mythtv/programs/mythfrontend/globalsettings.cpp
M mythtv/programs/mythfrontend/playbackbox.cpp
M mythtv/programs/mythmediaserver/controlrequesthandler.cpp
M mythtv/programs/mythutil/messageutils.cpp
Log Message:
-----------
cppcheck: Fix unused variable warnings.
Commit: b02e3fc0645667100048defc54e61081be40c380
https://github.com/MythTV/mythtv/commit/b02e3fc0645667100048defc54e61081be40c380
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-04 (Thu, 04 Apr 2019)
Changed paths:
M mythtv/libs/libmythbase/mythcdrom-linux.cpp
Log Message:
-----------
cppcheck: Don't declare a structure inside if a function.
Its valid C++, but it throws off the cppcheck parser.
Commit: 7d0337e7771a2fe8965df60b2146edc16039aac5
https://github.com/MythTV/mythtv/commit/7d0337e7771a2fe8965df60b2146edc16039aac5
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-04 (Thu, 04 Apr 2019)
Changed paths:
M mythtv/libs/libmyth/audio/audiooutputwin.cpp
M mythtv/libs/libmythbase/logging.h
M mythtv/libs/libmythbase/loggingserver.h
M mythtv/libs/libmythbase/mthread.h
M mythtv/libs/libmythbase/mthreadpool.h
M mythtv/libs/libmythbase/mythdb.h
M mythtv/libs/libmythbase/unzip.h
M mythtv/libs/libmythtv/avformatdecoder.h
M mythtv/libs/libmythtv/jitterometer.h
M mythtv/libs/libmythtv/mhi.h
M mythtv/libs/libmythtv/mythavutil.cpp
M mythtv/libs/libmythtv/mythavutil.h
M mythtv/libs/libmythtv/nuppeldecoder.h
M mythtv/libs/libmythtv/privatedecoder_vda.h
M mythtv/libs/libmythtv/recorders/darwinfirewiredevice.cpp
M mythtv/libs/libmythtv/recorders/darwinfirewiredevice.h
M mythtv/libs/libmythtv/recorders/dvbdev/dvbci.h
M mythtv/libs/libmythtv/recorders/firewirechannel.h
M mythtv/libs/libmythtv/recorders/hlsstreamhandler.h
M mythtv/libs/libmythtv/textsubtitleparser.cpp
M mythtv/libs/libmythui/screensaver-osx.h
M mythtv/libs/libmythupnp/serializers/xmlSerializer.h
M mythtv/programs/mythcommflag/CannyEdgeDetector.h
M mythtv/programs/mythfrontend/guidegrid.h
M mythtv/programs/mythfrontend/scheduleeditor.h
M mythtv/programs/mythfrontend/videolist.h
Log Message:
-----------
cppcheck: Mark objects as not copyable.
Commit: d2bb6076ee3192687609a7f4826a600a4f804dae
https://github.com/MythTV/mythtv/commit/d2bb6076ee3192687609a7f4826a600a4f804dae
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-04 (Thu, 04 Apr 2019)
Changed paths:
M mythtv/libs/libmythbase/zipentry_p.h
M mythtv/libs/libmythtv/channelutil.h
M mythtv/libs/libmythtv/mpeg/atsctables.h
M mythtv/libs/libmythtv/mpeg/dvbdescriptors.h
M mythtv/libs/libmythtv/mpeg/mpegdescriptors.h
M mythtv/libs/libmythtv/mpeg/mpegtables.h
M mythtv/libs/libmythtv/mpeg/sctedescriptors.h
M mythtv/libs/libmythtv/mpeg/sctetables.h
M mythtv/libs/libmythtv/mpeg/splicedescriptors.h
Log Message:
-----------
cppcheck: Fix non-boolean return value from boolean function warnings.
Commit: b065cf97e21b8413c60bafd8704ed12d8aa4d8e5
https://github.com/MythTV/mythtv/commit/b065cf97e21b8413c60bafd8704ed12d8aa4d8e5
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-04 (Thu, 04 Apr 2019)
Changed paths:
M mythtv/libs/libmythbase/mythcdrom-linux.cpp
Log Message:
-----------
cppcheck: Fix duplicate break statements.
Commit: 9237eecf6412225ea0d6044869ab9453e816fb18
https://github.com/MythTV/mythtv/commit/9237eecf6412225ea0d6044869ab9453e816fb18
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-04 (Thu, 04 Apr 2019)
Changed paths:
M mythtv/programs/mythfrontend/galleryconfig.h
M mythtv/programs/mythfrontend/videolist.cpp
Log Message:
-----------
cppcheck: Mark a two constructors as explicit.
Commit: c7ff36cbb8687c6cd5bc07c77f7dfe8b5003c121
https://github.com/MythTV/mythtv/commit/c7ff36cbb8687c6cd5bc07c77f7dfe8b5003c121
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-04 (Thu, 04 Apr 2019)
Changed paths:
M mythtv/libs/libmythtv/cardutil.cpp
Log Message:
-----------
Fix some unused variable warning messages on OSX.
Commit: 6b21e99142731ec5ea106e84415d5759104a8049
https://github.com/MythTV/mythtv/commit/6b21e99142731ec5ea106e84415d5759104a8049
Author: David Hampton <mythtv at love2code.net>
Date: 2019-04-04 (Thu, 04 Apr 2019)
Changed paths:
M mythtv/libs/libmythtv/eitfixup.cpp
Log Message:
-----------
Fix a "variable sometimes initialized" warning in eitfixup.cpp.
Revert one change from 2887266263 that caused the position2 variable
to only be initialized if the position1 variable gets set to -1. Both
variables should be initialized before either is tested.
Compare: https://github.com/MythTV/mythtv/compare/a0f4fbbaebab...6b21e9914273
More information about the mythtv-commits
mailing list