[mythtv-commits] Ticket #13329: Proposed patch - External recorder channel change can result in discontinuous changes for LiveTV

[MythTV]

#13329: Proposed patch - External recorder channel change can result in
discontinuous changes for LiveTV
----------------------------------------+--------------------------
     Reporter:  Gary Buhrmaster         |      Owner:  (none)
         Type:  Patch - Feature         |     Status:  new
     Priority:  minor                   |  Milestone:  needs_triage
    Component:  MythTV - Video Library  |    Version:  Master Head
     Severity:  medium                  |   Keywords:
Ticket locked:  0                       |
----------------------------------------+--------------------------
 For your consideration:

 During some testing of LiveTV with an external recorder (limited testing,
 I almost never use LiveTV) I encountered some non-reproducible issues with
 channel changes and video failures.  I originally thought I had tracked
 them down to changes in video format between the channels, and applied the
 following patch, which seemed to help at least a few times.

 Eventually I also made other changes to my external recorder to eliminate
 certain other channel change artifacts.

 I have been unable to reproduce the original problem with or without this
 patch since I made those other changes to my external recorder.  But this
 feels like it should be the correct value for the general case of external
 recorders and LiveTV.


 {{{
 diff --git a/mythtv/libs/libmythtv/cardutil.h
 b/mythtv/libs/libmythtv/cardutil.h
 index b19c5b40ff..23f07bdd41 100644
 --- a/mythtv/libs/libmythtv/cardutil.h
 +++ b/mythtv/libs/libmythtv/cardutil.h
 @@ -139,7 +139,8 @@ class MTV_PUBLIC CardUtil

      static bool         IsChannelChangeDiscontinuous(const QString
 &rawtype)
      {
 -        return !IsEncoder(rawtype) || (rawtype == "HDPVR");
 +        return !IsEncoder(rawtype) || (rawtype == "HDPVR") ||
 +               (rawtype == "EXTERNAL");
      }

      static bool         IsUnscanable(const QString &rawtype)
 }}}

-- 
Ticket URL: <https://code.mythtv.org/trac/ticket/13329>
MythTV <http://www.mythtv.org>
MythTV Media Center