[mythtv-commits] Ticket #13361: ChannelUtil::SetVisible function declaration unclear

MythTV noreply at mythtv.org
Wed Dec 19 15:46:47 UTC 2018

#13361: ChannelUtil::SetVisible function declaration unclear
     Reporter:  Klaas de Waal             |      Owner:  (none)
         Type:  Patch - Bug Fix           |     Status:  new
     Priority:  minor                     |  Milestone:  needs_triage
    Component:  MythTV - Channel Scanner  |    Version:  Master Head
     Severity:  low                       |   Keywords:  DVB channel
Ticket locked:  0                         |  visible
 The function SetVisible in ChannelUtil.cpp is defined as follows:
 bool ChannelUtil::SetVisible(uint channel_id, bool visible)
 The implementation sets the channel visible when the second parameter is

 However, the declaration of SetVisible in ChannelUtil.h is as follows:
    static bool    SetVisible(uint channel_id, bool hidden);
 This does suggest that when the second parameter is "true" the channel is
 hidden, i.e. not visible. The attached patch changes "bool hidden" to
 "bool visible" so that the declaration does match the implementation.

Ticket URL: <https://code.mythtv.org/trac/ticket/13361>
MythTV <http://www.mythtv.org>
MythTV Media Center

More information about the mythtv-commits mailing list