[mythtv-commits] Ticket #13315: Use fully-decoded URL paths when translating to local paths

MythTV noreply at mythtv.org
Sat Dec 8 16:31:36 UTC 2018

#13315: Use fully-decoded URL paths when translating to local paths
 Reporter:  ijc               |          Owner:  Peter Bennett
     Type:  Patch - Bug Fix   |         Status:  assigned
 Priority:  minor             |      Milestone:  30.0
Component:  MythTV - General  |        Version:  Master Head
 Severity:  medium            |     Resolution:
 Keywords:                    |  Ticket locked:  0

Comment (by ijc):

 >  I'll give this a go, I expect it'll be a big patch and take a little
 while to do...

 and indeed it is a pretty big patch (and I didn't even finish)...

 However, in the process of looking at it I realised that we can get a
 large improvement in correctness by just having `GenMythURL` use `QUrl`
 internally but still return a `QString` (i.e. `qurl.toString()`) this
 ensures that everything in the returned stringified url is correctly
 escaped such that converting back to a `QUrl` later on (e.g. in
 `remotefile.cpp`) does the right thing.

 The patch for this looks quite tractable and I'm testing it right now. I'm
 hopeful it might even be acceptable for the 30 release.

 Once `GenMythURL` uses `QUrl` internally we can start to bubble that up
 the call chains (perhaps using `MDEPRECATED` as needed to break off even
 smaller chunks at a time) and eventually end up using `QUrl` everywhere
 (my initial mistake was to start from the `remotefile.cpp` functions and
 trying to tease it out from the other end -- which was backwards and left
 me with a big pile of yarn...)

Ticket URL: <https://code.mythtv.org/trac/ticket/13315#comment:12>
MythTV <http://www.mythtv.org>
MythTV Media Center

More information about the mythtv-commits mailing list