[mythtv-commits] Ticket #13131: mythtv-setup channel editor

[MythTV]

#13131: mythtv-setup channel editor
-----------------------------------+------------------------------
 Reporter:  blm-ubunet@…           |          Owner:  jyavenard
     Type:  Bug Report - General   |         Status:  new
 Priority:  minor                  |      Milestone:  needs_triage
Component:  MythTV - Mythtv-setup  |        Version:  Master Head
 Severity:  medium                 |     Resolution:
 Keywords:  scan, channel editor   |  Ticket locked:  0
-----------------------------------+------------------------------
Changes (by rsiddons):

 * status:  closed => new
 * resolution:  Invalid =>


Comment:

 Different 'roger' but re-opening for further review.
 This is a consequence of 65f99284fc68da0446dbdf711b6ee9bee6fd4ddf

 Historically freqid has been either a channel number or a kHz frequency.
 Why is a mystery, but there's plenty of old code that interprets it as a
 frequency (Frequency Tables)
 https://github.com/MythTV/mythtv/blob/master/mythtv/libs/libmythtv/recorders/dtvchannel.cpp#L239

 grepping "freqid" finds plenty.

 As per #comment:1 DVB-T tuning still works (for me) by using the multiplex
 data. However it seems dangerous for the UI to start clobbering settings
 that have a dubious usage. Note it is clobbered merely by entry to the
 Edit Channel screen, not by actually changing the channel number.
 #13046#comment:32

 This is my database after viewing Edit Channel for channels 1 & 2:

 mysql> SELECT chanid,channum,freqid,sourceid,callsign FROM `channel` ORDER
 BY `chanid`LIMIT 10;

 ||= chanid =||= channum =||= freqid =||= callsign =||
 ||   1001 || 1       || 1      || BBC ONE N West ||
 ||   1002 || 2       || 2      || BBC TWO        ||
 ||   1003 || 3       || 59     || ITV            ||
 ||   1004 || 4       || 59     || Channel 4      ||
 ||   1005 || 5       || 59     || Channel 5      ||
 ||   1006 || 6       || 59     || ITV2           ||
 ||   1009 || 9       || 50     || BBC FOUR       ||
 ||   1010 || 10      || 58     || ITV3           ||
 ||   1011 || 11      || 49     || Pick           ||
 ||   1012 || 12      || 49     || Dave           ||

 The previous freqids appear to be transport "friendly numbers" being set
 at
 https://github.com/MythTV/mythtv/blob/master/mythtv/libs/libmythtv/frequencytables.cpp#L95
 Possibly they're linked to the connected muxes #comment:6

 OTOH maybe frequency usage is redundant now. An opportunity to comment it
 all out & see what breaks ?

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13131#comment:7>
MythTV <http://www.mythtv.org>
MythTV Media Center