[mythtv-commits] Ticket #13114: Import Recorder Fix

MythTV noreply at mythtv.org
Mon Sep 25 18:28:01 UTC 2017


#13114: Import Recorder Fix
--------------------------------+----------------------------
 Reporter:  devmonkey@…         |          Owner:  pbennett
     Type:  Patch - Bug Fix     |         Status:  infoneeded
 Priority:  minor               |      Milestone:  30.0
Component:  MythTV - Recording  |        Version:  0.28.1
 Severity:  medium              |     Resolution:
 Keywords:                      |  Ticket locked:  0
--------------------------------+----------------------------

Comment (by pbennett):

 The wiki recommends putting in a blank filename, but if you did that I
 don't know how the recorder would know what file to read, so that seems a
 bogus feature that should not be allowed.

 The strange behavior of creating a link if you specify a file that does
 exist - That does not make sense to me. It should work by copying the file
 while recording, same as if the file did not exist while setting up the
 recorder.

 I can work with you to get this into the code base. We should also update
 the wiki with instructions on how to do it. One thing that I wonder about
 is what happens when you end one recording and start the next, if it
 starts right away. The first file would have to be deleted and then the
 next one created with the same file name, before the recorder starts
 recording.

 Regarding your pull request -

 * You have changed the progress log from info to debug. I am not happy
 with that. Turning on debug gets you huge amounts of data. I would prefer
 that if you want to change it, make it info level on another category than
 general. I don't know if there is a suitable category that makes sense.
 * You changed a header file to add virtual to a bunch of methods that are
 already inheriting virtual. We should not make unnecessary changes.

 Have you looked at the "black box" recorder? Would it help with your
 recording problem or are there other bugs with that?

 You mention 2 simultaneous recordings. I assume that if you had 2 STB's
 and 2 HDMI recorders you could create 2 import recorders with different
 file names and make it work.

 If you fix the things I mentioned above, I will give it a try, although I
 do not have a suitable recorder to import from but I can try a file. It
 would be nice if you also have a fix to prevent the  creation of links and
 / or the backend crash when there is no file name. Maybe there should be a
 parameter somewhere to enable creation of links if people want them.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13114#comment:8>
MythTV <http://www.mythtv.org>
MythTV Media Center


More information about the mythtv-commits mailing list