[mythtv-commits] Ticket #13130: [PATCH] Fixes for regressions in tvdb

[MythTV]

#13130: [PATCH] Fixes for regressions in tvdb
---------------------------------------------+--------------------------
     Reporter:  ijc@…                        |      Owner:  jyavenard
         Type:  Patch - Bug Fix              |     Status:  new
     Priority:  major                        |  Milestone:  needs_triage
    Component:  MythTV - Mythmetadatalookup  |    Version:  Master Head
     Severity:  medium                       |   Keywords:
Ticket locked:  0                            |
---------------------------------------------+--------------------------
 With the move from v1 to v2 api for ttvdb I noticed in my logs:

 `E MetadataImageDownload metadataimagedownload.cpp:255 (run) Tried to
 write http://thetvdb.com/banners/, but it appears to be an HTML redirect
 or corrupt file (filesize 235).`

 This comes from:
 {{{
 $ ttvdb.py -l en -a GB -C 330432
 <?xml version='1.0' encoding='UTF-8'?>
 <metadata>
   <item>
     <language>en</language>
     <title>Nine Minute Ninja</title>
     <network>CBBC</network>
     <description>Art Ninja spinoff. Ricky makes art in nine
 minutes.</description>
     <studios>
       <studio name="CBBC"/>
     </studios>
     <runtime>10</runtime>
     <inetref>330432</inetref>
     <userrating>0</userrating>
     <ratingcount>0</ratingcount>
     <year>2015</year>
     <releasedate>2015-06-24</releasedate>
     <lastupdated>Wed, 20 Sep 2017 20:43:40 GMT</lastupdated>
     <status>Continuing</status>
     <images>
       <image type="coverart"
 url="http://www.thetvdb.com/banners/posters/330432-1.jpg"
 thumb="http://www.thetvdb.com/banners/_cache/posters/330432-1.jpg"/>
       <image type="banner" url="http://thetvdb.com/banners/"
 thumb="http://thetvdb.com/banners/_cache/"/>
     </images>
   </item>
 </metadata>
 }}}
 Compared with v29.0 where I see:
 {{{
 $ ttvdb.py -l en -a GB -C 330432
 <?xml version='1.0' encoding='UTF-8'?>
 <metadata>
   <item>
     <language>en</language>
     <title>Nine Minute Ninja</title>
     <network>CBBC</network>
     <description>Art Ninja spinoff. Ricky makes art in nine
 minutes.</description>
     <categories>
       <category type="genre" name="Children"/>
     </categories>
     <studios>
       <studio name="CBBC"/>
     </studios>
     <runtime>10</runtime>
     <inetref>330432</inetref>
     <ratingcount>0</ratingcount>
     <year>2015</year>
     <releasedate>2015-06-24</releasedate>
     <lastupdated>Wed, 20 Sep 2017 20:43:40 GMT</lastupdated>
     <status>Continuing</status>
     <images>
       <image type="coverart"
 url="http://www.thetvdb.com/banners/posters/330432-1.jpg"
 thumb="http://www.thetvdb.com/banners/_cache/posters/330432-1.jpg"/>
     </images>
   </item>
 </metadata>
 }}}

 So as well as the bogus/strange banner the genre's are missing and their
 is a spurious (?) userrating of 0.

 When I came to fix I also found that `doctest` was broken so I fixed those
 before fixing the issue I had seen and adding a test case for it.

 Patches are available in
 https://github.com/MythTV/mythtv/compare/master...ijc:ttvdb-fixes. I'll
 also attach here.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13130>
MythTV <http://www.mythtv.org>
MythTV Media Center