[mythtv-commits] Ticket #12758: Feature patch: New feature for mythfilldatabase to optionally not use allatonce (--no-allatonce)

[MythTV]

#12758: Feature patch: New feature for mythfilldatabase to optionally not use
allatonce (--no-allatonce)
-------------------------------------------------+-------------------------
 Reporter:  Gary Buhrmaster <gary.buhrmaster@…>  |          Owner:
                                                 |  pbennett
     Type:  Patch - Feature                      |         Status:  closed
 Priority:  minor                                |      Milestone:  unknown
Component:  MythTV - Mythfilldatabase            |        Version:  Master
                                                 |  Head
 Severity:  medium                               |     Resolution:  fixed
 Keywords:                                       |  Ticket locked:  0
-------------------------------------------------+-------------------------

Comment (by Gary Buhrmaster <gary.buhrmaster@…>):

 Replying to [comment:7 pbennett]:
 ....
 > When used with json grabbers like tv_grab_zz_sdjson_sqlite which cache
 the data, there should be no impact on the schedules direct server from
 using -no-allatonce, since the data is cached in a local database and
 there should not be extra load on the upstream server.

 Just to close the loop here a bit, at least the tv_grab_zz_sdjson_sqlite
 grabber has a (very) slight additional overhead, as the grabber only
 retrieves necessary data for the particular request day, so rather than
 downloading any new/additional data for all days at once, you now end up
 retrieving the (approximately same amount of data) one day at a time.  I
 presume (but have zero specific knowledge) that the upstream efficiency is
 slightly less.  Noise in the grand scheme of things, I expect.  If you
 really want to reduce the minor inefficiency, have a cron job runs that
 grabber with "--download-only" option to pull in all the data at once
 before running mythfilldatabase.

 And as for (a previous comment) code divergence. Sorry about that.  It is
 possibly an artifact due to too many patches in those related code areas
 over the last few years, and possibly an artifact of my aborted attempts
 with additional ideas/fixes/cleanup.  Time (for me) to go review those
 things.

 And while it is no longer relevant, when the patch was originally
 submitted there was a comment by one of the devs on irc that it seemed to
 be the wrong approach (which I agreed to, the better approach is a code
 refactor, but no one currently had that itch/time).

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12758#comment:10>
MythTV <http://www.mythtv.org>
MythTV Media Center