[mythtv-commits] Ticket #13190: ExternalRecorder - error reading STDERR

[MythTV]

#13190: ExternalRecorder - error reading STDERR
----------------------------------+------------------------------
 Reporter:  mrawji@…              |          Owner:  jpoet
     Type:  Bug Report - General  |         Status:  assigned
 Priority:  minor                 |      Milestone:  needs_triage
Component:  MythTV - General      |        Version:  Unspecified
 Severity:  medium                |     Resolution:
 Keywords:                        |  Ticket locked:  0
----------------------------------+------------------------------

Comment (by Marc Rawji <mrawji@…>):

 Ok, assuming my crappy 'for loops' around Version? and the BlockSize were
 valid ways to reproduce, this patch seems to fix it. I haven't tested it
 on prod setup..

 {{{
 diff --git a/mythtv/libs/libmythtv/recorders/ExternalStreamHandler.cpp
 b/mythtv/libs/libmythtv/recorders/ExternalStreamHandler.cpp
 index b2bf050..76017fd 100644
 --- a/mythtv/libs/libmythtv/recorders/ExternalStreamHandler.cpp
 +++ b/mythtv/libs/libmythtv/recorders/ExternalStreamHandler.cpp
 @@ -1087,7 +1087,7 @@ bool ExternalStreamHandler::ProcessCommand(const
 QString & cmd, uint timeout,
              }
              // STATUS message are "out of band".
              // Ignore them while waiting for a responds to a command
 -            if (!result.startsWith("STATUS"))
 +            if (!result.startsWith("STATUS") && result.size() > 0)
                  break;
          }
 }}}

 essentially, if the size of the read data is zero, it'll try reading
 again.


 Thoughts?
 Marc

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13190#comment:4>
MythTV <http://www.mythtv.org>
MythTV Media Center