[mythtv-commits] Ticket #12738: Mythfrontend Service API SendAction not working

[MythTV]

#12738: Mythfrontend Service API SendAction not working
----------------------------------------------+--------------------------
 Reporter:  paul@…                            |          Owner:  bmeek
     Type:  Bug Report - General              |         Status:  assigned
 Priority:  minor                             |      Milestone:  unknown
Component:  MythTV - Services API - Frontend  |        Version:  0.28.0
 Severity:  medium                            |     Resolution:
 Keywords:                                    |  Ticket locked:  0
----------------------------------------------+--------------------------

Comment (by rsiddons):

 Bill,

 Strictly, the services run in a separate thread so your patch shouldn't be
 calling !JumpTo (non-threadsafe UI code) directly.
 That's probably why it was 'abusing' QKeyEvent in the first place.
 You could use !MythEvent(Action) instead and put the !JumpTo in
 https://github.com/MythTV/mythtv/blob/master/mythtv/libs/libmythui/mythmainwindow.cpp#L2634
 with the others.
 But you'll be back to distinguishing a !SendAction event from other
 events.

 Also, a screen processing the Jump Action currently has the ability to
 clean itself up before completing the keypress. Short-circuiting that at
 the service level would prevent that.
 I doubt any do (or arguably should) but it may have ramifications...

 Regarding your question, for !SendKey & !SendAction you could declare the
 keymap statically - see example in patch. It would need to go in a header
 for networkcontrol to use it as well.

 However I'm wondering why keymap is necessary at all (networkcontrol is
 over 10 years old).
 QKeySequence will do the same thing - my patch demonstrates.

 It differs only with the non-standard punctuation mneumonics.
 Is there a problem with sending puctuation characters to a service ?
 Seems we're forcing clients to convert "<" to "less" for purely historical
 reasons.
 It would be nice to delegate the character handling to Qt

 Eric,
 There is no RWND action; only SEEKRWND, JUMPRWND, RWNDSTICKY

 https://code.mythtv.org/doxygen/tv__actions_8h_source.html

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12738#comment:16>
MythTV <http://www.mythtv.org>
MythTV Media Center