[mythtv-commits] Ticket #13006: filenames turned into QUrls should be proper file: URLs

[MythTV]

#13006: filenames turned into QUrls should be proper file: URLs
----------------------------------+-------------------------
 Reporter:  brian@…               |          Owner:
     Type:  Bug Report - General  |         Status:  new
 Priority:  minor                 |      Milestone:  unknown
Component:  MythTV - General      |        Version:  0.28.1
 Severity:  medium                |     Resolution:
 Keywords:                        |  Ticket locked:  0
----------------------------------+-------------------------

Comment (by brian@…):

 Replying to [comment:5 pbennett]:
 > I am not familiar with the code here.

 Me either.

 > Should the input string be a filename or should it be a URL?

 I don't know.  But I think that's a different issue.  As it is currently,
 it's a URL yet it's data is badly formed, not in URL format.

 I think if somebody wants to look at the bigger picture and refactor all
 of that code one day, that is fine.  But until then, the data should at
 least be in a valid format for the type that it is.

 > Maybe the caller should be formatting the string as file://something.

 The caller doesn't know that internally the BE is storing that item in a
 URL data type.  The caller is just given a list of items and chooses one.
 If the BE wants the caller to choose a URL it should give it a list of
 URLs and not plain names.

 > If the caller is actually doing that in some cases, then changing the
 code to use QUrl::fromLocalFile may cause a problem.

 So how about the update I just made to the PR then to only make it a
 file:// URL if it's not already a URL with a scheme?

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13006#comment:6>
MythTV <http://www.mythtv.org>
MythTV Media Center