[mythtv-commits] Ticket #8096: Music Only channels/still picture flag cause jump program error

[MythTV]

#8096: Music Only channels/still picture flag cause jump program error
-------------------------------------+----------------------------
 Reporter:  mia1dolfan@…             |          Owner:  pbennett
     Type:  defect                   |         Status:  closed
 Priority:  minor                    |      Milestone:  unknown
Component:  MythTV - Video Playback  |        Version:  0.22-fixes
 Severity:  medium                   |     Resolution:  fixed
 Keywords:  hdhomerun tuning jump    |  Ticket locked:  0
-------------------------------------+----------------------------

Comment (by pbennett):

 Replying to [comment:20 jyavenard]:
 >
 > I don't see how the fix does work around the problem described.
 >
 > The only way to fix this is to use a reference counted object, and here
 it's not thread safe either.

 I agree, a reference counted object would be best, but changing Painter to
 be reference counted would be a major amount of work.

 What the work around does is delay deleting the painter until the next
 reset of the OSD. The seg fault was happening if there was a resolution
 change right after the start of playing, while the initial OSD was still
 loading the images in separate threads. With my change, the painter is not
 deleted until the next resolution change or the eventual deletion of the
 OSD. Hopefully by that time the image load threads would be finished. If
 there were two resolution changes in quick succession, we could still get
 a seg fault. Hopefully this would not happen.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/8096#comment:21>
MythTV <http://www.mythtv.org>
MythTV Media Center