[mythtv-commits] Ticket #8096: Music Only channels/still picture flag cause jump program error

[MythTV]

#8096: Music Only channels/still picture flag cause jump program error
-------------------------------------+----------------------------
 Reporter:  mia1dolfan@…             |          Owner:  pbennett
     Type:  defect                   |         Status:  closed
 Priority:  minor                    |      Milestone:  unknown
Component:  MythTV - Video Playback  |        Version:  0.22-fixes
 Severity:  medium                   |     Resolution:  fixed
 Keywords:  hdhomerun tuning jump    |  Ticket locked:  0
-------------------------------------+----------------------------

Comment (by jyavenard):

 Replying to [comment:12 Peter Bennett <pbennett@…>]:
 > In [changeset:"28fe92a74d0cd903ad0c154fa3cd9a74019d1ca8/mythtv"]:
 > {{{
 > #!CommitTicketReference repository="mythtv"
 revision="28fe92a74d0cd903ad0c154fa3cd9a74019d1ca8"
 > Fix Seg Fault due to OSD painter being deleted while image loader
 threads are still using it.
 >
 > Image loading for the OSD uses ImageLoadThread and continues
 > loading while the video is playing. If the video playback
 > encounters an "InputChanged" situation it deletes the OSD and its
 > painter and re-creates it.  If the Image load is still running and
 > using the painter, it gets a Seg Fault calling a virtual function
 > using a corrupted object
 >
 > Exception Details:
 > 1   in MythPainter::GetFormatImage at mythpainter.cpp:540
 >
 > Fix: Keep the old osd painter valid until either it changes again
 > or the OSD is deleted.
 >
 > Refs #8096
 > }}}

 I don't see how the fix does work around the problem described.

 The only way to fix this is to use a reference counted object, and here
 it's not thread safe either.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/8096#comment:20>
MythTV <http://www.mythtv.org>
MythTV Media Center