[mythtv-commits] Ticket #12765: Patch to insure fd is valid before close

[MythTV]

#12765: Patch to insure fd is valid before close
-------------------------------------------------+-------------------------
     Reporter:  Gary Buhrmaster                  |      Owner:
  <gary.buhrmaster@…>                            |
         Type:  Patch - Bug Fix                  |     Status:  new
     Priority:  trivial                          |  Milestone:  unknown
    Component:  MythTV - MythSystem              |    Version:  Master Head
     Severity:  low                              |   Keywords:
Ticket locked:  0                                |
-------------------------------------------------+-------------------------
 valgrind reported "Warning: invalid file descriptor -1 in syscall close()"
 from mythsystemunix.cpp.  The relevant fd's are initialized to -1 and are
 updated to valid fds only if certain options are set in the invocation of
 the function.  In some cases, the fd remains -1, which results in the
 warning message.  Silence the warning by insuring that the fd is positive
 (as done elsewhere in the code) before issuing the close.  As this is just
 a warning message (no actual problem exists except for the warning
 message) the ticket priority/severity is set to trivial/low.

 github ref:
 https://github.com/garybuhrmaster/mythtv/commit/520538417c3fd0a1741bc47aaf4a54d6233c6f4e

 github git-am ref:
 https://github.com/garybuhrmaster/mythtv/commit/520538417c3fd0a1741bc47aaf4a54d6233c6f4e.patch

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12765>
MythTV <http://www.mythtv.org>
MythTV Media Center