[mythtv-commits] Ticket #12949: musicscanner: Compare music_directory.path as binary

[MythTV]

#12949: musicscanner: Compare music_directory.path as binary
--------------------------------------+-------------------------
     Reporter:  Ian Campbell <ijc@…>  |      Owner:  paulh
         Type:  Patch - Bug Fix       |     Status:  new
     Priority:  minor                 |  Milestone:  unknown
    Component:  Plugin - MythMusic    |    Version:  Master Head
     Severity:  medium                |   Keywords:
Ticket locked:  0                     |
--------------------------------------+-------------------------
 SQL string comparisons are case insensitive by default (who knew!),
 meaning that a music rescan will not pickup a renamed directory if it
 differs only in the case.

 Use BINARY rather than arranging for a case-sensitive comparison because
 the latter still considers 'a' and 'á' equal but for paths we need literal
 binary sameness.

 Apply the same logic to music_songs.filename, although I've not tripped
 over a related issue there.

 I have runtime tested this with the fixes/0.28 branch and build tested
 against master, the tip of both is identical for the file in question so I
 hope this is acceptable.

 github ref:
 https://github.com/ijc25/mythtv/commit/a469ce48ee00392d8a3f07dfead7e8af976706dd

 github git-am ref:
 https://github.com/ijc25/mythtv/commit/a469ce48ee00392d8a3f07dfead7e8af976706dd.patch

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12949>
MythTV <http://www.mythtv.org>
MythTV Media Center