[mythtv-commits] Ticket #12827: Raspberry Pi: Digital Audio does not work

[MythTV]

#12827: Raspberry Pi: Digital Audio does not work
----------------------------------+-----------------------------
 Reporter:  pbennett              |          Owner:  pbennett
     Type:  Bug Report - General  |         Status:  accepted
 Priority:  minor                 |      Milestone:  unknown
Component:  Ports - rPi           |        Version:  Master Head
 Severity:  medium                |     Resolution:
 Keywords:                        |  Ticket locked:  0
----------------------------------+-----------------------------

Comment (by pbennett):

 I have my fix ready. I am using option 4 above. Average over 60 frames if
 OpenMAX Audio with AC-3 passthru is specified.

 The code is using setting "AVSyncAveraging" for the averaging number. It
 defaults to 4 as in existing code, and to 60 when using OMX audio with
 AC-3 passthru. If you override AVSyncAveraging on the command line it will
 use the override value for every playback.

 I added a setting "!PlayerMaxDiverge" to replace the #define MAXDIVERGE
 3.0f. I also removed the #define DIVERGELIMIT 30.0f because that was
 having no effect on processing except limiting the divergence value
 reported in the log.

 The AVSync code should work identically to what it did before when not
 using OpenMAX with AC-3. Some things that were hardcoded constants are now
 member variables calculated against the avsync_averaging value and will
 come to the old hardcoded values when avsync_averaging defaults to 4.

 Another change that was necessary was removing the spdif container in the
 case of OpenMAX passthru. The bitstream is passed to OMX without the spdif
 container.

 I am deleting an unused and untested class AudioDecoderOMX. This supports
 a hardware audio decoder which cannot be used for licensing reasons and
 the code is not tested.

 http://openelec.tv/forum/124-raspberry-pi/59070-rpi-dts-gpu-decoding-
 lobby-dts-inc-now

 The change is not yet committed to MythTV repo. See the below commits in
 my repository to review the changes before I commit them to MythTV.

 Delete unused and untested class AudioDecoderOMX (see line 764)\\
 https://github.com/bennettpeter/mythtv/commit/d50b3c4be37007782668ca6dfa451626e7ec1612

 AVSync changes\\
 https://github.com/bennettpeter/mythtv/commit/06fc4834e7fcf8d597c2307f789c66886d74b11c

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12827#comment:5>
MythTV <http://www.mythtv.org>
MythTV Media Center