[mythtv-commits] Ticket #12742: Feature patch: Parse and insert XMLTV categories as genres for mythfilldatabase

MythTV noreply at mythtv.org
Mon Apr 25 05:30:15 UTC 2016


#12742: Feature patch: Parse and insert XMLTV categories as genres for
mythfilldatabase
-------------------------------------------------+-------------------------
     Reporter:  Gary Buhrmaster                  |      Owner:  stuartm
  <gary.buhrmaster@…>                            |
         Type:  Patch - Feature                  |     Status:  new
     Priority:  minor                            |  Milestone:  unknown
    Component:  MythTV - Mythfilldatabase        |    Version:  Master Head
     Severity:  medium                           |   Keywords:
Ticket locked:  0                                |
-------------------------------------------------+-------------------------
 Feature patch: Parse and insert XMLTV categories as genres (equivalent to
 DataDirect processing) in mythfilldatabase

 MythTV has the concept of a (single) category (and a category_type) in the
 program record, and a programgenres table for genres.  XMLTV has a concept
 of categories for a program, which is a list.  While categories and genres
 are not necessarily the same, they serve a somewhat equivalent purpose.
 And the existing DataDirect load treats the available categories from its
 source to be MythTV genres. While not all XMLTV grabbers provide a
 category list, some do (uk_atlas is one example), and being able to
 preserve and use that information seems to be desirable (note that those
 grabbers that provide at most one category are well handled without this
 patch).

 After applying these patches, those sources which provide additional
 categories via XMLTV will have that data available for processing via the
 programgenres table (power search rules?).

 The patches are separated so that they may be more easily reviewed by the
 developers.  While they have been compile tested one after the other, they
 have only been fully tested with real data as a complete set.

 Since this is a new capability, I have not created an additional patch to
 disable the inserting of the data as a new option for mythfilldatabase.
 If the developer reviewing the patches feels that such a capability is
 needed before accepting these patches, I can look at the best way to
 accomplish that.

 As an aside, having the programgenres table have a column named
 "relevance" which is a single character used to insure the key is unique
 does not seem optimal.  I presume there is a well thought out history
 there that I have not been able to follow.

 [[br]]
 [[br]]

 ''' Note that patch 0 (when applied) will require the committer to bump
 the ABI version (not included in the patch set because the patches may sit
 in review for some time, and one nominally wants the ABI version to
 reflect the commit date). '''

 Patch 0: Field definition in DBEvent:

 github ref:
 https://github.com/garybuhrmaster/mythtv/commit/182559340368ebc9b265a3f53916dc2db11afef7

 github git-am ref:
 https://github.com/garybuhrmaster/mythtv/commit/182559340368ebc9b265a3f53916dc2db11afef7.patch

 Patch 1: Add parsed categories to the genres list

 github ref:
 https://github.com/garybuhrmaster/mythtv/commit/7df795a4e359963ab7570101cf64c0241a6cc3b1

 github git-am ref:
 https://github.com/garybuhrmaster/mythtv/commit/7df795a4e359963ab7570101cf64c0241a6cc3b1.patch

 Patch 2: Insert any collected genres into the database

 github ref:
 https://github.com/garybuhrmaster/mythtv/commit/caa88590b0392d79f9a68662a5fd0f604d11ad0b

 github git-am ref:
 https://github.com/garybuhrmaster/mythtv/commit/caa88590b0392d79f9a68662a5fd0f604d11ad0b.patch

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12742>
MythTV <http://www.mythtv.org>
MythTV Media Center


More information about the mythtv-commits mailing list