[mythtv-commits] Ticket #12650: 0 byte fan art causes segmentation fault

[MythTV]

#12650: 0 byte fan art causes segmentation fault
-----------------------------------------+-----------------------------
 Reporter:  jflatt@…                     |          Owner:  jyavenard
     Type:  Bug Report - Crash           |         Status:  new
 Priority:  minor                        |      Milestone:  0.28
Component:  MythTV - Video Library       |        Version:  Master Head
 Severity:  medium                       |     Resolution:
 Keywords:  0 byte fanart fan art crash  |  Ticket locked:  0
-----------------------------------------+-----------------------------

Comment (by rsiddons):

 Previous analysis was incomplete and elected for the wrong solution.
 Ignore previous patch.

 Prior to 916e43bb52ba the socket wasn't added to the fileTransferList
 until the file had been opened successfully. That commit adds the socket
 to the list but doesn't remove it when deleting the failed File Transfer,
 leading to the disconnection event also trying to delete it.

 Proper solution is to reinstate previous behaviour of only adding
 successful File Transfers to the list.

 With new patch:

 Frontend:
 {{{
 2016-04-11 11:02:11.768981 D  No menu file
 /home/roger/.mythtv/videomenu.xml
 2016-04-11 11:02:17.868498 I  RemoteFile::FindFile(): looking for
 '/tmdb3.py_10693_coverart.jpg' on 'study' in group 'Coverart' (useregex:
 0, allowfallback: 0)
 2016-04-11 11:02:17.906931 E  RemoteFile::openSocket(file data socket):
 Failed to open socket, error was filetransfer_unable_to_open_file
 2016-04-11 11:02:17.907733 D
 RemoteFile(myth://Coverart@study/tmdb3.py_10693_coverart.jpg)
 2016-04-11 11:02:17.907777 I  RemoteFile::Exists(): looking for remote
 file: myth://Coverart@study/tmdb3.py_10693_coverart.jpg
 }}}

 Backend:
 {{{
 2016-04-11 11:02:17.868962 I  MainServer: Looking for file
 '/tmdb3.py_10693_coverart.jpg' on host 'study' in group 'Coverart'
 (useregex: 0, allowfallback: 1
 2016-04-11 11:02:17.868982 I  MainServer: Checking local host 'study' for
 file
 2016-04-11 11:02:17.875999 D  SG(Coverart): FindFile: Searching for
 '/tmdb3.py_10693_coverart.jpg'
 2016-04-11 11:02:17.876028 D  SG(Coverart): FindFileDir: Checking
 '/home/archive/myth/recordings' for
 '/home/archive/myth/recordings//tmdb3.py_10693_coverart.jpg'
 2016-04-11 11:02:17.876100 D  SG(Coverart): FindFile: Found
 '/home/archive/myth/recordings//tmdb3.py_10693_coverart.jpg'
 2016-04-11 11:02:17.876154 I  MainServer: File 0 was found at:
 'myth://Coverart@study/tmdb3.py_10693_coverart.jpg'
 2016-04-11 11:02:17.887966 I  MainServer: MainServer::ANN Playback
 2016-04-11 11:02:17.887990 I  MainServer: adding: study(2331da0) as a
 client (events: 0)
 2016-04-11 11:02:17.894675 D  SG(Coverart): FindFile: Searching for
 '/tmdb3.py_10693_coverart.jpg'
 2016-04-11 11:02:17.894701 D  SG(Coverart): FindFileDir: Checking
 '/home/archive/myth/recordings' for
 '/home/archive/myth/recordings//tmdb3.py_10693_coverart.jpg'
 2016-04-11 11:02:17.894750 D  SG(Coverart): FindFile: Found
 '/home/archive/myth/recordings//tmdb3.py_10693_coverart.jpg'
 2016-04-11 11:02:17.894769 I  MainServer:
 LocalFilePath(/tmdb3.py_10693_coverart.jpg 'tmdb3.py_10693_coverart.jpg'),
 found file through exhaustive search at
 '/home/archive/myth/recordings//tmdb3.py_10693_coverart.jpg'
 2016-04-11 11:02:17.905111 E
 FileRingBuf(/home/archive/myth/recordings//tmdb3.py_10693_coverart.jpg):
 OpenFile(): File too small (0B).
 2016-04-11 11:02:17.905166 I
 FileRingBuf(/home/archive/myth/recordings//tmdb3.py_10693_coverart.jpg):
 OpenFile() made 1 attempts in 10 ms
 2016-04-11 11:02:17.905186 I
 RingBuf(/home/archive/myth/recordings//tmdb3.py_10693_coverart.jpg):
 CalcReadAheadThresh(8000 Kb)
                          -> threshhold(3584 KB) min read(320 KB) blk
 size(128 KB)
 2016-04-11 11:02:17.906151 E  MainServer: Can't open
 /home/archive/myth/recordings//tmdb3.py_10693_coverart.jpg
 2016-04-11 11:02:17.906358 I  calling StopReads()
 2016-04-11 11:02:17.906416 I
 RingBuf(/home/archive/myth/recordings//tmdb3.py_10693_coverart.jpg):
 StopReads()
 2016-04-11 11:02:17.906709 W  MainServer: Unknown socket closing
 MythSocket(0x2372f10)
 2016-04-11 11:02:17.907598 I  Playback sock(2331da0) 'study' disconnected
 2016-04-11 11:02:17.908802 D  SG(Coverart): FindFile: Searching for
 'tmdb3.py_10693_coverart.jpg'
 2016-04-11 11:02:17.908819 D  SG(Coverart): FindFileDir: Checking
 '/home/archive/myth/recordings' for
 '/home/archive/myth/recordings/tmdb3.py_10693_coverart.jpg'
 2016-04-11 11:02:17.908851 D  SG(Coverart): FindFile: Found
 '/home/archive/myth/recordings/tmdb3.py_10693_coverart.jpg'
 }}}

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12650#comment:2>
MythTV <http://www.mythtv.org>
MythTV Media Center